tor

commit 755a8490018f051853c4628ca6a0c952c11edfdf
parent 45ad940ff7fedfbf135daad40eceed73b94a0693
Author: Nick Mathewson <nickm@torproject.org>
Date:   Tue, 18 Nov 2025 11:23:55 -0500

Fix shellcheck warnings about "x" comparisons.

See https://www.shellcheck.net/wiki/SC2268

Diffstat:
M
scripts/codegen/run_trunnel.sh
 | 
3
+--
M
scripts/maint/run_calltool.sh
 | 
3
+--
M
scripts/test/scan-build.sh
 | 
2
+-

3 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/scripts/codegen/run_trunnel.sh b/scripts/codegen/run_trunnel.sh
@@ -1,6 +1,6 @@
 #!/bin/sh
 
-if test "x$TRUNNEL_PATH" != "x"; then
+if test "$TRUNNEL_PATH" != ""; then
   PYTHONPATH="${TRUNNEL_PATH}:${PYTHONPATH}"
   export PYTHONPATH
 fi
@@ -12,4 +12,3 @@ OPTIONS="--require-version=1.5.1"
 find ./src/trunnel/ -name '*.trunnel' -exec python -m trunnel ${OPTIONS} {} \;
 
 python -m trunnel ${OPTIONS} --write-c-files --target-dir=./src/ext/trunnel/
-
diff --git a/scripts/maint/run_calltool.sh b/scripts/maint/run_calltool.sh
@@ -4,7 +4,7 @@
 
 set -e
 
-if test "x$CALLTOOL_PATH" != "x"; then
+if test "$CALLTOOL_PATH" != ""; then
     PYTHONPATH="${CALLTOOL_PATH}:${PYTHONPATH}"
     export PYTHONPATH
 fi
@@ -26,4 +26,3 @@ the calltool distribution.
 You can find calltool at
     https://gitweb.torproject.org/user/nickm/calltool.git
 EOF
-
diff --git a/scripts/test/scan-build.sh b/scripts/test/scan-build.sh
@@ -48,7 +48,7 @@ NOISY_CHECKERS="\
     -enable-checker alpha.deadcode.UnreachableCode \
 "
 
-if test "x$SCAN_BUILD_OUTPUT" != "x"; then
+if test "$SCAN_BUILD_OUTPUT" != ""; then
    OUTPUTARG="-o $SCAN_BUILD_OUTPUT"
 else
    OUTPUTARG=""