commit 45ad940ff7fedfbf135daad40eceed73b94a0693
parent 892d0f4517c29cbf4b66663734bec5f07690adc9
Author: Nick Mathewson <nickm@torproject.org>
Date: Tue, 18 Nov 2025 11:20:32 -0500
Fix new warnings found with Clang 21.1.5
Clang doesn't like it when we pass a reference to an uninitialized variable
as a `const *`.
These are all in the tests, so no bug.
Diffstat:
4 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/test/test_circuitpadding.c b/src/test/test_circuitpadding.c
@@ -1588,7 +1588,7 @@ simulate_single_hop_extend(circuit_t *client, circuit_t *mid_relay,
{
char whatevs_key[CPATH_KEY_MATERIAL_LEN];
char digest[DIGEST_LEN];
- tor_addr_t addr;
+ tor_addr_t addr = TOR_ADDR_NULL;
// Pretend a non-padding cell was sent
circpad_cell_event_nonpadding_sent(client);
diff --git a/src/test/test_conflux_pool.c b/src/test/test_conflux_pool.c
@@ -336,7 +336,7 @@ simulate_single_hop_extend(origin_circuit_t *client, int exit)
{
char whatevs_key[CPATH_KEY_MATERIAL_LEN];
char digest[DIGEST_LEN];
- tor_addr_t addr;
+ tor_addr_t addr = TOR_ADDR_NULL;
// Advance time a tiny bit so we can calculate an RTT
curr_mocked_time += 10 * TOR_NSEC_PER_MSEC;
diff --git a/src/test/test_hs_client.c b/src/test/test_hs_client.c
@@ -1094,7 +1094,7 @@ test_socks_hs_errors(void *arg)
char *desc_encoded = NULL;
circuit_t *circ = NULL;
origin_circuit_t *ocirc = NULL;
- tor_addr_t addr;
+ tor_addr_t addr = TOR_ADDR_NULL;
ed25519_keypair_t service_kp;
ed25519_keypair_t signing_kp;
entry_connection_t *socks_conn = NULL;
@@ -1268,7 +1268,7 @@ test_close_intro_circuit_failure(void *arg)
circuit_t *circ = NULL;
ed25519_keypair_t service_kp, intro_kp;
origin_circuit_t *ocirc = NULL;
- tor_addr_t addr;
+ tor_addr_t addr = TOR_ADDR_NULL;
const hs_cache_intro_state_t *entry;
(void) arg;
diff --git a/src/test/test_hs_intropoint.c b/src/test/test_hs_intropoint.c
@@ -544,7 +544,7 @@ test_intro_point_registration(void *arg)
or_circuit_t *intro_circ = NULL;
trn_cell_establish_intro_t *establish_intro_cell = NULL;
- ed25519_public_key_t auth_key;
+ ed25519_public_key_t auth_key = {0};
or_circuit_t *returned_intro_circ = NULL;