tor-browser

commit c31b8aecbf4e53d87070aa59d0fbefe714d18bfb
parent 0b4dad14e7fc31ec228204e2d1875e3f98726113
Author: André Bargull <andre.bargull@gmail.com>
Date:   Thu, 23 Oct 2025 10:14:51 +0000

Bug 1995575 - Part 1: Use at-start allocations for lowerForFPU on {mips,loong,riscv}64. r=spidermonkey-reviewers,jandem

No additional codegen changes are needed for FPU instructions.

Drive-by change:
- Change `src` to `input` in declaration to match name in method definition.

Differential Revision: https://phabricator.services.mozilla.com/D269416

Diffstat:
M
js/src/jit/arm/Lowering-arm.h
 | 
2
+-
M
js/src/jit/loong64/Lowering-loong64.cpp
 | 
6
+++---
M
js/src/jit/loong64/Lowering-loong64.h
 | 
2
+-
M
js/src/jit/mips-shared/Lowering-mips-shared.cpp
 | 
6
+++---
M
js/src/jit/mips-shared/Lowering-mips-shared.h
 | 
2
+-
M
js/src/jit/riscv64/Lowering-riscv64.cpp
 | 
6
+++---
M
js/src/jit/riscv64/Lowering-riscv64.h
 | 
2
+-

7 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/js/src/jit/arm/Lowering-arm.h b/js/src/jit/arm/Lowering-arm.h
@@ -61,7 +61,7 @@ class LIRGeneratorARM : public LIRGeneratorShared {
                           MDefinition* rhs);
 
   void lowerForFPU(LInstructionHelper<1, 1, 0>* ins, MDefinition* mir,
-                   MDefinition* src);
+                   MDefinition* input);
   template <size_t Temps>
   void lowerForFPU(LInstructionHelper<1, 2, Temps>* ins, MDefinition* mir,
                    MDefinition* lhs, MDefinition* rhs);
diff --git a/js/src/jit/loong64/Lowering-loong64.cpp b/js/src/jit/loong64/Lowering-loong64.cpp
@@ -120,7 +120,7 @@ void LIRGeneratorLOONG64::lowerForMulInt64(LMulI64* ins, MMul* mir,
 
 void LIRGeneratorLOONG64::lowerForFPU(LInstructionHelper<1, 1, 0>* ins,
                                       MDefinition* mir, MDefinition* input) {
-  ins->setOperand(0, useRegister(input));
+  ins->setOperand(0, useRegisterAtStart(input));
   define(
       ins, mir,
       LDefinition(LDefinition::TypeFrom(mir->type()), LDefinition::REGISTER));
@@ -130,8 +130,8 @@ template <size_t Temps>
 void LIRGeneratorLOONG64::lowerForFPU(LInstructionHelper<1, 2, Temps>* ins,
                                       MDefinition* mir, MDefinition* lhs,
                                       MDefinition* rhs) {
-  ins->setOperand(0, useRegister(lhs));
-  ins->setOperand(1, useRegister(rhs));
+  ins->setOperand(0, useRegisterAtStart(lhs));
+  ins->setOperand(1, useRegisterAtStart(rhs));
   define(
       ins, mir,
       LDefinition(LDefinition::TypeFrom(mir->type()), LDefinition::REGISTER));
diff --git a/js/src/jit/loong64/Lowering-loong64.h b/js/src/jit/loong64/Lowering-loong64.h
@@ -40,7 +40,7 @@ class LIRGeneratorLOONG64 : public LIRGeneratorShared {
                         MDefinition* rhs);
 
   void lowerForFPU(LInstructionHelper<1, 1, 0>* ins, MDefinition* mir,
-                   MDefinition* src);
+                   MDefinition* input);
   template <size_t Temps>
   void lowerForFPU(LInstructionHelper<1, 2, Temps>* ins, MDefinition* mir,
                    MDefinition* lhs, MDefinition* rhs);
diff --git a/js/src/jit/mips-shared/Lowering-mips-shared.cpp b/js/src/jit/mips-shared/Lowering-mips-shared.cpp
@@ -119,7 +119,7 @@ template void LIRGeneratorMIPSShared::lowerForShiftInt64(LRotateI64* ins,
 
 void LIRGeneratorMIPSShared::lowerForFPU(LInstructionHelper<1, 1, 0>* ins,
                                          MDefinition* mir, MDefinition* input) {
-  ins->setOperand(0, useRegister(input));
+  ins->setOperand(0, useRegisterAtStart(input));
   define(
       ins, mir,
       LDefinition(LDefinition::TypeFrom(mir->type()), LDefinition::REGISTER));
@@ -129,8 +129,8 @@ template <size_t Temps>
 void LIRGeneratorMIPSShared::lowerForFPU(LInstructionHelper<1, 2, Temps>* ins,
                                          MDefinition* mir, MDefinition* lhs,
                                          MDefinition* rhs) {
-  ins->setOperand(0, useRegister(lhs));
-  ins->setOperand(1, useRegister(rhs));
+  ins->setOperand(0, useRegisterAtStart(lhs));
+  ins->setOperand(1, useRegisterAtStart(rhs));
   define(
       ins, mir,
       LDefinition(LDefinition::TypeFrom(mir->type()), LDefinition::REGISTER));
diff --git a/js/src/jit/mips-shared/Lowering-mips-shared.h b/js/src/jit/mips-shared/Lowering-mips-shared.h
@@ -49,7 +49,7 @@ class LIRGeneratorMIPSShared : public LIRGeneratorShared {
                           MDefinition* rhs);
 
   void lowerForFPU(LInstructionHelper<1, 1, 0>* ins, MDefinition* mir,
-                   MDefinition* src);
+                   MDefinition* input);
   template <size_t Temps>
   void lowerForFPU(LInstructionHelper<1, 2, Temps>* ins, MDefinition* mir,
                    MDefinition* lhs, MDefinition* rhs);
diff --git a/js/src/jit/riscv64/Lowering-riscv64.cpp b/js/src/jit/riscv64/Lowering-riscv64.cpp
@@ -121,7 +121,7 @@ void LIRGeneratorRiscv64::lowerForMulInt64(LMulI64* ins, MMul* mir,
 
 void LIRGeneratorRiscv64::lowerForFPU(LInstructionHelper<1, 1, 0>* ins,
                                       MDefinition* mir, MDefinition* input) {
-  ins->setOperand(0, useRegister(input));
+  ins->setOperand(0, useRegisterAtStart(input));
   define(
       ins, mir,
       LDefinition(LDefinition::TypeFrom(mir->type()), LDefinition::REGISTER));
@@ -131,8 +131,8 @@ template <size_t Temps>
 void LIRGeneratorRiscv64::lowerForFPU(LInstructionHelper<1, 2, Temps>* ins,
                                       MDefinition* mir, MDefinition* lhs,
                                       MDefinition* rhs) {
-  ins->setOperand(0, useRegister(lhs));
-  ins->setOperand(1, useRegister(rhs));
+  ins->setOperand(0, useRegisterAtStart(lhs));
+  ins->setOperand(1, useRegisterAtStart(rhs));
   define(
       ins, mir,
       LDefinition(LDefinition::TypeFrom(mir->type()), LDefinition::REGISTER));
diff --git a/js/src/jit/riscv64/Lowering-riscv64.h b/js/src/jit/riscv64/Lowering-riscv64.h
@@ -40,7 +40,7 @@ class LIRGeneratorRiscv64 : public LIRGeneratorShared {
                         MDefinition* rhs);
 
   void lowerForFPU(LInstructionHelper<1, 1, 0>* ins, MDefinition* mir,
-                   MDefinition* src);
+                   MDefinition* input);
   template <size_t Temps>
   void lowerForFPU(LInstructionHelper<1, 2, Temps>* ins, MDefinition* mir,
                    MDefinition* lhs, MDefinition* rhs);