commit aa630ba9f1464faf74cef677dc1d510481e2209c parent 2fd6f6253989bbda44e162010569d224583bffe4 Author: Dan Baker <dbaker@mozilla.com> Date: Wed, 22 Oct 2025 14:21:07 -0600 Bug 1995393 - Vendor libwebrtc from 5f2da8d000 Upstream commit: https://webrtc.googlesource.com/src/+/5f2da8d00070b7e985f56e5ad4eea5e6a024887a clang-tidy: tidy-readability-redundant-declaration https://clang.llvm.org/extra/clang-tidy/checks/readability/redundant-declaration.html Bug: webrtc:424706384 Change-Id: If65947a54c423e2d33482e4b46e0a0861530ed92 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/402940 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Philipp Hancke <phancke@meta.com> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#45295} Diffstat:
82 files changed, 8 insertions(+), 202 deletions(-)
diff --git a/third_party/libwebrtc/README.mozilla.last-vendor b/third_party/libwebrtc/README.mozilla.last-vendor @@ -1,4 +1,4 @@ # ./mach python dom/media/webrtc/third_party_build/vendor-libwebrtc.py --from-local /Users/danielbaker/elm/.moz-fast-forward/moz-libwebrtc --commit mozpatches libwebrtc -libwebrtc updated from /Users/danielbaker/elm/.moz-fast-forward/moz-libwebrtc commit mozpatches on 2025-10-22T20:18:40.027915+00:00. +libwebrtc updated from /Users/danielbaker/elm/.moz-fast-forward/moz-libwebrtc commit mozpatches on 2025-10-22T20:20:52.762187+00:00. # base of lastest vendoring -5671453b03 +5f2da8d000 diff --git a/third_party/libwebrtc/api/audio_codecs/audio_decoder.cc b/third_party/libwebrtc/api/audio_codecs/audio_decoder.cc @@ -174,5 +174,4 @@ AudioDecoder::SpeechType AudioDecoder::ConvertSpeechType(int16_t type) { } } -constexpr int AudioDecoder::kMaxNumberOfChannels; } // namespace webrtc diff --git a/third_party/libwebrtc/api/audio_codecs/audio_encoder.cc b/third_party/libwebrtc/api/audio_codecs/audio_encoder.cc @@ -122,5 +122,4 @@ ANAStats AudioEncoder::GetANAStats() const { return ANAStats(); } -constexpr int AudioEncoder::kMaxNumberOfChannels; } // namespace webrtc diff --git a/third_party/libwebrtc/api/audio_codecs/opus/audio_encoder_opus_config.cc b/third_party/libwebrtc/api/audio_codecs/opus/audio_encoder_opus_config.cc @@ -27,10 +27,6 @@ constexpr int kDefaultLowRateComplexity = } // namespace -constexpr int AudioEncoderOpusConfig::kDefaultFrameSizeMs; -constexpr int AudioEncoderOpusConfig::kMinBitrateBps; -constexpr int AudioEncoderOpusConfig::kMaxBitrateBps; - AudioEncoderOpusConfig::AudioEncoderOpusConfig() : frame_size_ms(kDefaultFrameSizeMs), sample_rate_hz(48000), diff --git a/third_party/libwebrtc/api/rtp_parameters.cc b/third_party/libwebrtc/api/rtp_parameters.cc @@ -137,34 +137,6 @@ std::string RtpExtension::ToString() const { return sb.str(); } -constexpr char RtpExtension::kEncryptHeaderExtensionsUri[]; -constexpr char RtpExtension::kAudioLevelUri[]; -constexpr char RtpExtension::kTimestampOffsetUri[]; -constexpr char RtpExtension::kAbsSendTimeUri[]; -constexpr char RtpExtension::kAbsoluteCaptureTimeUri[]; -constexpr char RtpExtension::kVideoRotationUri[]; -constexpr char RtpExtension::kVideoContentTypeUri[]; -constexpr char RtpExtension::kVideoTimingUri[]; -constexpr char RtpExtension::kGenericFrameDescriptorUri00[]; -constexpr char RtpExtension::kDependencyDescriptorUri[]; -constexpr char RtpExtension::kVideoLayersAllocationUri[]; -constexpr char RtpExtension::kTransportSequenceNumberUri[]; -constexpr char RtpExtension::kTransportSequenceNumberV2Uri[]; -constexpr char RtpExtension::kPlayoutDelayUri[]; -constexpr char RtpExtension::kColorSpaceUri[]; -constexpr char RtpExtension::kMidUri[]; -constexpr char RtpExtension::kRidUri[]; -constexpr char RtpExtension::kRepairedRidUri[]; -constexpr char RtpExtension::kVideoFrameTrackingIdUri[]; -constexpr char RtpExtension::kCsrcAudioLevelsUri[]; -constexpr char RtpExtension::kCorruptionDetectionUri[]; - -constexpr int RtpExtension::kMinId; -constexpr int RtpExtension::kMaxId; -constexpr int RtpExtension::kMaxValueSize; -constexpr int RtpExtension::kOneByteHeaderExtensionMaxId; -constexpr int RtpExtension::kOneByteHeaderExtensionMaxValueSize; - bool RtpExtension::IsSupportedForAudio(absl::string_view uri) { return uri == RtpExtension::kAudioLevelUri || uri == RtpExtension::kAbsSendTimeUri || diff --git a/third_party/libwebrtc/api/transport/rtp/dependency_descriptor.cc b/third_party/libwebrtc/api/transport/rtp/dependency_descriptor.cc @@ -16,11 +16,6 @@ namespace webrtc { -constexpr int DependencyDescriptor::kMaxSpatialIds; -constexpr int DependencyDescriptor::kMaxTemporalIds; -constexpr int DependencyDescriptor::kMaxTemplates; -constexpr int DependencyDescriptor::kMaxDecodeTargets; - namespace webrtc_impl { absl::InlinedVector<DecodeTargetIndication, 10> StringToDecodeTargetIndications( diff --git a/third_party/libwebrtc/api/video_codecs/video_encoder.cc b/third_party/libwebrtc/api/video_codecs/video_encoder.cc @@ -86,12 +86,6 @@ VideoEncoder::ScalingSettings::ScalingSettings(const ScalingSettings&) = VideoEncoder::ScalingSettings::~ScalingSettings() {} -// static -constexpr VideoEncoder::ScalingSettings::KOff - VideoEncoder::ScalingSettings::kOff; -// static -constexpr uint8_t VideoEncoder::EncoderInfo::kMaxFramerateFraction; - bool VideoEncoder::ResolutionBitrateLimits::operator==( const ResolutionBitrateLimits& rhs) const { return frame_size_pixels == rhs.frame_size_pixels && diff --git a/third_party/libwebrtc/audio/audio_send_stream.cc b/third_party/libwebrtc/audio/audio_send_stream.cc @@ -98,8 +98,6 @@ void UpdateEventLogStreamConfig(RtcEventLog& event_log, } // namespace -constexpr char AudioAllocationConfig::kKey[]; - std::unique_ptr<StructParametersParser> AudioAllocationConfig::Parser() { return StructParametersParser::Create( // "min", &min_bitrate, // diff --git a/third_party/libwebrtc/logging/rtc_event_log/events/rtc_event_alr_state.cc b/third_party/libwebrtc/logging/rtc_event_log/events/rtc_event_alr_state.cc @@ -20,9 +20,6 @@ #include "logging/rtc_event_log/events/rtc_event_log_parse_status.h" namespace webrtc { -constexpr RtcEvent::Type RtcEventAlrState::kType; -constexpr RtcEventDefinition<RtcEventAlrState, LoggedAlrStateEvent, bool> - RtcEventAlrState::definition_; RtcEventAlrState::RtcEventAlrState(bool in_alr) : in_alr_(in_alr) {} diff --git a/third_party/libwebrtc/logging/rtc_event_log/events/rtc_event_audio_playout.cc b/third_party/libwebrtc/logging/rtc_event_log/events/rtc_event_audio_playout.cc @@ -15,15 +15,9 @@ #include "absl/memory/memory.h" #include "api/rtc_event_log/rtc_event.h" -#include "logging/rtc_event_log/events/rtc_event_definition.h" namespace webrtc { -constexpr RtcEventDefinition<RtcEventAudioPlayout, - LoggedAudioPlayoutEvent, - uint32_t> - RtcEventAudioPlayout::definition_; - RtcEventAudioPlayout::RtcEventAudioPlayout(uint32_t ssrc) : ssrc_(ssrc) {} RtcEventAudioPlayout::RtcEventAudioPlayout(const RtcEventAudioPlayout& other) diff --git a/third_party/libwebrtc/logging/rtc_event_log/events/rtc_event_begin_log.cc b/third_party/libwebrtc/logging/rtc_event_log/events/rtc_event_begin_log.cc @@ -23,9 +23,6 @@ #include "logging/rtc_event_log/events/rtc_event_log_parse_status.h" namespace webrtc { -constexpr RtcEvent::Type RtcEventBeginLog::kType; -constexpr EventParameters RtcEventBeginLog::event_params_; -constexpr FieldParameters RtcEventBeginLog::utc_start_time_params_; RtcEventBeginLog::RtcEventBeginLog(Timestamp timestamp, Timestamp utc_start_time) diff --git a/third_party/libwebrtc/logging/rtc_event_log/events/rtc_event_bwe_update_delay_based.cc b/third_party/libwebrtc/logging/rtc_event_log/events/rtc_event_bwe_update_delay_based.cc @@ -16,16 +16,9 @@ #include "absl/memory/memory.h" #include "api/rtc_event_log/rtc_event.h" #include "api/transport/bandwidth_usage.h" -#include "logging/rtc_event_log/events/rtc_event_definition.h" namespace webrtc { -constexpr RtcEventDefinition<RtcEventBweUpdateDelayBased, - LoggedBweDelayBasedUpdate, - int32_t, - BandwidthUsage> - RtcEventBweUpdateDelayBased::definition_; - RtcEventBweUpdateDelayBased::RtcEventBweUpdateDelayBased( int32_t bitrate_bps, BandwidthUsage detector_state) diff --git a/third_party/libwebrtc/logging/rtc_event_log/events/rtc_event_end_log.cc b/third_party/libwebrtc/logging/rtc_event_log/events/rtc_event_end_log.cc @@ -23,8 +23,6 @@ #include "logging/rtc_event_log/events/rtc_event_log_parse_status.h" namespace webrtc { -constexpr RtcEvent::Type RtcEventEndLog::kType; -constexpr EventParameters RtcEventEndLog::event_params_; RtcEventEndLog::RtcEventEndLog(Timestamp timestamp) : RtcEvent(timestamp.us()) {} diff --git a/third_party/libwebrtc/logging/rtc_event_log/events/rtc_event_field_encoding_unittest.cc b/third_party/libwebrtc/logging/rtc_event_log/events/rtc_event_field_encoding_unittest.cc @@ -218,21 +218,6 @@ class RtcTestEvent final : public RtcEvent { const std::string string_; }; -constexpr EventParameters RtcTestEvent::event_params; -constexpr FieldParameters RtcTestEvent::timestamp_params; -constexpr FieldParameters RtcTestEvent::bool_params; -constexpr FieldParameters RtcTestEvent::signed32_params; -constexpr FieldParameters RtcTestEvent::unsigned32_params; -constexpr FieldParameters RtcTestEvent::signed64_params; -constexpr FieldParameters RtcTestEvent::unsigned64_params; - -constexpr FieldParameters RtcTestEvent::optional32_params; -constexpr FieldParameters RtcTestEvent::optional64_params; -constexpr FieldParameters RtcTestEvent::wrapping21_params; -constexpr FieldParameters RtcTestEvent::string_params; - -constexpr RtcEvent::Type RtcTestEvent::kType; - class RtcEventFieldTest : public ::testing::Test { protected: void SetUp() override {} diff --git a/third_party/libwebrtc/modules/audio_coding/neteq/background_noise.cc b/third_party/libwebrtc/modules/audio_coding/neteq/background_noise.cc @@ -29,9 +29,6 @@ constexpr size_t kMaxSampleRate = 48000; } // namespace -// static -constexpr size_t BackgroundNoise::kMaxLpcOrder; - BackgroundNoise::BackgroundNoise(size_t num_channels) : num_channels_(num_channels), channel_parameters_(new ChannelParameters[num_channels_]) { diff --git a/third_party/libwebrtc/modules/audio_coding/neteq/test/neteq_decoding_test.cc b/third_party/libwebrtc/modules/audio_coding/neteq/test/neteq_decoding_test.cc @@ -70,12 +70,6 @@ void LoadDecoders(NetEq* neteq) { } // namespace -const int NetEqDecodingTest::kTimeStepMs; -const size_t NetEqDecodingTest::kBlockSize8kHz; -const size_t NetEqDecodingTest::kBlockSize16kHz; -const size_t NetEqDecodingTest::kBlockSize32kHz; -const int NetEqDecodingTest::kInitSampleRateHz; - NetEqDecodingTest::NetEqDecodingTest() : clock_(0), env_(CreateEnvironment(&clock_)), diff --git a/third_party/libwebrtc/modules/audio_mixer/frame_combiner.cc b/third_party/libwebrtc/modules/audio_mixer/frame_combiner.cc @@ -122,9 +122,6 @@ void InterleaveToAudioFrame(DeinterleavedView<float> deinterleaved, } } // namespace -constexpr size_t FrameCombiner::kMaximumNumberOfChannels; -constexpr size_t FrameCombiner::kMaximumChannelSize; - FrameCombiner::FrameCombiner(bool use_limiter) : data_dumper_(new ApmDataDumper(0)), limiter_(data_dumper_.get(), kMaximumChannelSize, "AudioMixer"), diff --git a/third_party/libwebrtc/modules/audio_processing/agc2/interpolated_gain_curve.cc b/third_party/libwebrtc/modules/audio_processing/agc2/interpolated_gain_curve.cc @@ -24,15 +24,6 @@ namespace webrtc { -constexpr std::array<float, kInterpolatedGainCurveTotalPoints> - InterpolatedGainCurve::approximation_params_x_; - -constexpr std::array<float, kInterpolatedGainCurveTotalPoints> - InterpolatedGainCurve::approximation_params_m_; - -constexpr std::array<float, kInterpolatedGainCurveTotalPoints> - InterpolatedGainCurve::approximation_params_q_; - InterpolatedGainCurve::InterpolatedGainCurve( ApmDataDumper* apm_data_dumper, absl::string_view histogram_name_prefix) diff --git a/third_party/libwebrtc/modules/audio_processing/agc2/limiter_db_gain_curve.cc b/third_party/libwebrtc/modules/audio_processing/agc2/limiter_db_gain_curve.cc @@ -84,10 +84,6 @@ LimiterDbGainCurve::LimiterDbGainCurve() RTC_CHECK_GE(max_input_level_db_, knee_start_dbfs_ + knee_smoothness_db_); } -constexpr double LimiterDbGainCurve::max_input_level_db_; -constexpr double LimiterDbGainCurve::knee_smoothness_db_; -constexpr double LimiterDbGainCurve::compression_ratio_; - double LimiterDbGainCurve::GetOutputLevelDbfs(double input_level_dbfs) const { if (input_level_dbfs < knee_start_dbfs_) { return input_level_dbfs; diff --git a/third_party/libwebrtc/modules/congestion_controller/goog_cc/acknowledged_bitrate_estimator_interface.cc b/third_party/libwebrtc/modules/congestion_controller/goog_cc/acknowledged_bitrate_estimator_interface.cc @@ -22,8 +22,6 @@ namespace webrtc { -constexpr char RobustThroughputEstimatorSettings::kKey[]; - RobustThroughputEstimatorSettings::RobustThroughputEstimatorSettings( const FieldTrialsView* key_value_config) { Parser()->Parse( diff --git a/third_party/libwebrtc/modules/congestion_controller/goog_cc/delay_based_bwe.cc b/third_party/libwebrtc/modules/congestion_controller/goog_cc/delay_based_bwe.cc @@ -47,8 +47,6 @@ constexpr TimeDelta kSendTimeGroupLength = TimeDelta::Millis(5); constexpr uint32_t kFixedSsrc = 0; } // namespace -constexpr char BweSeparateAudioPacketsSettings::kKey[]; - BweSeparateAudioPacketsSettings::BweSeparateAudioPacketsSettings( const FieldTrialsView* key_value_config) { Parser()->Parse( diff --git a/third_party/libwebrtc/modules/congestion_controller/goog_cc/inter_arrival_delta.cc b/third_party/libwebrtc/modules/congestion_controller/goog_cc/inter_arrival_delta.cc @@ -22,7 +22,6 @@ namespace webrtc { static constexpr TimeDelta kBurstDeltaThreshold = TimeDelta::Millis(5); static constexpr TimeDelta kMaxBurstDuration = TimeDelta::Millis(100); -constexpr TimeDelta InterArrivalDelta::kArrivalTimeOffsetThreshold; InterArrivalDelta::InterArrivalDelta(TimeDelta send_time_group_length) : send_time_group_length_(send_time_group_length), diff --git a/third_party/libwebrtc/modules/congestion_controller/goog_cc/trendline_estimator.cc b/third_party/libwebrtc/modules/congestion_controller/goog_cc/trendline_estimator.cc @@ -116,8 +116,6 @@ constexpr int kDeltaCounterMax = 1000; } // namespace -constexpr char TrendlineEstimatorSettings::kKey[]; - TrendlineEstimatorSettings::TrendlineEstimatorSettings( const FieldTrialsView& key_value_config) { if (key_value_config.IsEnabled(kBweWindowSizeInPacketsExperiment)) { diff --git a/third_party/libwebrtc/modules/video_coding/codecs/vp8/default_temporal_layers.cc b/third_party/libwebrtc/modules/video_coding/codecs/vp8/default_temporal_layers.cc @@ -123,8 +123,6 @@ size_t BufferToIndex(Vp8BufferReference buffer) { } // namespace -constexpr size_t DefaultTemporalLayers::kNumReferenceBuffers; - std::vector<DefaultTemporalLayers::DependencyInfo> DefaultTemporalLayers::GetDependencyInfo(size_t num_layers) { // For indexing in the patterns described below (which temporal layers they diff --git a/third_party/libwebrtc/modules/video_coding/codecs/vp8/screenshare_layers.cc b/third_party/libwebrtc/modules/video_coding/codecs/vp8/screenshare_layers.cc @@ -51,8 +51,6 @@ constexpr auto kSwitch = DecodeTargetIndication::kSwitch; const double ScreenshareLayers::kMaxTL0FpsReduction = 2.5; const double ScreenshareLayers::kAcceptableTargetOvershoot = 2.0; -constexpr int ScreenshareLayers::kMaxNumTemporalLayers; - // Always emit a frame with certain interval, even if bitrate targets have // been exceeded. This prevents needless keyframe requests. const int ScreenshareLayers::kMaxFrameIntervalMs = 2750; diff --git a/third_party/libwebrtc/modules/video_coding/nack_requester.cc b/third_party/libwebrtc/modules/video_coding/nack_requester.cc @@ -52,8 +52,6 @@ TimeDelta GetSendNackDelay(const FieldTrialsView& field_trials) { } } // namespace -constexpr TimeDelta NackPeriodicProcessor::kUpdateInterval; - NackPeriodicProcessor::NackPeriodicProcessor(TimeDelta update_interval) : update_interval_(update_interval) {} diff --git a/third_party/libwebrtc/modules/video_coding/svc/scalability_structure_full_svc.cc b/third_party/libwebrtc/modules/video_coding/svc/scalability_structure_full_svc.cc @@ -23,10 +23,6 @@ namespace webrtc { -constexpr int ScalabilityStructureFullSvc::kMaxNumSpatialLayers; -constexpr int ScalabilityStructureFullSvc::kMaxNumTemporalLayers; -constexpr absl::string_view ScalabilityStructureFullSvc::kFramePatternNames[]; - ScalabilityStructureFullSvc::ScalabilityStructureFullSvc( int num_spatial_layers, int num_temporal_layers, diff --git a/third_party/libwebrtc/modules/video_coding/svc/scalability_structure_key_svc.cc b/third_party/libwebrtc/modules/video_coding/svc/scalability_structure_key_svc.cc @@ -22,9 +22,6 @@ namespace webrtc { -constexpr int ScalabilityStructureKeySvc::kMaxNumSpatialLayers; -constexpr int ScalabilityStructureKeySvc::kMaxNumTemporalLayers; - ScalabilityStructureKeySvc::ScalabilityStructureKeySvc(int num_spatial_layers, int num_temporal_layers) : num_spatial_layers_(num_spatial_layers), diff --git a/third_party/libwebrtc/modules/video_coding/svc/scalability_structure_l2t2_key_shift.cc b/third_party/libwebrtc/modules/video_coding/svc/scalability_structure_l2t2_key_shift.cc @@ -39,9 +39,6 @@ Dti(int sid, int tid, const ScalableVideoController::LayerFrameConfig& config) { } // namespace -constexpr int ScalabilityStructureL2T2KeyShift::kNumSpatialLayers; -constexpr int ScalabilityStructureL2T2KeyShift::kNumTemporalLayers; - ScalabilityStructureL2T2KeyShift::~ScalabilityStructureL2T2KeyShift() = default; ScalableVideoController::StreamLayersConfig diff --git a/third_party/libwebrtc/modules/video_coding/svc/scalability_structure_simulcast.cc b/third_party/libwebrtc/modules/video_coding/svc/scalability_structure_simulcast.cc @@ -39,9 +39,6 @@ Dti(int sid, int tid, const ScalableVideoController::LayerFrameConfig& config) { } // namespace -constexpr int ScalabilityStructureSimulcast::kMaxNumSpatialLayers; -constexpr int ScalabilityStructureSimulcast::kMaxNumTemporalLayers; - ScalabilityStructureSimulcast::ScalabilityStructureSimulcast( int num_spatial_layers, int num_temporal_layers, diff --git a/third_party/libwebrtc/modules/video_coding/timing/jitter_estimator.cc b/third_party/libwebrtc/modules/video_coding/timing/jitter_estimator.cc @@ -83,8 +83,6 @@ constexpr Frequency kMaxFramerateEstimate = Frequency::Hertz(200); } // namespace -constexpr char JitterEstimator::Config::kFieldTrialsKey[]; - JitterEstimator::Config JitterEstimator::Config::ParseAndValidate( absl::string_view field_trial) { Config config; diff --git a/third_party/libwebrtc/moz-patch-stack/s0001.patch b/third_party/libwebrtc/moz-patch-stack/s0001.patch @@ -399,10 +399,10 @@ index 6ba3292fca..5d3a731864 100644 RTPHeader(); RTPHeader(const RTPHeader& other); diff --git a/api/rtp_parameters.cc b/api/rtp_parameters.cc -index 06c581157a..8a5bbd8631 100644 +index 7bd443f711..a433aa21e7 100644 --- a/api/rtp_parameters.cc +++ b/api/rtp_parameters.cc -@@ -172,7 +172,8 @@ bool RtpExtension::IsSupportedForAudio(absl::string_view uri) { +@@ -144,7 +144,8 @@ bool RtpExtension::IsSupportedForAudio(absl::string_view uri) { uri == RtpExtension::kTransportSequenceNumberUri || uri == RtpExtension::kTransportSequenceNumberV2Uri || uri == RtpExtension::kMidUri || uri == RtpExtension::kRidUri || diff --git a/third_party/libwebrtc/moz-patch-stack/s0029.patch b/third_party/libwebrtc/moz-patch-stack/s0029.patch @@ -15,10 +15,10 @@ Mercurial Revision: https://hg.mozilla.org/mozilla-central/rev/d380a43d59f4f7cbc 4 files changed, 35 insertions(+) diff --git a/audio/audio_send_stream.cc b/audio/audio_send_stream.cc -index 5b6c070d02..bd3b7ca994 100644 +index ac91dd55f7..9e638eba2c 100644 --- a/audio/audio_send_stream.cc +++ b/audio/audio_send_stream.cc -@@ -437,6 +437,7 @@ webrtc::AudioSendStream::Stats AudioSendStream::GetStats( +@@ -435,6 +435,7 @@ webrtc::AudioSendStream::Stats AudioSendStream::GetStats( stats.target_bitrate_bps = channel_send_->GetTargetBitrate(); webrtc::CallSendStatistics call_stats = channel_send_->GetRTCPStatistics(); diff --git a/third_party/libwebrtc/moz-patch-stack/s0046.patch b/third_party/libwebrtc/moz-patch-stack/s0046.patch @@ -8,10 +8,10 @@ Subject: Bug 1766646 - (fix-b556b08668) avoid InlinedVector method that can 1 file changed, 8 insertions(+) diff --git a/api/video_codecs/video_encoder.cc b/api/video_codecs/video_encoder.cc -index d549e87d75..624fa5392e 100644 +index 31807707d9..cff9cf7f78 100644 --- a/api/video_codecs/video_encoder.cc +++ b/api/video_codecs/video_encoder.cc -@@ -189,7 +189,15 @@ std::string VideoEncoder::EncoderInfo::ToString() const { +@@ -183,7 +183,15 @@ std::string VideoEncoder::EncoderInfo::ToString() const { for (size_t i = 0; i < preferred_pixel_formats.size(); ++i) { if (i > 0) oss << ", "; diff --git a/third_party/libwebrtc/net/dcsctp/packet/chunk/abort_chunk.cc b/third_party/libwebrtc/net/dcsctp/packet/chunk/abort_chunk.cc @@ -33,7 +33,6 @@ namespace dcsctp { // / zero or more Error Causes / // \ \ // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ -constexpr int AbortChunk::kType; std::optional<AbortChunk> AbortChunk::Parse( webrtc::ArrayView<const uint8_t> data) { diff --git a/third_party/libwebrtc/net/dcsctp/packet/chunk/cookie_ack_chunk.cc b/third_party/libwebrtc/net/dcsctp/packet/chunk/cookie_ack_chunk.cc @@ -25,7 +25,6 @@ namespace dcsctp { // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ // | Type = 11 |Chunk Flags | Length = 4 | // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ -constexpr int CookieAckChunk::kType; std::optional<CookieAckChunk> CookieAckChunk::Parse( webrtc::ArrayView<const uint8_t> data) { diff --git a/third_party/libwebrtc/net/dcsctp/packet/chunk/cookie_echo_chunk.cc b/third_party/libwebrtc/net/dcsctp/packet/chunk/cookie_echo_chunk.cc @@ -30,7 +30,6 @@ namespace dcsctp { // / Cookie / // \ \ // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ -constexpr int CookieEchoChunk::kType; std::optional<CookieEchoChunk> CookieEchoChunk::Parse( webrtc::ArrayView<const uint8_t> data) { diff --git a/third_party/libwebrtc/net/dcsctp/packet/chunk/data_chunk.cc b/third_party/libwebrtc/net/dcsctp/packet/chunk/data_chunk.cc @@ -42,7 +42,6 @@ namespace dcsctp { // / User Data (seq n of Stream S) / // \ \ // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ -constexpr int DataChunk::kType; std::optional<DataChunk> DataChunk::Parse( webrtc::ArrayView<const uint8_t> data) { diff --git a/third_party/libwebrtc/net/dcsctp/packet/chunk/error_chunk.cc b/third_party/libwebrtc/net/dcsctp/packet/chunk/error_chunk.cc @@ -33,7 +33,6 @@ namespace dcsctp { // / one or more Error Causes / // \ \ // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ -constexpr int ErrorChunk::kType; std::optional<ErrorChunk> ErrorChunk::Parse( webrtc::ArrayView<const uint8_t> data) { diff --git a/third_party/libwebrtc/net/dcsctp/packet/chunk/forward_tsn_chunk.cc b/third_party/libwebrtc/net/dcsctp/packet/chunk/forward_tsn_chunk.cc @@ -42,7 +42,6 @@ namespace dcsctp { // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ // | Stream-N | Stream Sequence-N | // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ -constexpr int ForwardTsnChunk::kType; std::optional<ForwardTsnChunk> ForwardTsnChunk::Parse( webrtc::ArrayView<const uint8_t> data) { diff --git a/third_party/libwebrtc/net/dcsctp/packet/chunk/heartbeat_ack_chunk.cc b/third_party/libwebrtc/net/dcsctp/packet/chunk/heartbeat_ack_chunk.cc @@ -33,7 +33,6 @@ namespace dcsctp { // / Heartbeat Information TLV (Variable-Length) / // \ \ // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ -constexpr int HeartbeatAckChunk::kType; std::optional<HeartbeatAckChunk> HeartbeatAckChunk::Parse( webrtc::ArrayView<const uint8_t> data) { diff --git a/third_party/libwebrtc/net/dcsctp/packet/chunk/heartbeat_request_chunk.cc b/third_party/libwebrtc/net/dcsctp/packet/chunk/heartbeat_request_chunk.cc @@ -33,7 +33,6 @@ namespace dcsctp { // / Heartbeat Information TLV (Variable-Length) / // \ \ // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ -constexpr int HeartbeatRequestChunk::kType; std::optional<HeartbeatRequestChunk> HeartbeatRequestChunk::Parse( webrtc::ArrayView<const uint8_t> data) { diff --git a/third_party/libwebrtc/net/dcsctp/packet/chunk/idata_chunk.cc b/third_party/libwebrtc/net/dcsctp/packet/chunk/idata_chunk.cc @@ -44,7 +44,6 @@ namespace dcsctp { // / User Data / // \ \ // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ -constexpr int IDataChunk::kType; std::optional<IDataChunk> IDataChunk::Parse( webrtc::ArrayView<const uint8_t> data) { diff --git a/third_party/libwebrtc/net/dcsctp/packet/chunk/iforward_tsn_chunk.cc b/third_party/libwebrtc/net/dcsctp/packet/chunk/iforward_tsn_chunk.cc @@ -47,7 +47,6 @@ namespace dcsctp { // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ // | Message Identifier | // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ -constexpr int IForwardTsnChunk::kType; std::optional<IForwardTsnChunk> IForwardTsnChunk::Parse( webrtc::ArrayView<const uint8_t> data) { diff --git a/third_party/libwebrtc/net/dcsctp/packet/chunk/init_ack_chunk.cc b/third_party/libwebrtc/net/dcsctp/packet/chunk/init_ack_chunk.cc @@ -43,7 +43,6 @@ namespace dcsctp { // / Optional/Variable-Length Parameters / // \ \ // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ -constexpr int InitAckChunk::kType; std::optional<InitAckChunk> InitAckChunk::Parse( webrtc::ArrayView<const uint8_t> data) { diff --git a/third_party/libwebrtc/net/dcsctp/packet/chunk/init_chunk.cc b/third_party/libwebrtc/net/dcsctp/packet/chunk/init_chunk.cc @@ -43,7 +43,6 @@ namespace dcsctp { // / Optional/Variable-Length Parameters / // \ \ // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ -constexpr int InitChunk::kType; std::optional<InitChunk> InitChunk::Parse( webrtc::ArrayView<const uint8_t> data) { diff --git a/third_party/libwebrtc/net/dcsctp/packet/chunk/reconfig_chunk.cc b/third_party/libwebrtc/net/dcsctp/packet/chunk/reconfig_chunk.cc @@ -37,7 +37,6 @@ namespace dcsctp { // / Re-configuration Parameter (optional) / // \ \ // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ -constexpr int ReConfigChunk::kType; std::optional<ReConfigChunk> ReConfigChunk::Parse( webrtc::ArrayView<const uint8_t> data) { diff --git a/third_party/libwebrtc/net/dcsctp/packet/chunk/sack_chunk.cc b/third_party/libwebrtc/net/dcsctp/packet/chunk/sack_chunk.cc @@ -56,7 +56,6 @@ namespace dcsctp { // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ // | Duplicate TSN X | // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ -constexpr int SackChunk::kType; std::optional<SackChunk> SackChunk::Parse( webrtc::ArrayView<const uint8_t> data) { diff --git a/third_party/libwebrtc/net/dcsctp/packet/chunk/shutdown_ack_chunk.cc b/third_party/libwebrtc/net/dcsctp/packet/chunk/shutdown_ack_chunk.cc @@ -25,7 +25,6 @@ namespace dcsctp { // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ // | Type = 8 |Chunk Flags | Length = 4 | // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ -constexpr int ShutdownAckChunk::kType; std::optional<ShutdownAckChunk> ShutdownAckChunk::Parse( webrtc::ArrayView<const uint8_t> data) { diff --git a/third_party/libwebrtc/net/dcsctp/packet/chunk/shutdown_chunk.cc b/third_party/libwebrtc/net/dcsctp/packet/chunk/shutdown_chunk.cc @@ -30,7 +30,6 @@ namespace dcsctp { // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ // | Cumulative TSN Ack | // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ -constexpr int ShutdownChunk::kType; std::optional<ShutdownChunk> ShutdownChunk::Parse( webrtc::ArrayView<const uint8_t> data) { diff --git a/third_party/libwebrtc/net/dcsctp/packet/chunk/shutdown_complete_chunk.cc b/third_party/libwebrtc/net/dcsctp/packet/chunk/shutdown_complete_chunk.cc @@ -27,7 +27,6 @@ namespace dcsctp { // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ // | Type = 14 |Reserved |T| Length = 4 | // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ -constexpr int ShutdownCompleteChunk::kType; std::optional<ShutdownCompleteChunk> ShutdownCompleteChunk::Parse( webrtc::ArrayView<const uint8_t> data) { diff --git a/third_party/libwebrtc/net/dcsctp/packet/error_cause/cookie_received_while_shutting_down_cause.cc b/third_party/libwebrtc/net/dcsctp/packet/error_cause/cookie_received_while_shutting_down_cause.cc @@ -23,7 +23,6 @@ namespace dcsctp { // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ // | Cause Code=10 | Cause Length=4 | // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ -constexpr int CookieReceivedWhileShuttingDownCause::kType; std::optional<CookieReceivedWhileShuttingDownCause> CookieReceivedWhileShuttingDownCause::Parse( diff --git a/third_party/libwebrtc/net/dcsctp/packet/error_cause/invalid_mandatory_parameter_cause.cc b/third_party/libwebrtc/net/dcsctp/packet/error_cause/invalid_mandatory_parameter_cause.cc @@ -23,7 +23,6 @@ namespace dcsctp { // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ // | Cause Code=7 | Cause Length=4 | // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ -constexpr int InvalidMandatoryParameterCause::kType; std::optional<InvalidMandatoryParameterCause> InvalidMandatoryParameterCause::Parse(webrtc::ArrayView<const uint8_t> data) { diff --git a/third_party/libwebrtc/net/dcsctp/packet/error_cause/invalid_stream_identifier_cause.cc b/third_party/libwebrtc/net/dcsctp/packet/error_cause/invalid_stream_identifier_cause.cc @@ -29,7 +29,6 @@ namespace dcsctp { // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ // | Stream Identifier | (Reserved) | // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ -constexpr int InvalidStreamIdentifierCause::kType; std::optional<InvalidStreamIdentifierCause> InvalidStreamIdentifierCause::Parse( webrtc::ArrayView<const uint8_t> data) { diff --git a/third_party/libwebrtc/net/dcsctp/packet/error_cause/missing_mandatory_parameter_cause.cc b/third_party/libwebrtc/net/dcsctp/packet/error_cause/missing_mandatory_parameter_cause.cc @@ -35,7 +35,6 @@ namespace dcsctp { // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ // | Missing Param Type #N-1 | Missing Param Type #N | // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ -constexpr int MissingMandatoryParameterCause::kType; std::optional<MissingMandatoryParameterCause> MissingMandatoryParameterCause::Parse(webrtc::ArrayView<const uint8_t> data) { diff --git a/third_party/libwebrtc/net/dcsctp/packet/error_cause/no_user_data_cause.cc b/third_party/libwebrtc/net/dcsctp/packet/error_cause/no_user_data_cause.cc @@ -30,7 +30,6 @@ namespace dcsctp { // / TSN value / // \ \ // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ -constexpr int NoUserDataCause::kType; std::optional<NoUserDataCause> NoUserDataCause::Parse( webrtc::ArrayView<const uint8_t> data) { diff --git a/third_party/libwebrtc/net/dcsctp/packet/error_cause/out_of_resource_error_cause.cc b/third_party/libwebrtc/net/dcsctp/packet/error_cause/out_of_resource_error_cause.cc @@ -23,7 +23,6 @@ namespace dcsctp { // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ // | Cause Code=4 | Cause Length=4 | // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ -constexpr int OutOfResourceErrorCause::kType; std::optional<OutOfResourceErrorCause> OutOfResourceErrorCause::Parse( webrtc::ArrayView<const uint8_t> data) { diff --git a/third_party/libwebrtc/net/dcsctp/packet/error_cause/protocol_violation_cause.cc b/third_party/libwebrtc/net/dcsctp/packet/error_cause/protocol_violation_cause.cc @@ -31,7 +31,6 @@ namespace dcsctp { // / Additional Information / // \ \ // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ -constexpr int ProtocolViolationCause::kType; std::optional<ProtocolViolationCause> ProtocolViolationCause::Parse( webrtc::ArrayView<const uint8_t> data) { diff --git a/third_party/libwebrtc/net/dcsctp/packet/error_cause/restart_of_an_association_with_new_address_cause.cc b/third_party/libwebrtc/net/dcsctp/packet/error_cause/restart_of_an_association_with_new_address_cause.cc @@ -30,7 +30,6 @@ namespace dcsctp { // / New Address TLVs / // \ \ // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ -constexpr int RestartOfAnAssociationWithNewAddressesCause::kType; std::optional<RestartOfAnAssociationWithNewAddressesCause> RestartOfAnAssociationWithNewAddressesCause::Parse( diff --git a/third_party/libwebrtc/net/dcsctp/packet/error_cause/stale_cookie_error_cause.cc b/third_party/libwebrtc/net/dcsctp/packet/error_cause/stale_cookie_error_cause.cc @@ -28,7 +28,6 @@ namespace dcsctp { // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ // | Measure of Staleness (usec.) | // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ -constexpr int StaleCookieErrorCause::kType; std::optional<StaleCookieErrorCause> StaleCookieErrorCause::Parse( webrtc::ArrayView<const uint8_t> data) { diff --git a/third_party/libwebrtc/net/dcsctp/packet/error_cause/unrecognized_chunk_type_cause.cc b/third_party/libwebrtc/net/dcsctp/packet/error_cause/unrecognized_chunk_type_cause.cc @@ -30,7 +30,6 @@ namespace dcsctp { // / Unrecognized Chunk / // \ \ // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ -constexpr int UnrecognizedChunkTypeCause::kType; std::optional<UnrecognizedChunkTypeCause> UnrecognizedChunkTypeCause::Parse( webrtc::ArrayView<const uint8_t> data) { diff --git a/third_party/libwebrtc/net/dcsctp/packet/error_cause/unrecognized_parameter_cause.cc b/third_party/libwebrtc/net/dcsctp/packet/error_cause/unrecognized_parameter_cause.cc @@ -28,7 +28,6 @@ namespace dcsctp { // / Unrecognized Parameters / // \ \ // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ -constexpr int UnrecognizedParametersCause::kType; std::optional<UnrecognizedParametersCause> UnrecognizedParametersCause::Parse( webrtc::ArrayView<const uint8_t> data) { diff --git a/third_party/libwebrtc/net/dcsctp/packet/error_cause/unresolvable_address_cause.cc b/third_party/libwebrtc/net/dcsctp/packet/error_cause/unresolvable_address_cause.cc @@ -28,7 +28,6 @@ namespace dcsctp { // / Unresolvable Address / // \ \ // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ -constexpr int UnresolvableAddressCause::kType; std::optional<UnresolvableAddressCause> UnresolvableAddressCause::Parse( webrtc::ArrayView<const uint8_t> data) { diff --git a/third_party/libwebrtc/net/dcsctp/packet/error_cause/user_initiated_abort_cause.cc b/third_party/libwebrtc/net/dcsctp/packet/error_cause/user_initiated_abort_cause.cc @@ -31,7 +31,6 @@ namespace dcsctp { // / Upper Layer Abort Reason / // \ \ // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ -constexpr int UserInitiatedAbortCause::kType; std::optional<UserInitiatedAbortCause> UserInitiatedAbortCause::Parse( webrtc::ArrayView<const uint8_t> data) { diff --git a/third_party/libwebrtc/net/dcsctp/packet/parameter/add_incoming_streams_request_parameter.cc b/third_party/libwebrtc/net/dcsctp/packet/parameter/add_incoming_streams_request_parameter.cc @@ -33,7 +33,6 @@ namespace dcsctp { // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ // | Number of new streams | Reserved | // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ -constexpr int AddIncomingStreamsRequestParameter::kType; std::optional<AddIncomingStreamsRequestParameter> AddIncomingStreamsRequestParameter::Parse( diff --git a/third_party/libwebrtc/net/dcsctp/packet/parameter/add_outgoing_streams_request_parameter.cc b/third_party/libwebrtc/net/dcsctp/packet/parameter/add_outgoing_streams_request_parameter.cc @@ -33,7 +33,6 @@ namespace dcsctp { // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ // | Number of new streams | Reserved | // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ -constexpr int AddOutgoingStreamsRequestParameter::kType; std::optional<AddOutgoingStreamsRequestParameter> AddOutgoingStreamsRequestParameter::Parse( diff --git a/third_party/libwebrtc/net/dcsctp/packet/parameter/forward_tsn_supported_parameter.cc b/third_party/libwebrtc/net/dcsctp/packet/parameter/forward_tsn_supported_parameter.cc @@ -24,7 +24,6 @@ namespace dcsctp { // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ // | Parameter Type = 49152 | Parameter Length = 4 | // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ -constexpr int ForwardTsnSupportedParameter::kType; std::optional<ForwardTsnSupportedParameter> ForwardTsnSupportedParameter::Parse( webrtc::ArrayView<const uint8_t> data) { diff --git a/third_party/libwebrtc/net/dcsctp/packet/parameter/heartbeat_info_parameter.cc b/third_party/libwebrtc/net/dcsctp/packet/parameter/heartbeat_info_parameter.cc @@ -32,7 +32,6 @@ namespace dcsctp { // / Heartbeat Information TLV (Variable-Length) / // \ \ // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ -constexpr int HeartbeatInfoParameter::kType; std::optional<HeartbeatInfoParameter> HeartbeatInfoParameter::Parse( webrtc::ArrayView<const uint8_t> data) { diff --git a/third_party/libwebrtc/net/dcsctp/packet/parameter/incoming_ssn_reset_request_parameter.cc b/third_party/libwebrtc/net/dcsctp/packet/parameter/incoming_ssn_reset_request_parameter.cc @@ -40,7 +40,6 @@ namespace dcsctp { // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ // | Stream Number N-1 (optional) | Stream Number N (optional) | // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ -constexpr int IncomingSSNResetRequestParameter::kType; std::optional<IncomingSSNResetRequestParameter> IncomingSSNResetRequestParameter::Parse(webrtc::ArrayView<const uint8_t> data) { diff --git a/third_party/libwebrtc/net/dcsctp/packet/parameter/outgoing_ssn_reset_request_parameter.cc b/third_party/libwebrtc/net/dcsctp/packet/parameter/outgoing_ssn_reset_request_parameter.cc @@ -44,7 +44,6 @@ namespace dcsctp { // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ // | Stream Number N-1 (optional) | Stream Number N (optional) | // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ -constexpr int OutgoingSSNResetRequestParameter::kType; std::optional<OutgoingSSNResetRequestParameter> OutgoingSSNResetRequestParameter::Parse(webrtc::ArrayView<const uint8_t> data) { diff --git a/third_party/libwebrtc/net/dcsctp/packet/parameter/reconfiguration_response_parameter.cc b/third_party/libwebrtc/net/dcsctp/packet/parameter/reconfiguration_response_parameter.cc @@ -41,7 +41,6 @@ namespace dcsctp { // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ // | Receiver's Next TSN (optional) | // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ -constexpr int ReconfigurationResponseParameter::kType; absl::string_view ToString(ReconfigurationResponseParameter::Result result) { switch (result) { diff --git a/third_party/libwebrtc/net/dcsctp/packet/parameter/ssn_tsn_reset_request_parameter.cc b/third_party/libwebrtc/net/dcsctp/packet/parameter/ssn_tsn_reset_request_parameter.cc @@ -31,7 +31,6 @@ namespace dcsctp { // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ // | Re-configuration Request Sequence Number | // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ -constexpr int SSNTSNResetRequestParameter::kType; std::optional<SSNTSNResetRequestParameter> SSNTSNResetRequestParameter::Parse( webrtc::ArrayView<const uint8_t> data) { diff --git a/third_party/libwebrtc/net/dcsctp/packet/parameter/state_cookie_parameter.cc b/third_party/libwebrtc/net/dcsctp/packet/parameter/state_cookie_parameter.cc @@ -23,8 +23,6 @@ namespace dcsctp { // https://tools.ietf.org/html/rfc4960#section-3.3.3.1 -constexpr int StateCookieParameter::kType; - std::optional<StateCookieParameter> StateCookieParameter::Parse( webrtc::ArrayView<const uint8_t> data) { std::optional<BoundedByteReader<kHeaderSize>> reader = ParseTLV(data); diff --git a/third_party/libwebrtc/net/dcsctp/packet/parameter/supported_extensions_parameter.cc b/third_party/libwebrtc/net/dcsctp/packet/parameter/supported_extensions_parameter.cc @@ -36,7 +36,6 @@ namespace dcsctp { // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ // | CHUNK TYPE N | PAD | PAD | PAD | // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ -constexpr int SupportedExtensionsParameter::kType; std::optional<SupportedExtensionsParameter> SupportedExtensionsParameter::Parse( webrtc::ArrayView<const uint8_t> data) { diff --git a/third_party/libwebrtc/net/dcsctp/packet/parameter/zero_checksum_acceptable_chunk_parameter.cc b/third_party/libwebrtc/net/dcsctp/packet/parameter/zero_checksum_acceptable_chunk_parameter.cc @@ -30,7 +30,6 @@ namespace dcsctp { // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ // | Error Detection Method Identifier (EDMID) | // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ -constexpr int ZeroChecksumAcceptableChunkParameter::kType; std::optional<ZeroChecksumAcceptableChunkParameter> ZeroChecksumAcceptableChunkParameter::Parse( diff --git a/third_party/libwebrtc/net/dcsctp/rx/data_tracker.cc b/third_party/libwebrtc/net/dcsctp/rx/data_tracker.cc @@ -29,9 +29,6 @@ namespace dcsctp { -constexpr size_t DataTracker::kMaxDuplicateTsnReported; -constexpr size_t DataTracker::kMaxGapAckBlocksReported; - bool DataTracker::AdditionalTsnBlocks::Add(UnwrappedTSN tsn) { // Find any block to expand. It will look for any block that includes (also // when expanded) the provided `tsn`. It will return the block that is greater diff --git a/third_party/libwebrtc/net/dcsctp/socket/state_cookie.cc b/third_party/libwebrtc/net/dcsctp/socket/state_cookie.cc @@ -26,7 +26,6 @@ namespace dcsctp { // Magic values, which the state cookie is prefixed with. constexpr uint32_t kMagic1 = 1684230979; constexpr uint32_t kMagic2 = 1414541360; -constexpr size_t StateCookie::kCookieSize; std::vector<uint8_t> StateCookie::Serialize() { std::vector<uint8_t> cookie; diff --git a/third_party/libwebrtc/net/dcsctp/timer/timer.cc b/third_party/libwebrtc/net/dcsctp/timer/timer.cc @@ -54,8 +54,6 @@ TimeDelta GetBackoffDuration(const TimerOptions& options, } } // namespace -constexpr TimeDelta Timer::kMaxTimerDuration; - Timer::Timer(TimerID id, absl::string_view name, OnExpired on_expired, diff --git a/third_party/libwebrtc/rtc_base/experiments/rate_control_settings.cc b/third_party/libwebrtc/rtc_base/experiments/rate_control_settings.cc @@ -37,8 +37,6 @@ const char kUseBaseHeavyVp8Tl3RateAllocationFieldTrialName[] = } // namespace -constexpr char CongestionWindowConfig::kKey[]; - std::unique_ptr<StructParametersParser> CongestionWindowConfig::Parser() { return StructParametersParser::Create("QueueSize", &queue_size_ms, // "MinBitrate", &min_bitrate_bps, @@ -53,8 +51,6 @@ CongestionWindowConfig CongestionWindowConfig::Parse(absl::string_view config) { return res; } -constexpr char VideoRateControlConfig::kKey[]; - std::unique_ptr<StructParametersParser> VideoRateControlConfig::Parser() { // The empty comments ensures that each pair is on a separate line. return StructParametersParser::Create( diff --git a/third_party/libwebrtc/test/drifting_clock.cc b/third_party/libwebrtc/test/drifting_clock.cc @@ -20,7 +20,6 @@ namespace webrtc { namespace test { -constexpr float DriftingClock::kNoDrift; DriftingClock::DriftingClock(Clock* clock, float speed) : clock_(clock), drift_(speed - 1.0f), start_time_(clock_->CurrentTime()) { diff --git a/third_party/libwebrtc/video/call_stats2.cc b/third_party/libwebrtc/video/call_stats2.cc @@ -70,8 +70,6 @@ int64_t GetNewAvgRttMs(const std::list<CallStats::RttTime>& reports, } // namespace -constexpr TimeDelta CallStats::kUpdateInterval; - CallStats::CallStats(Clock* clock, TaskQueueBase* task_queue) : clock_(clock), max_rtt_ms_(-1), diff --git a/third_party/libwebrtc/video/encoder_bitrate_adjuster.cc b/third_party/libwebrtc/video/encoder_bitrate_adjuster.cc @@ -57,9 +57,6 @@ struct LayerRateInfo { } }; } // namespace -constexpr TimeDelta EncoderBitrateAdjuster::kWindowSize; -constexpr size_t EncoderBitrateAdjuster::kMinFramesSinceLayoutChange; -constexpr double EncoderBitrateAdjuster::kDefaultUtilizationFactor; EncoderBitrateAdjuster::EncoderBitrateAdjuster( const VideoCodec& codec_settings,