tor-browser

commit 81cb4a7dcca1a50801019b0c112bea54a708cac7
parent f45d773190c7e9098bbdfba08e21f9c07acf98cb
Author: rmalicdem <rmalicdem@mozilla.com>
Date:   Wed, 22 Oct 2025 00:13:37 +0000

Bug 1995619 - Fix dark silhouettes and unconstrained sizes of extensions r=android-reviewers,calu

Differential Revision: https://phabricator.services.mozilla.com/D269456

Diffstat:
M
mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/MainMenu.kt
 | 
2
+-
M
mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/MenuItem.kt
 | 
4
++--
M
mobile/android/fenix/app/src/main/java/org/mozilla/fenix/compose/list/ListItem.kt
 | 
1
+

3 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/MainMenu.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/MainMenu.kt
@@ -885,7 +885,7 @@ private fun WebExtensionMenuItems(
                     ?: painterResource(iconsR.drawable.mozac_ic_web_extension_default_icon),
                 iconTint = when (webExtensionMenuItem.icon) {
                     null -> FirefoxTheme.colors.iconPrimary
-                    else -> null
+                    else -> Color.Unspecified
                 },
                 enabled = webExtensionMenuItem.enabled,
                 badgeText = webExtensionMenuItem.badgeText,
diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/MenuItem.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/MenuItem.kt
@@ -218,7 +218,7 @@ internal fun MenuTextItem(
 internal fun WebExtensionMenuItem(
     label: String,
     iconPainter: Painter,
-    iconTint: Color? = null,
+    iconTint: Color = Color.Unspecified,
     enabled: Boolean?,
     badgeText: String?,
     index: Int = 0,
@@ -228,7 +228,7 @@ internal fun WebExtensionMenuItem(
     IconListItem(
         label = label,
         enabled = enabled == true,
-        beforeIconTint = iconTint ?: FirefoxTheme.colors.iconPrimary,
+        beforeIconTint = iconTint,
         beforeIconPainter = iconPainter,
         onClick = onClick,
         modifier = Modifier
diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/compose/list/ListItem.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/compose/list/ListItem.kt
@@ -352,6 +352,7 @@ private fun IconListItemBeforeIcon(
             painter = painter,
             contentDescription = description,
             tint = tint,
+            modifier = Modifier.size(ICON_SIZE),
         )
     }
 }