tor-browser

commit 71353cfaee7124e39e4bf3f545a16dc1efed5ebd
parent 768b8aa8ed0294c4c2db2016b294e2306967adf1
Author: André Bargull <andre.bargull@gmail.com>
Date:   Thu, 23 Oct 2025 10:14:52 +0000

Bug 1995575 - Part 3: Remove unused template from lowerForFPU method. r=spidermonkey-reviewers,jandem

Differential Revision: https://phabricator.services.mozilla.com/D269418

Diffstat:
M
js/src/jit/arm/Lowering-arm.cpp
 | 
10
+---------
M
js/src/jit/arm/Lowering-arm.h
 | 
3
+--
M
js/src/jit/arm64/Lowering-arm64.cpp
 | 
10
+---------
M
js/src/jit/arm64/Lowering-arm64.h
 | 
3
+--
M
js/src/jit/loong64/Lowering-loong64.cpp
 | 
12
+-----------
M
js/src/jit/loong64/Lowering-loong64.h
 | 
3
+--
M
js/src/jit/mips-shared/Lowering-mips-shared.cpp
 | 
10
+---------
M
js/src/jit/mips-shared/Lowering-mips-shared.h
 | 
3
+--
M
js/src/jit/riscv64/Lowering-riscv64.cpp
 | 
12
+-----------
M
js/src/jit/riscv64/Lowering-riscv64.h
 | 
3
+--
M
js/src/jit/x86-shared/Lowering-x86-shared.cpp
 | 
10
+---------
M
js/src/jit/x86-shared/Lowering-x86-shared.h
 | 
3
+--

12 files changed, 12 insertions(+), 70 deletions(-)
diff --git a/js/src/jit/arm/Lowering-arm.cpp b/js/src/jit/arm/Lowering-arm.cpp
@@ -226,8 +226,7 @@ void LIRGeneratorARM::lowerForFPU(LInstructionHelper<1, 1, 0>* ins,
   define(ins, mir);
 }
 
-template <size_t Temps>
-void LIRGeneratorARM::lowerForFPU(LInstructionHelper<1, 2, Temps>* ins,
+void LIRGeneratorARM::lowerForFPU(LInstructionHelper<1, 2, 0>* ins,
                                   MDefinition* mir, MDefinition* lhs,
                                   MDefinition* rhs) {
   ins->setOperand(0, useRegisterAtStart(lhs));
@@ -235,13 +234,6 @@ void LIRGeneratorARM::lowerForFPU(LInstructionHelper<1, 2, Temps>* ins,
   define(ins, mir);
 }
 
-template void LIRGeneratorARM::lowerForFPU(LInstructionHelper<1, 2, 0>* ins,
-                                           MDefinition* mir, MDefinition* lhs,
-                                           MDefinition* rhs);
-template void LIRGeneratorARM::lowerForFPU(LInstructionHelper<1, 2, 1>* ins,
-                                           MDefinition* mir, MDefinition* lhs,
-                                           MDefinition* rhs);
-
 void LIRGeneratorARM::lowerWasmBuiltinTruncateToInt32(
     MWasmBuiltinTruncateToInt32* ins) {
   MDefinition* opd = ins->input();
diff --git a/js/src/jit/arm/Lowering-arm.h b/js/src/jit/arm/Lowering-arm.h
@@ -62,8 +62,7 @@ class LIRGeneratorARM : public LIRGeneratorShared {
 
   void lowerForFPU(LInstructionHelper<1, 1, 0>* ins, MDefinition* mir,
                    MDefinition* input);
-  template <size_t Temps>
-  void lowerForFPU(LInstructionHelper<1, 2, Temps>* ins, MDefinition* mir,
+  void lowerForFPU(LInstructionHelper<1, 2, 0>* ins, MDefinition* mir,
                    MDefinition* lhs, MDefinition* rhs);
 
   void lowerBuiltinInt64ToFloatingPoint(MBuiltinInt64ToFloatingPoint* ins);
diff --git a/js/src/jit/arm64/Lowering-arm64.cpp b/js/src/jit/arm64/Lowering-arm64.cpp
@@ -123,8 +123,7 @@ void LIRGeneratorARM64::lowerForFPU(LInstructionHelper<1, 1, 0>* ins,
   define(ins, mir);
 }
 
-template <size_t Temps>
-void LIRGeneratorARM64::lowerForFPU(LInstructionHelper<1, 2, Temps>* ins,
+void LIRGeneratorARM64::lowerForFPU(LInstructionHelper<1, 2, 0>* ins,
                                     MDefinition* mir, MDefinition* lhs,
                                     MDefinition* rhs) {
   ins->setOperand(0, useRegisterAtStart(lhs));
@@ -132,13 +131,6 @@ void LIRGeneratorARM64::lowerForFPU(LInstructionHelper<1, 2, Temps>* ins,
   define(ins, mir);
 }
 
-template void LIRGeneratorARM64::lowerForFPU(LInstructionHelper<1, 2, 0>* ins,
-                                             MDefinition* mir, MDefinition* lhs,
-                                             MDefinition* rhs);
-template void LIRGeneratorARM64::lowerForFPU(LInstructionHelper<1, 2, 1>* ins,
-                                             MDefinition* mir, MDefinition* lhs,
-                                             MDefinition* rhs);
-
 void LIRGeneratorARM64::lowerForALUInt64(
     LInstructionHelper<INT64_PIECES, INT64_PIECES, 0>* ins, MDefinition* mir,
     MDefinition* input) {
diff --git a/js/src/jit/arm64/Lowering-arm64.h b/js/src/jit/arm64/Lowering-arm64.h
@@ -69,8 +69,7 @@ class LIRGeneratorARM64 : public LIRGeneratorShared {
   void lowerForFPU(LInstructionHelper<1, 1, 0>* ins, MDefinition* mir,
                    MDefinition* input);
 
-  template <size_t Temps>
-  void lowerForFPU(LInstructionHelper<1, 2, Temps>* ins, MDefinition* mir,
+  void lowerForFPU(LInstructionHelper<1, 2, 0>* ins, MDefinition* mir,
                    MDefinition* lhs, MDefinition* rhs);
 
   void lowerBuiltinInt64ToFloatingPoint(MBuiltinInt64ToFloatingPoint* ins);
diff --git a/js/src/jit/loong64/Lowering-loong64.cpp b/js/src/jit/loong64/Lowering-loong64.cpp
@@ -120,8 +120,7 @@ void LIRGeneratorLOONG64::lowerForFPU(LInstructionHelper<1, 1, 0>* ins,
   define(ins, mir);
 }
 
-template <size_t Temps>
-void LIRGeneratorLOONG64::lowerForFPU(LInstructionHelper<1, 2, Temps>* ins,
+void LIRGeneratorLOONG64::lowerForFPU(LInstructionHelper<1, 2, 0>* ins,
                                       MDefinition* mir, MDefinition* lhs,
                                       MDefinition* rhs) {
   ins->setOperand(0, useRegisterAtStart(lhs));
@@ -129,15 +128,6 @@ void LIRGeneratorLOONG64::lowerForFPU(LInstructionHelper<1, 2, Temps>* ins,
   define(ins, mir);
 }
 
-template void LIRGeneratorLOONG64::lowerForFPU(LInstructionHelper<1, 2, 0>* ins,
-                                               MDefinition* mir,
-                                               MDefinition* lhs,
-                                               MDefinition* rhs);
-template void LIRGeneratorLOONG64::lowerForFPU(LInstructionHelper<1, 2, 1>* ins,
-                                               MDefinition* mir,
-                                               MDefinition* lhs,
-                                               MDefinition* rhs);
-
 LBoxAllocation LIRGeneratorLOONG64::useBoxFixed(MDefinition* mir, Register reg1,
                                                 Register reg2,
                                                 bool useAtStart) {
diff --git a/js/src/jit/loong64/Lowering-loong64.h b/js/src/jit/loong64/Lowering-loong64.h
@@ -41,8 +41,7 @@ class LIRGeneratorLOONG64 : public LIRGeneratorShared {
 
   void lowerForFPU(LInstructionHelper<1, 1, 0>* ins, MDefinition* mir,
                    MDefinition* input);
-  template <size_t Temps>
-  void lowerForFPU(LInstructionHelper<1, 2, Temps>* ins, MDefinition* mir,
+  void lowerForFPU(LInstructionHelper<1, 2, 0>* ins, MDefinition* mir,
                    MDefinition* lhs, MDefinition* rhs);
 
   // Returns a box allocation. reg2 is ignored on 64-bit platforms.
diff --git a/js/src/jit/mips-shared/Lowering-mips-shared.cpp b/js/src/jit/mips-shared/Lowering-mips-shared.cpp
@@ -119,8 +119,7 @@ void LIRGeneratorMIPSShared::lowerForFPU(LInstructionHelper<1, 1, 0>* ins,
   define(ins, mir);
 }
 
-template <size_t Temps>
-void LIRGeneratorMIPSShared::lowerForFPU(LInstructionHelper<1, 2, Temps>* ins,
+void LIRGeneratorMIPSShared::lowerForFPU(LInstructionHelper<1, 2, 0>* ins,
                                          MDefinition* mir, MDefinition* lhs,
                                          MDefinition* rhs) {
   ins->setOperand(0, useRegisterAtStart(lhs));
@@ -128,13 +127,6 @@ void LIRGeneratorMIPSShared::lowerForFPU(LInstructionHelper<1, 2, Temps>* ins,
   define(ins, mir);
 }
 
-template void LIRGeneratorMIPSShared::lowerForFPU(
-    LInstructionHelper<1, 2, 0>* ins, MDefinition* mir, MDefinition* lhs,
-    MDefinition* rhs);
-template void LIRGeneratorMIPSShared::lowerForFPU(
-    LInstructionHelper<1, 2, 1>* ins, MDefinition* mir, MDefinition* lhs,
-    MDefinition* rhs);
-
 void LIRGeneratorMIPSShared::lowerWasmBuiltinTruncateToInt32(
     MWasmBuiltinTruncateToInt32* ins) {
   MDefinition* opd = ins->input();
diff --git a/js/src/jit/mips-shared/Lowering-mips-shared.h b/js/src/jit/mips-shared/Lowering-mips-shared.h
@@ -50,8 +50,7 @@ class LIRGeneratorMIPSShared : public LIRGeneratorShared {
 
   void lowerForFPU(LInstructionHelper<1, 1, 0>* ins, MDefinition* mir,
                    MDefinition* input);
-  template <size_t Temps>
-  void lowerForFPU(LInstructionHelper<1, 2, Temps>* ins, MDefinition* mir,
+  void lowerForFPU(LInstructionHelper<1, 2, 0>* ins, MDefinition* mir,
                    MDefinition* lhs, MDefinition* rhs);
 
   void lowerWasmBuiltinTruncateToInt32(MWasmBuiltinTruncateToInt32* ins);
diff --git a/js/src/jit/riscv64/Lowering-riscv64.cpp b/js/src/jit/riscv64/Lowering-riscv64.cpp
@@ -121,8 +121,7 @@ void LIRGeneratorRiscv64::lowerForFPU(LInstructionHelper<1, 1, 0>* ins,
   define(ins, mir);
 }
 
-template <size_t Temps>
-void LIRGeneratorRiscv64::lowerForFPU(LInstructionHelper<1, 2, Temps>* ins,
+void LIRGeneratorRiscv64::lowerForFPU(LInstructionHelper<1, 2, 0>* ins,
                                       MDefinition* mir, MDefinition* lhs,
                                       MDefinition* rhs) {
   ins->setOperand(0, useRegisterAtStart(lhs));
@@ -130,15 +129,6 @@ void LIRGeneratorRiscv64::lowerForFPU(LInstructionHelper<1, 2, Temps>* ins,
   define(ins, mir);
 }
 
-template void LIRGeneratorRiscv64::lowerForFPU(LInstructionHelper<1, 2, 0>* ins,
-                                               MDefinition* mir,
-                                               MDefinition* lhs,
-                                               MDefinition* rhs);
-template void LIRGeneratorRiscv64::lowerForFPU(LInstructionHelper<1, 2, 1>* ins,
-                                               MDefinition* mir,
-                                               MDefinition* lhs,
-                                               MDefinition* rhs);
-
 LBoxAllocation LIRGeneratorRiscv64::useBoxFixed(MDefinition* mir, Register reg1,
                                                 Register reg2,
                                                 bool useAtStart) {
diff --git a/js/src/jit/riscv64/Lowering-riscv64.h b/js/src/jit/riscv64/Lowering-riscv64.h
@@ -41,8 +41,7 @@ class LIRGeneratorRiscv64 : public LIRGeneratorShared {
 
   void lowerForFPU(LInstructionHelper<1, 1, 0>* ins, MDefinition* mir,
                    MDefinition* input);
-  template <size_t Temps>
-  void lowerForFPU(LInstructionHelper<1, 2, Temps>* ins, MDefinition* mir,
+  void lowerForFPU(LInstructionHelper<1, 2, 0>* ins, MDefinition* mir,
                    MDefinition* lhs, MDefinition* rhs);
 
   // Returns a box allocation. reg2 is ignored on 64-bit platforms.
diff --git a/js/src/jit/x86-shared/Lowering-x86-shared.cpp b/js/src/jit/x86-shared/Lowering-x86-shared.cpp
@@ -151,8 +151,7 @@ void LIRGeneratorX86Shared::lowerForALU(LInstructionHelper<1, 2, 0>* ins,
   defineReuseInput(ins, mir, 0);
 }
 
-template <size_t Temps>
-void LIRGeneratorX86Shared::lowerForFPU(LInstructionHelper<1, 2, Temps>* ins,
+void LIRGeneratorX86Shared::lowerForFPU(LInstructionHelper<1, 2, 0>* ins,
                                         MDefinition* mir, MDefinition* lhs,
                                         MDefinition* rhs) {
   // Without AVX, we'll need to use the x86 encodings where one of the
@@ -169,13 +168,6 @@ void LIRGeneratorX86Shared::lowerForFPU(LInstructionHelper<1, 2, Temps>* ins,
   }
 }
 
-template void LIRGeneratorX86Shared::lowerForFPU(
-    LInstructionHelper<1, 2, 0>* ins, MDefinition* mir, MDefinition* lhs,
-    MDefinition* rhs);
-template void LIRGeneratorX86Shared::lowerForFPU(
-    LInstructionHelper<1, 2, 1>* ins, MDefinition* mir, MDefinition* lhs,
-    MDefinition* rhs);
-
 void LIRGeneratorX86Shared::lowerNegI(MInstruction* ins, MDefinition* input) {
   defineReuseInput(new (alloc()) LNegI(useRegisterAtStart(input)), ins, 0);
 }
diff --git a/js/src/jit/x86-shared/Lowering-x86-shared.h b/js/src/jit/x86-shared/Lowering-x86-shared.h
@@ -36,8 +36,7 @@ class LIRGeneratorX86Shared : public LIRGeneratorShared {
   void lowerForShiftInt64(LInstr* ins, MDefinition* mir, MDefinition* lhs,
                           MDefinition* rhs);
 
-  template <size_t Temps>
-  void lowerForFPU(LInstructionHelper<1, 2, Temps>* ins, MDefinition* mir,
+  void lowerForFPU(LInstructionHelper<1, 2, 0>* ins, MDefinition* mir,
                    MDefinition* lhs, MDefinition* rhs);
   void lowerNegI(MInstruction* ins, MDefinition* input);
   void lowerNegI64(MInstruction* ins, MDefinition* input);