commit 5536a33905a95b7c5df65608341a925f9145b6ad
parent c0fb607d463776f817d3ee38a946cd52bb035864
Author: Ryan VanderMeulen <rvandermeulen@mozilla.com>
Date: Fri, 10 Oct 2025 11:32:09 +0000
Bug 1993596 - Update lint baselines. r=android-reviewers,mcarare
Differential Revision: https://phabricator.services.mozilla.com/D268221
Diffstat:
2 files changed, 330 insertions(+), 257 deletions(-)
diff --git a/mobile/android/fenix/app/lint-baseline.xml b/mobile/android/fenix/app/lint-baseline.xml
@@ -30,7 +30,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt"
- line="113"
+ line="114"
column="9"/>
</issue>
@@ -41,7 +41,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt"
- line="347"
+ line="348"
column="9"/>
</issue>
@@ -52,7 +52,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt"
- line="356"
+ line="357"
column="9"/>
</issue>
@@ -63,7 +63,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt"
- line="369"
+ line="370"
column="9"/>
</issue>
@@ -74,7 +74,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt"
- line="377"
+ line="378"
column="9"/>
</issue>
@@ -85,7 +85,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt"
- line="394"
+ line="395"
column="9"/>
</issue>
@@ -96,7 +96,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt"
- line="406"
+ line="407"
column="9"/>
</issue>
@@ -107,7 +107,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt"
- line="423"
+ line="424"
column="9"/>
</issue>
@@ -118,7 +118,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt"
- line="434"
+ line="435"
column="9"/>
</issue>
@@ -129,7 +129,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt"
- line="451"
+ line="452"
column="9"/>
</issue>
@@ -140,7 +140,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt"
- line="464"
+ line="465"
column="9"/>
</issue>
@@ -151,7 +151,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt"
- line="528"
+ line="529"
column="9"/>
</issue>
@@ -162,7 +162,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt"
- line="534"
+ line="535"
column="9"/>
</issue>
@@ -345,61 +345,6 @@
<issue
id="NoStaticMocking"
message="Usage of MockK's 'mockkStatic' for static mocking is discouraged. Refactor to use dependency injection."
- errorLine1=" mockkStatic("org.mozilla.fenix.search.SearchFragmentStoreKt") {"
- errorLine2=" ^">
- <location
- file="src/test/java/org/mozilla/fenix/search/SearchFragmentStoreTest.kt"
- line="87"
- column="9"/>
- </issue>
-
- <issue
- id="NoStaticMocking"
- message="Usage of MockK's 'mockkStatic' for static mocking is discouraged. Refactor to use dependency injection."
- errorLine1=" mockkStatic("org.mozilla.fenix.search.SearchFragmentStoreKt") {"
- errorLine2=" ^">
- <location
- file="src/test/java/org/mozilla/fenix/search/SearchFragmentStoreTest.kt"
- line="616"
- column="9"/>
- </issue>
-
- <issue
- id="NoStaticMocking"
- message="Usage of MockK's 'mockkStatic' for static mocking is discouraged. Refactor to use dependency injection."
- errorLine1=" mockkStatic("org.mozilla.fenix.search.toolbar.SearchSelectorToolbarActionKt") {"
- errorLine2=" ^">
- <location
- file="src/test/java/org/mozilla/fenix/search/toolbar/SearchSelectorToolbarActionTest.kt"
- line="106"
- column="9"/>
- </issue>
-
- <issue
- id="NoStaticMocking"
- message="Usage of MockK's 'mockkStatic' for static mocking is discouraged. Refactor to use dependency injection."
- errorLine1=" mockkStatic("org.mozilla.fenix.search.toolbar.SearchSelectorToolbarActionKt") {"
- errorLine2=" ^">
- <location
- file="src/test/java/org/mozilla/fenix/search/toolbar/SearchSelectorToolbarActionTest.kt"
- line="138"
- column="9"/>
- </issue>
-
- <issue
- id="NoStaticMocking"
- message="Usage of MockK's 'mockkStatic' for static mocking is discouraged. Refactor to use dependency injection."
- errorLine1=" mockkStatic("org.mozilla.fenix.search.toolbar.SearchSelectorToolbarActionKt") {"
- errorLine2=" ^">
- <location
- file="src/test/java/org/mozilla/fenix/search/toolbar/SearchSelectorToolbarActionTest.kt"
- line="171"
- column="9"/>
- </issue>
-
- <issue
- id="NoStaticMocking"
- message="Usage of MockK's 'mockkStatic' for static mocking is discouraged. Refactor to use dependency injection."
errorLine1=" mockkStatic("mozilla.components.support.ktx.android.util.DisplayMetricsKt")"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
@@ -579,28 +524,6 @@
errorLine1=" mockkStatic("org.mozilla.fenix.ext.ContextKt") {"
errorLine2=" ^">
<location
- file="src/test/java/org/mozilla/fenix/trackingprotection/TrackingProtectionBlockingFragmentTest.kt"
- line="29"
- column="9"/>
- </issue>
-
- <issue
- id="NoStaticMocking"
- message="Usage of MockK's 'mockkStatic' for static mocking is discouraged. Refactor to use dependency injection."
- errorLine1=" mockkStatic("org.mozilla.fenix.ext.ContextKt") {"
- errorLine2=" ^">
- <location
- file="src/test/java/org/mozilla/fenix/trackingprotection/TrackingProtectionBlockingFragmentTest.kt"
- line="47"
- column="9"/>
- </issue>
-
- <issue
- id="NoStaticMocking"
- message="Usage of MockK's 'mockkStatic' for static mocking is discouraged. Refactor to use dependency injection."
- errorLine1=" mockkStatic("org.mozilla.fenix.ext.ContextKt") {"
- errorLine2=" ^">
- <location
file="src/test/java/org/mozilla/fenix/trackingprotection/TrackingProtectionPanelViewTest.kt"
line="62"
column="9"/>
@@ -653,28 +576,6 @@
<issue
id="NoStaticMocking"
message="Usage of MockK's 'mockkStatic' for static mocking is discouraged. Refactor to use dependency injection."
- errorLine1=" mockkStatic("mozilla.components.support.ktx.android.content.ContextKt")"
- errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
- <location
- file="src/androidTest/java/org/mozilla/fenix/ui/UnsubmittedCrashDialogTest.kt"
- line="46"
- column="9"/>
- </issue>
-
- <issue
- id="NoStaticMocking"
- message="Usage of MockK's 'unmockkStatic' for static mocking is discouraged. Refactor to use dependency injection."
- errorLine1=" unmockkStatic("org.mozilla.fenix.ext.ContextKt")"
- errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
- <location
- file="src/androidTest/java/org/mozilla/fenix/ui/UnsubmittedCrashDialogTest.kt"
- line="56"
- column="9"/>
- </issue>
-
- <issue
- id="NoStaticMocking"
- message="Usage of MockK's 'mockkStatic' for static mocking is discouraged. Refactor to use dependency injection."
errorLine1=" mockkStatic("mozilla.components.support.ktx.android.util.DisplayMetricsKt")"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
@@ -706,28 +607,6 @@
</issue>
<issue
- id="NoStaticMocking"
- message="Usage of MockK's 'mockkStatic' for static mocking is discouraged. Refactor to use dependency injection."
- errorLine1=" mockkStatic(Base64::class)"
- errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~">
- <location
- file="src/test/java/org/mozilla/fenix/push/WebPushEngineIntegrationTest.kt"
- line="59"
- column="9"/>
- </issue>
-
- <issue
- id="NoStaticMocking"
- message="Usage of MockK's 'unmockkStatic' for static mocking is discouraged. Refactor to use dependency injection."
- errorLine1=" unmockkStatic(Base64::class)"
- errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
- <location
- file="src/test/java/org/mozilla/fenix/push/WebPushEngineIntegrationTest.kt"
- line="72"
- column="9"/>
- </issue>
-
- <issue
id="ScrollViewSize"
message="This LinearLayout should use `android:layout_height="wrap_content"`"
errorLine1=" android:layout_height="match_parent""
@@ -756,7 +635,7 @@
errorLine2=" ^">
<location
file="src/main/AndroidManifest.xml"
- line="495"
+ line="510"
column="17"/>
</issue>
@@ -767,7 +646,7 @@
errorLine2=" ^">
<location
file="src/main/AndroidManifest.xml"
- line="497"
+ line="512"
column="17"/>
</issue>
@@ -778,7 +657,7 @@
errorLine2=" ^">
<location
file="src/main/AndroidManifest.xml"
- line="499"
+ line="514"
column="17"/>
</issue>
@@ -789,7 +668,7 @@
errorLine2=" ^">
<location
file="src/main/AndroidManifest.xml"
- line="501"
+ line="516"
column="17"/>
</issue>
@@ -800,7 +679,7 @@
errorLine2=" ^">
<location
file="src/main/AndroidManifest.xml"
- line="503"
+ line="518"
column="17"/>
</issue>
@@ -811,7 +690,7 @@
errorLine2=" ^">
<location
file="src/main/AndroidManifest.xml"
- line="505"
+ line="520"
column="17"/>
</issue>
@@ -822,7 +701,7 @@
errorLine2=" ^">
<location
file="src/main/AndroidManifest.xml"
- line="507"
+ line="522"
column="17"/>
</issue>
@@ -833,7 +712,7 @@
errorLine2=" ^">
<location
file="src/main/AndroidManifest.xml"
- line="509"
+ line="524"
column="17"/>
</issue>
@@ -844,7 +723,7 @@
errorLine2=" ^">
<location
file="src/main/AndroidManifest.xml"
- line="511"
+ line="526"
column="17"/>
</issue>
@@ -855,7 +734,7 @@
errorLine2=" ^">
<location
file="src/main/AndroidManifest.xml"
- line="513"
+ line="528"
column="17"/>
</issue>
@@ -866,7 +745,7 @@
errorLine2=" ^">
<location
file="src/main/AndroidManifest.xml"
- line="515"
+ line="530"
column="17"/>
</issue>
@@ -877,7 +756,7 @@
errorLine2=" ^">
<location
file="src/main/AndroidManifest.xml"
- line="517"
+ line="532"
column="17"/>
</issue>
@@ -888,7 +767,7 @@
errorLine2=" ^">
<location
file="src/main/AndroidManifest.xml"
- line="519"
+ line="534"
column="17"/>
</issue>
@@ -899,7 +778,7 @@
errorLine2=" ^">
<location
file="src/main/AndroidManifest.xml"
- line="521"
+ line="536"
column="17"/>
</issue>
@@ -910,7 +789,7 @@
errorLine2=" ^">
<location
file="src/main/AndroidManifest.xml"
- line="523"
+ line="538"
column="17"/>
</issue>
@@ -921,7 +800,7 @@
errorLine2=" ^">
<location
file="src/main/AndroidManifest.xml"
- line="525"
+ line="540"
column="17"/>
</issue>
@@ -932,7 +811,7 @@
errorLine2=" ^">
<location
file="src/main/AndroidManifest.xml"
- line="527"
+ line="542"
column="17"/>
</issue>
@@ -943,7 +822,7 @@
errorLine2=" ^">
<location
file="src/main/AndroidManifest.xml"
- line="529"
+ line="544"
column="17"/>
</issue>
@@ -954,7 +833,7 @@
errorLine2=" ^">
<location
file="src/main/AndroidManifest.xml"
- line="531"
+ line="546"
column="17"/>
</issue>
@@ -965,13 +844,57 @@
errorLine2=" ^">
<location
file="src/main/AndroidManifest.xml"
- line="533"
+ line="548"
column="17"/>
</issue>
<issue
id="VectorRaster"
message="Limit vector icons sizes to 200×200 to keep icon drawing fast; see https://developer.android.com/studio/write/vector-asset-studio#when for more"
+ errorLine1=" android:width="432dp""
+ errorLine2=" ~~~~~">
+ <location
+ file="src/main/res/drawable/ic_cool.xml"
+ line="6"
+ column="20"/>
+ </issue>
+
+ <issue
+ id="VectorRaster"
+ message="Limit vector icons sizes to 200×200 to keep icon drawing fast; see https://developer.android.com/studio/write/vector-asset-studio#when for more"
+ errorLine1=" android:width="434dp""
+ errorLine2=" ~~~~~">
+ <location
+ file="src/main/res/drawable/ic_cuddling.xml"
+ line="6"
+ column="20"/>
+ </issue>
+
+ <issue
+ id="VectorRaster"
+ message="Limit vector icons sizes to 200×200 to keep icon drawing fast; see https://developer.android.com/studio/write/vector-asset-studio#when for more"
+ errorLine1=" android:width="811dp""
+ errorLine2=" ~~~~~">
+ <location
+ file="src/debug/res/drawable/ic_firefox.xml"
+ line="6"
+ column="20"/>
+ </issue>
+
+ <issue
+ id="VectorRaster"
+ message="Limit vector icons sizes to 200×200 to keep icon drawing fast; see https://developer.android.com/studio/write/vector-asset-studio#when for more"
+ errorLine1=" android:width="438dp""
+ errorLine2=" ~~~~~">
+ <location
+ file="src/main/res/drawable/ic_flaming.xml"
+ line="7"
+ column="20"/>
+ </issue>
+
+ <issue
+ id="VectorRaster"
+ message="Limit vector icons sizes to 200×200 to keep icon drawing fast; see https://developer.android.com/studio/write/vector-asset-studio#when for more"
errorLine1=" android:width="259dp""
errorLine2=" ~~~~~">
<location
@@ -983,7 +906,29 @@
<issue
id="VectorRaster"
message="Limit vector icons sizes to 200×200 to keep icon drawing fast; see https://developer.android.com/studio/write/vector-asset-studio#when for more"
- errorLine1=" android:width="811dp""
+ errorLine1=" android:width="432dp""
+ errorLine2=" ~~~~~">
+ <location
+ file="src/main/res/drawable/ic_launcher_background_cool.xml"
+ line="7"
+ column="20"/>
+ </issue>
+
+ <issue
+ id="VectorRaster"
+ message="Limit vector icons sizes to 200×200 to keep icon drawing fast; see https://developer.android.com/studio/write/vector-asset-studio#when for more"
+ errorLine1=" android:width="432dp""
+ errorLine2=" ~~~~~">
+ <location
+ file="src/main/res/drawable/ic_launcher_background_cuddling.xml"
+ line="7"
+ column="20"/>
+ </issue>
+
+ <issue
+ id="VectorRaster"
+ message="Limit vector icons sizes to 200×200 to keep icon drawing fast; see https://developer.android.com/studio/write/vector-asset-studio#when for more"
+ errorLine1=" android:width="432dp""
errorLine2=" ~~~~~">
<location
file="src/debug/res/drawable/ic_launcher_foreground.xml"
@@ -994,6 +939,116 @@
<issue
id="VectorRaster"
message="Limit vector icons sizes to 200×200 to keep icon drawing fast; see https://developer.android.com/studio/write/vector-asset-studio#when for more"
+ errorLine1=" android:width="432dp""
+ errorLine2=" ~~~~~">
+ <location
+ file="src/main/res/drawable/ic_launcher_foreground_cool.xml"
+ line="6"
+ column="20"/>
+ </issue>
+
+ <issue
+ id="VectorRaster"
+ message="Limit vector icons sizes to 200×200 to keep icon drawing fast; see https://developer.android.com/studio/write/vector-asset-studio#when for more"
+ errorLine1=" android:width="432dp""
+ errorLine2=" ~~~~~">
+ <location
+ file="src/main/res/drawable/ic_launcher_foreground_cuddling.xml"
+ line="6"
+ column="20"/>
+ </issue>
+
+ <issue
+ id="VectorRaster"
+ message="Limit vector icons sizes to 200×200 to keep icon drawing fast; see https://developer.android.com/studio/write/vector-asset-studio#when for more"
+ errorLine1=" android:width="432dp""
+ errorLine2=" ~~~~~">
+ <location
+ file="src/main/res/drawable/ic_launcher_foreground_flaming.xml"
+ line="7"
+ column="20"/>
+ </issue>
+
+ <issue
+ id="VectorRaster"
+ message="Limit vector icons sizes to 200×200 to keep icon drawing fast; see https://developer.android.com/studio/write/vector-asset-studio#when for more"
+ errorLine1=" android:width="432dp""
+ errorLine2=" ~~~~~">
+ <location
+ file="src/main/res/drawable/ic_launcher_foreground_minimal.xml"
+ line="6"
+ column="20"/>
+ </issue>
+
+ <issue
+ id="VectorRaster"
+ message="Limit vector icons sizes to 200×200 to keep icon drawing fast; see https://developer.android.com/studio/write/vector-asset-studio#when for more"
+ errorLine1=" android:width="432dp""
+ errorLine2=" ~~~~~">
+ <location
+ file="src/main/res/drawable/ic_launcher_foreground_momo.xml"
+ line="6"
+ column="20"/>
+ </issue>
+
+ <issue
+ id="VectorRaster"
+ message="Limit vector icons sizes to 200×200 to keep icon drawing fast; see https://developer.android.com/studio/write/vector-asset-studio#when for more"
+ errorLine1=" android:width="432dp""
+ errorLine2=" ~~~~~">
+ <location
+ file="src/main/res/drawable/ic_launcher_foreground_pixelated.xml"
+ line="6"
+ column="20"/>
+ </issue>
+
+ <issue
+ id="VectorRaster"
+ message="Limit vector icons sizes to 200×200 to keep icon drawing fast; see https://developer.android.com/studio/write/vector-asset-studio#when for more"
+ errorLine1=" android:width="432dp""
+ errorLine2=" ~~~~~">
+ <location
+ file="src/main/res/drawable/ic_launcher_foreground_pride.xml"
+ line="6"
+ column="20"/>
+ </issue>
+
+ <issue
+ id="VectorRaster"
+ message="Limit vector icons sizes to 200×200 to keep icon drawing fast; see https://developer.android.com/studio/write/vector-asset-studio#when for more"
+ errorLine1=" android:width="432dp""
+ errorLine2=" ~~~~~">
+ <location
+ file="src/main/res/drawable/ic_launcher_foreground_retro_2004.xml"
+ line="7"
+ column="20"/>
+ </issue>
+
+ <issue
+ id="VectorRaster"
+ message="Limit vector icons sizes to 200×200 to keep icon drawing fast; see https://developer.android.com/studio/write/vector-asset-studio#when for more"
+ errorLine1=" android:width="432dp""
+ errorLine2=" ~~~~~">
+ <location
+ file="src/main/res/drawable/ic_minimal.xml"
+ line="6"
+ column="20"/>
+ </issue>
+
+ <issue
+ id="VectorRaster"
+ message="Limit vector icons sizes to 200×200 to keep icon drawing fast; see https://developer.android.com/studio/write/vector-asset-studio#when for more"
+ errorLine1=" android:width="432dp""
+ errorLine2=" ~~~~~">
+ <location
+ file="src/main/res/drawable/ic_momo.xml"
+ line="6"
+ column="20"/>
+ </issue>
+
+ <issue
+ id="VectorRaster"
+ message="Limit vector icons sizes to 200×200 to keep icon drawing fast; see https://developer.android.com/studio/write/vector-asset-studio#when for more"
errorLine1=" android:width="973dp""
errorLine2=" ~~~~~">
<location
@@ -1038,6 +1093,17 @@
<issue
id="VectorRaster"
message="Limit vector icons sizes to 200×200 to keep icon drawing fast; see https://developer.android.com/studio/write/vector-asset-studio#when for more"
+ errorLine1=" android:width="244dp""
+ errorLine2=" ~~~~~">
+ <location
+ file="src/main/res/drawable/ic_onboarding_marketing_redesign.xml"
+ line="5"
+ column="20"/>
+ </issue>
+
+ <issue
+ id="VectorRaster"
+ message="Limit vector icons sizes to 200×200 to keep icon drawing fast; see https://developer.android.com/studio/write/vector-asset-studio#when for more"
errorLine1=" android:width="312dp""
errorLine2=" ~~~~~">
<location
@@ -1082,6 +1148,39 @@
<issue
id="VectorRaster"
message="Limit vector icons sizes to 200×200 to keep icon drawing fast; see https://developer.android.com/studio/write/vector-asset-studio#when for more"
+ errorLine1=" android:width="432dp""
+ errorLine2=" ~~~~~">
+ <location
+ file="src/main/res/drawable/ic_pixelated.xml"
+ line="6"
+ column="20"/>
+ </issue>
+
+ <issue
+ id="VectorRaster"
+ message="Limit vector icons sizes to 200×200 to keep icon drawing fast; see https://developer.android.com/studio/write/vector-asset-studio#when for more"
+ errorLine1=" android:width="432dp""
+ errorLine2=" ~~~~~">
+ <location
+ file="src/main/res/drawable/ic_pride.xml"
+ line="6"
+ column="20"/>
+ </issue>
+
+ <issue
+ id="VectorRaster"
+ message="Limit vector icons sizes to 200×200 to keep icon drawing fast; see https://developer.android.com/studio/write/vector-asset-studio#when for more"
+ errorLine1=" android:width="432dp""
+ errorLine2=" ~~~~~">
+ <location
+ file="src/main/res/drawable/ic_retro_2004.xml"
+ line="7"
+ column="20"/>
+ </issue>
+
+ <issue
+ id="VectorRaster"
+ message="Limit vector icons sizes to 200×200 to keep icon drawing fast; see https://developer.android.com/studio/write/vector-asset-studio#when for more"
errorLine1=" android:width="316dp""
errorLine2=" ~~~~~">
<location
@@ -1141,7 +1240,7 @@
errorLine2=" ~~~~~~~~~~~~~">
<location
file="src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt"
- line="589"
+ line="593"
column="9"/>
</issue>
@@ -1240,7 +1339,7 @@
errorLine2=" ~~~~~~~~">
<location
file="src/main/AndroidManifest.xml"
- line="730"
+ line="751"
column="10"/>
</issue>
@@ -1900,7 +1999,7 @@
errorLine2=" ~~~~~~">
<location
file="src/main/java/org/mozilla/fenix/experiments/view/ResearchSurfaceSurvey.kt"
- line="75"
+ line="76"
column="14"/>
</issue>
@@ -1911,7 +2010,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values-vi/strings.xml"
- line="3652"
+ line="3742"
column="62"/>
</issue>
@@ -1961,6 +2060,13 @@
</issue>
<issue
+ id="IconLocation"
+ message="Found bitmap drawable `res/drawable/onboarding_redesign_background_landscape.webp` in densityless folder">
+ <location
+ file="src/main/res/drawable/onboarding_redesign_background_landscape.webp"/>
+ </issue>
+
+ <issue
id="IconDensities"
message="Missing the following drawables in `drawable-mdpi`: fenix_search_widget.webp (found in drawable-hdpi)">
<location
@@ -1988,7 +2094,7 @@
errorLine2=" ^">
<location
file="src/main/java/org/mozilla/fenix/search/SearchDialogFragment.kt"
- line="397"
+ line="401"
column="17"/>
</issue>
@@ -1999,7 +2105,7 @@
errorLine2=" ^">
<location
file="src/main/java/org/mozilla/fenix/search/SearchDialogFragment.kt"
- line="397"
+ line="401"
column="58"/>
</issue>
@@ -2010,7 +2116,7 @@
errorLine2=" ^">
<location
file="src/main/java/org/mozilla/fenix/search/SearchDialogFragment.kt"
- line="407"
+ line="411"
column="17"/>
</issue>
@@ -2021,7 +2127,7 @@
errorLine2=" ^">
<location
file="src/main/java/org/mozilla/fenix/search/SearchDialogFragment.kt"
- line="407"
+ line="411"
column="58"/>
</issue>
@@ -2032,7 +2138,7 @@
errorLine2=" ^">
<location
file="src/main/java/org/mozilla/fenix/search/SearchDialogFragment.kt"
- line="413"
+ line="417"
column="17"/>
</issue>
@@ -2043,7 +2149,7 @@
errorLine2=" ^">
<location
file="src/main/java/org/mozilla/fenix/search/SearchDialogFragment.kt"
- line="413"
+ line="417"
column="58"/>
</issue>
@@ -2087,7 +2193,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt"
- line="107"
+ line="108"
column="9"/>
</issue>
@@ -2098,7 +2204,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt"
- line="112"
+ line="113"
column="9"/>
</issue>
@@ -2109,7 +2215,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt"
- line="344"
+ line="345"
column="9"/>
</issue>
@@ -2120,7 +2226,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt"
- line="355"
+ line="356"
column="9"/>
</issue>
@@ -2131,7 +2237,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt"
- line="366"
+ line="367"
column="9"/>
</issue>
@@ -2142,7 +2248,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt"
- line="376"
+ line="377"
column="9"/>
</issue>
@@ -2153,7 +2259,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt"
- line="391"
+ line="392"
column="9"/>
</issue>
@@ -2164,7 +2270,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt"
- line="405"
+ line="406"
column="9"/>
</issue>
@@ -2175,7 +2281,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt"
- line="420"
+ line="421"
column="9"/>
</issue>
@@ -2186,7 +2292,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt"
- line="433"
+ line="434"
column="9"/>
</issue>
@@ -2197,7 +2303,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt"
- line="448"
+ line="449"
column="9"/>
</issue>
@@ -2208,7 +2314,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt"
- line="463"
+ line="464"
column="9"/>
</issue>
@@ -2219,7 +2325,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt"
- line="525"
+ line="526"
column="9"/>
</issue>
@@ -2230,7 +2336,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt"
- line="533"
+ line="534"
column="9"/>
</issue>
@@ -2259,28 +2365,6 @@
<issue
id="NoObjectMocking"
message="Usage of MockK's 'mockkObject' for object/singleton mocking is discouraged. Consider providing dependencies explicitly."
- errorLine1=" mockkObject(Snackbar.Companion)"
- errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
- <location
- file="src/test/java/org/mozilla/fenix/snackbar/FenixSnackbarDelegateTest.kt"
- line="46"
- column="9"/>
- </issue>
-
- <issue
- id="NoObjectMocking"
- message="Usage of MockK's 'unmockkObject' for object/singleton mocking is discouraged. Consider providing dependencies explicitly."
- errorLine1=" unmockkObject(Snackbar.Companion)"
- errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
- <location
- file="src/test/java/org/mozilla/fenix/snackbar/FenixSnackbarDelegateTest.kt"
- line="58"
- column="9"/>
- </issue>
-
- <issue
- id="NoObjectMocking"
- message="Usage of MockK's 'mockkObject' for object/singleton mocking is discouraged. Consider providing dependencies explicitly."
errorLine1=" mockkObject(ContentRecommendationsFeatureHelper) {"
errorLine2=" ^">
<location
diff --git a/mobile/android/focus-android/app/lint-baseline.xml b/mobile/android/focus-android/app/lint-baseline.xml
@@ -734,7 +734,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/dimens.xml"
- line="15"
+ line="16"
column="12"/>
</issue>
@@ -745,7 +745,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/dimens.xml"
- line="18"
+ line="19"
column="12"/>
</issue>
@@ -756,7 +756,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/dimens.xml"
- line="19"
+ line="20"
column="12"/>
</issue>
@@ -767,7 +767,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/dimens.xml"
- line="20"
+ line="21"
column="12"/>
</issue>
@@ -778,7 +778,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/dimens.xml"
- line="22"
+ line="23"
column="12"/>
</issue>
@@ -789,7 +789,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/dimens.xml"
- line="23"
+ line="24"
column="12"/>
</issue>
@@ -800,7 +800,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/dimens.xml"
- line="25"
+ line="26"
column="12"/>
</issue>
@@ -811,7 +811,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/dimens.xml"
- line="26"
+ line="27"
column="12"/>
</issue>
@@ -822,7 +822,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/dimens.xml"
- line="28"
+ line="29"
column="12"/>
</issue>
@@ -833,7 +833,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/dimens.xml"
- line="32"
+ line="33"
column="12"/>
</issue>
@@ -844,7 +844,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/dimens.xml"
- line="46"
+ line="47"
column="12"/>
</issue>
@@ -855,7 +855,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/dimens.xml"
- line="47"
+ line="48"
column="12"/>
</issue>
@@ -866,7 +866,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/dimens.xml"
- line="48"
+ line="49"
column="12"/>
</issue>
@@ -877,7 +877,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/dimens.xml"
- line="49"
+ line="50"
column="12"/>
</issue>
@@ -888,7 +888,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/dimens.xml"
- line="50"
+ line="51"
column="12"/>
</issue>
@@ -899,7 +899,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/dimens.xml"
- line="51"
+ line="52"
column="12"/>
</issue>
@@ -910,7 +910,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/dimens.xml"
- line="52"
+ line="53"
column="12"/>
</issue>
@@ -921,7 +921,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/dimens.xml"
- line="53"
+ line="54"
column="12"/>
</issue>
@@ -932,7 +932,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/dimens.xml"
- line="54"
+ line="55"
column="12"/>
</issue>
@@ -943,7 +943,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/dimens.xml"
- line="55"
+ line="56"
column="12"/>
</issue>
@@ -954,7 +954,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/dimens.xml"
- line="56"
+ line="57"
column="12"/>
</issue>
@@ -965,7 +965,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/dimens.xml"
- line="57"
+ line="58"
column="12"/>
</issue>
@@ -976,7 +976,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/dimens.xml"
- line="59"
+ line="60"
column="12"/>
</issue>
@@ -987,7 +987,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/dimens.xml"
- line="61"
+ line="62"
column="12"/>
</issue>
@@ -998,7 +998,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/dimens.xml"
- line="62"
+ line="63"
column="12"/>
</issue>
@@ -1009,7 +1009,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/dimens.xml"
- line="63"
+ line="64"
column="12"/>
</issue>
@@ -1020,7 +1020,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/dimens.xml"
- line="64"
+ line="65"
column="12"/>
</issue>
@@ -1031,7 +1031,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/dimens.xml"
- line="66"
+ line="67"
column="12"/>
</issue>
@@ -1042,7 +1042,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/dimens.xml"
- line="67"
+ line="68"
column="12"/>
</issue>
@@ -1396,23 +1396,12 @@
<issue
id="UnusedResources"
- message="The resource `R.string.has_opened_new_tab` appears to be unused"
- errorLine1=" <string name="has_opened_new_tab" translatable="false"><xliff:g id="preference_key">has_opened_new_tab</xliff:g></string>"
- errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
- <location
- file="src/main/res/values/preference_keys.xml"
- line="76"
- column="13"/>
- </issue>
-
- <issue
- id="UnusedResources"
message="The resource `R.string.pref_key_category_safe_browsing` appears to be unused"
errorLine1=" <string name="pref_key_category_safe_browsing" translatable="false"><xliff:g id="preference_key">safe_browsing_category</xliff:g></string>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/preference_keys.xml"
- line="80"
+ line="77"
column="13"/>
</issue>
@@ -1423,7 +1412,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/preference_keys.xml"
- line="120"
+ line="117"
column="13"/>
</issue>
@@ -2380,7 +2369,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/styles.xml"
- line="40"
+ line="47"
column="12"/>
</issue>
@@ -2391,7 +2380,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/styles.xml"
- line="118"
+ line="136"
column="12"/>
</issue>
@@ -2402,7 +2391,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/styles.xml"
- line="131"
+ line="149"
column="12"/>
</issue>
@@ -2413,7 +2402,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/styles.xml"
- line="152"
+ line="170"
column="12"/>
</issue>
@@ -2424,7 +2413,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/styles.xml"
- line="160"
+ line="178"
column="12"/>
</issue>
@@ -2435,7 +2424,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/styles.xml"
- line="165"
+ line="183"
column="12"/>
</issue>
@@ -2446,7 +2435,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/styles.xml"
- line="175"
+ line="193"
column="12"/>
</issue>
@@ -2457,7 +2446,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/styles.xml"
- line="197"
+ line="215"
column="12"/>
</issue>
@@ -2468,7 +2457,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/styles.xml"
- line="205"
+ line="223"
column="12"/>
</issue>
@@ -2479,7 +2468,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/styles.xml"
- line="210"
+ line="228"
column="12"/>
</issue>
@@ -2490,7 +2479,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/styles.xml"
- line="214"
+ line="232"
column="12"/>
</issue>
@@ -2501,7 +2490,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/styles.xml"
- line="218"
+ line="236"
column="12"/>
</issue>
@@ -2512,7 +2501,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/styles.xml"
- line="222"
+ line="240"
column="12"/>
</issue>
@@ -2523,7 +2512,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/styles.xml"
- line="227"
+ line="245"
column="12"/>
</issue>
