tor-browser

commit c0fb607d463776f817d3ee38a946cd52bb035864
parent 088126d21561805beecc065fb0626819bb9f5ee1
Author: Ryan VanderMeulen <rvandermeulen@mozilla.com>
Date:   Fri, 10 Oct 2025 11:32:09 +0000

Bug 1993596 - Use scrollState.canScrollBackward instead of checking scrollState.value. r=android-reviewers,mcarare

Reading scrollState.value in composition can have a negative performance impact.
https://googlesamples.github.io/android-custom-lint-rules/checks/FrequentlyChangingValue.md.html

Differential Revision: https://phabricator.services.mozilla.com/D268220

Diffstat:
M
mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/CustomTabMenu.kt
 | 
4
++--
M
mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/MainMenu.kt
 | 
4
++--
M
mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/MenuScaffold.kt
 | 
2
+-

3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/CustomTabMenu.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/CustomTabMenu.kt
@@ -107,14 +107,14 @@ internal fun CustomTabMenu(
                     isExtensionsExpanded = false,
                     isMoreMenuExpanded = false,
                 )
-                if (scrollState.value != 0) {
+                if (scrollState.canScrollBackward) {
                     HorizontalDivider(color = FirefoxTheme.colors.borderPrimary)
                 }
             }
         },
         footer = {
             if (isBottomToolbar) {
-                if (scrollState.value != 0) {
+                if (scrollState.canScrollBackward) {
                     HorizontalDivider(color = FirefoxTheme.colors.borderPrimary)
                 }
                 MenuNavigation(
diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/MainMenu.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/MainMenu.kt
@@ -219,14 +219,14 @@ fun MainMenu(
                     isExtensionsExpanded = isExtensionsExpanded,
                     isMoreMenuExpanded = isMoreMenuExpanded,
                 )
-                if (scrollState.value != 0) {
+                if (scrollState.canScrollBackward) {
                     HorizontalDivider(color = FirefoxTheme.colors.borderPrimary)
                 }
             }
         },
         footer = {
             if (accessPoint != MenuAccessPoint.Home && (isBottomToolbar || isExpandedToolbarEnabled)) {
-                if (scrollState.value != 0) {
+                if (scrollState.canScrollBackward) {
                     HorizontalDivider(color = FirefoxTheme.colors.borderPrimary)
                 }
                 MenuNavigation(
diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/MenuScaffold.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/MenuScaffold.kt
@@ -49,7 +49,7 @@ internal fun MenuScaffold(
             Spacer(modifier = Modifier.height(8.dp))
         }
 
-        if (scrollState.value != 0) {
+        if (scrollState.canScrollBackward) {
             HorizontalDivider(color = FirefoxTheme.colors.borderPrimary)
         }