neovim

commit ea52961c54797fc27e305eb4bb11a5d2c4cdda58
parent 0ad5237162a05f0f04c74eab1961166f4f74254b
Author: zeertzjq <zeertzjq@outlook.com>
Date:   Wed, 19 Apr 2023 22:49:14 +0800

refactor: fix PVS warnings (#23200)


Diffstat:
M
src/nvim/fileio.c
 | 
2
+-
M
src/nvim/memline.c
 | 
4
+---
M
src/nvim/option.c
 | 
3
+--

3 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/src/nvim/fileio.c b/src/nvim/fileio.c
@@ -3484,7 +3484,7 @@ char *vim_gettempdir(void)
   static int notfound = 0;
   bool exists = false;
   if (vim_tempdir == NULL || !(exists = os_isdir(vim_tempdir))) {
-    if (vim_tempdir != NULL && !exists) {
+    if (vim_tempdir != NULL) {
       notfound++;
       if (notfound == 1) {
         ELOG("tempdir disappeared (antivirus or broken cleanup job?): %s", vim_tempdir);
diff --git a/src/nvim/memline.c b/src/nvim/memline.c
@@ -1366,9 +1366,7 @@ int recover_names(char *fname, bool do_list, list_T *ret_list, int nr, char **fn
     } else if (ret_list != NULL) {
       for (int i = 0; i < num_files; i++) {
         char *name = concat_fnames(dir_name, files[i], true);
-        if (name != NULL) {
-          tv_list_append_allocated_string(ret_list, name);
-        }
+        tv_list_append_allocated_string(ret_list, name);
       }
     } else {
       file_count += num_files;
diff --git a/src/nvim/option.c b/src/nvim/option.c
@@ -3257,8 +3257,7 @@ static void showoptions(bool all, int opt_flags)
       } else {
         varp = get_varp(p);
       }
-      if (varp != NULL
-          && (all == 1 || (all == 0 && !optval_default(p, varp)))) {
+      if (varp != NULL && (all || !optval_default(p, varp))) {
         int len;
         if (opt_flags & OPT_ONECOLUMN) {
           len = Columns;