neovim

commit 3ae3e47d541db6e2cbf7c42b1ccce9cf48b0e4c9
parent e368560c80f162a67dd1ef5369ebaf57fb937de6
Author: Lewis Russell <lewis6991@gmail.com>
Date:   Wed, 25 Jan 2023 14:53:42 +0000

refactor(option.c): reduce scope or errmsg

Diffstat:
M
src/nvim/option.c
 | 
36
++++++++++++++++++------------------

1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/src/nvim/option.c b/src/nvim/option.c
@@ -1420,7 +1420,6 @@ int do_set(char *arg, int opt_flags)
   char errbuf[80];
 
   while (*arg != NUL) {         // loop to process all options
-    char *errmsg = NULL;
     char *startarg = arg;             // remember for error message
 
     if (strncmp(arg, "all", 3) == 0 && !ASCII_ISALPHA(arg[3])
@@ -1441,6 +1440,7 @@ int do_set(char *arg, int opt_flags)
         did_show = true;
       }
     } else {
+      char *errmsg = NULL;
       do_set_option(opt_flags, &arg, &did_show, errbuf, sizeof(errbuf), &errmsg);
 
       // Advance to next argument.
@@ -1458,26 +1458,26 @@ int do_set(char *arg, int opt_flags)
           break;
         }
       }
-    }
 
-    if (errmsg != NULL) {
-      xstrlcpy(IObuff, _(errmsg), IOSIZE);
-      int i = (int)strlen(IObuff) + 2;
-      if (i + (arg - startarg) < IOSIZE) {
-        // append the argument with the error
-        STRCAT(IObuff, ": ");
-        assert(arg >= startarg);
-        memmove(IObuff + i, startarg, (size_t)(arg - startarg));
-        IObuff[i + (arg - startarg)] = NUL;
-      }
-      // make sure all characters are printable
-      trans_characters(IObuff, IOSIZE);
+      if (errmsg != NULL) {
+        xstrlcpy(IObuff, _(errmsg), IOSIZE);
+        int i = (int)strlen(IObuff) + 2;
+        if (i + (arg - startarg) < IOSIZE) {
+          // append the argument with the error
+          STRCAT(IObuff, ": ");
+          assert(arg >= startarg);
+          memmove(IObuff + i, startarg, (size_t)(arg - startarg));
+          IObuff[i + (arg - startarg)] = NUL;
+        }
+        // make sure all characters are printable
+        trans_characters(IObuff, IOSIZE);
 
-      no_wait_return++;         // wait_return() done later
-      emsg(IObuff);             // show error highlighted
-      no_wait_return--;
+        no_wait_return++;         // wait_return() done later
+        emsg(IObuff);             // show error highlighted
+        no_wait_return--;
 
-      return FAIL;
+        return FAIL;
+      }
     }
 
     arg = skipwhite(arg);