tor

commit ffdfd39d4fc693795f1e3fd222b676fe053681be
parent 9ae35975402a823a420cd5efb81a1c3a76f6c4d6
Author: rl1987 <rl1987@sdf.lonestar.org>
Date:   Thu, 26 Jul 2018 17:49:27 +0300

Early bailout from log_addr_has_changed() if running as client

Diffstat:
A
changes/bug26892
 | 
6
++++++
M
src/feature/relay/router.c
 | 
3
+++

2 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/changes/bug26892 b/changes/bug26892
@@ -0,0 +1,6 @@
+  o Minor bugfixes (logging):
+    - As a precaution, do an early return from
+      log_addr_has_changed() if Tor is running as client. Also,
+      log a stack trace for debugging as this function should only
+      be called when Tor runs as server. Fixes bug 26892;
+      bugfix on 0.1.1.9-alpha.
diff --git a/src/feature/relay/router.c b/src/feature/relay/router.c
@@ -2686,6 +2686,9 @@ log_addr_has_changed(int severity,
   char addrbuf_prev[TOR_ADDR_BUF_LEN];
   char addrbuf_cur[TOR_ADDR_BUF_LEN];
 
+  if (BUG(!server_mode(get_options())))
+    return;
+
   if (tor_addr_to_str(addrbuf_prev, prev, sizeof(addrbuf_prev), 1) == NULL)
     strlcpy(addrbuf_prev, "???", TOR_ADDR_BUF_LEN);
   if (tor_addr_to_str(addrbuf_cur, cur, sizeof(addrbuf_cur), 1) == NULL)