tor

commit efb301c86c288c01e21dfb5da9f685f33341b2c2
parent a623a497778324c4aba570be4217c723d6a3010f
Author: Nick Mathewson <nickm@torproject.org>
Date:   Wed, 15 Jan 2020 12:46:10 -0500

Document why dircache is not included in --list-modules

Diffstat:
M
configure.ac
 | 
2
+-
M
src/app/config/config.c
 | 
3
+++

2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
@@ -290,7 +290,7 @@ AM_COND_IF(BUILD_MODULE_RELAY,
                      [Compile with Relay feature support]))
 
 dnl Dircache module.  (This cannot be enabled or disabled independently of
-dnl the relay module.)
+dnl the relay module.  It is not listed by --list-modules for this reason.)
 AM_CONDITIONAL(BUILD_MODULE_DIRCACHE,
                [test "x$enable_module_relay" != "xno"])
 AM_COND_IF(BUILD_MODULE_DIRCACHE,
diff --git a/src/app/config/config.c b/src/app/config/config.c
@@ -2733,6 +2733,9 @@ list_enabled_modules(void)
 {
   printf("%s: %s\n", "relay", have_module_relay() ? "yes" : "no");
   printf("%s: %s\n", "dirauth", have_module_dirauth() ? "yes" : "no");
+  // We don't list dircache, because it cannot be enabled or disabled
+  // independently from relay.  Listing it here would proliferate
+  // test variants in test_parseconf.sh to no useful purpose.
 }
 
 /** Last value actually set by resolve_my_address. */