tor

commit ece63105d9157fa432cc59d8b828ca23a80040ff
parent 5348c8996f53964ce7466f00acad33f625191983
Author: Nick Mathewson <nickm@torproject.org>
Date:   Mon, 13 Nov 2017 11:13:22 -0500

Merge branch 'maint-0.2.9' into maint-0.3.0

Diffstat:
A
changes/ticket21953
 | 
6
++++++
M
src/or/main.c
 | 
10
+++++++++-

2 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/changes/ticket21953 b/changes/ticket21953
@@ -0,0 +1,6 @@
+  o Minor features:
+    - Enable a couple of pieces of Windows hardening: one
+      (HeapEnableTerminationOnCorruption) that has been on-by-default since
+      Windows 8, and unavailable before Windows 7, and one
+      (PROCESS_DEP_DISABLE_ATL_THUNK_EMULATION) which we believe doesn't
+      affect us, but shouldn't do any harm. Closes ticket 21953.
diff --git a/src/or/main.c b/src/or/main.c
@@ -3575,6 +3575,11 @@ tor_main(int argc, char *argv[])
   int result = 0;
 
 #ifdef _WIN32
+#ifndef HeapEnableTerminationOnCorruption
+#define HeapEnableTerminationOnCorruption 1
+#endif
+  /* On heap corruption, just give up; don't try to play along. */
+  HeapSetInformation(NULL, HeapEnableTerminationOnCorruption, NULL, 0);
   /* Call SetProcessDEPPolicy to permanently enable DEP.
      The function will not resolve on earlier versions of Windows,
      and failure is not dangerous. */
@@ -3583,7 +3588,10 @@ tor_main(int argc, char *argv[])
     typedef BOOL (WINAPI *PSETDEP)(DWORD);
     PSETDEP setdeppolicy = (PSETDEP)GetProcAddress(hMod,
                            "SetProcessDEPPolicy");
-    if (setdeppolicy) setdeppolicy(1); /* PROCESS_DEP_ENABLE */
+    if (setdeppolicy) {
+      /* PROCESS_DEP_ENABLE | PROCESS_DEP_DISABLE_ATL_THUNK_EMULATION */
+      setdeppolicy(3);
+    }
   }
 #endif