tor

commit e6caf7d8c76660dbbaf68ee56c7ebf31a2ac9605
parent 9b6b1aedcdd1f8b76379fb9796020a04416e6b16
Author: Alexander Færøy <ahf@torproject.org>
Date:   Fri, 12 Feb 2021 15:23:34 +0000

Merge branch 'maint-0.4.5'

Diffstat:
M
src/feature/relay/router.c
 | 
10
+++++++---

1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/src/feature/relay/router.c b/src/feature/relay/router.c
@@ -2701,9 +2701,13 @@ check_descriptor_ipaddress_changed(time_t now)
 
     /* Attempt to discovery the publishable address for the family which will
      * actively attempt to discover the address if we are configured with a
-     * port for the family. */
-    relay_find_addr_to_publish(get_options(), family, RELAY_FIND_ADDR_NO_FLAG,
-                               &current);
+     * port for the family.
+     *
+     * It is OK to ignore the returned value here since in the failure case,
+     * that is the address was not found, the current value is set to UNSPEC.
+     * Add this (void) so Coverity is happy. */
+    (void) relay_find_addr_to_publish(get_options(), family,
+                                      RELAY_FIND_ADDR_NO_FLAG, &current);
 
     /* The "current" address might be UNSPEC meaning it was not discovered nor
      * found in our current cache. If we had an address before and we have