commit e17f436fff541e0c31827f0e99bd345096d276e0
parent 627d2fdbf0903498807fdd21c59a91502d731f7d
Author: George Kadianakis <desnacked@riseup.net>
Date: Fri, 27 Apr 2018 15:27:44 +0300
Fix memleak found by unittests.
Diffstat:
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/or/circuitbuild.c b/src/or/circuitbuild.c
@@ -2633,7 +2633,9 @@ choose_good_middle_server(uint8_t purpose,
/** If a hidden service circuit wants a specific middle node, pin it. */
if (middle_node_must_be_vanguard(options, purpose, cur_len)) {
log_debug(LD_GENERAL, "Picking a sticky node (cur_len = %d)", cur_len);
- return pick_vanguard_middle_node(options, flags, cur_len, excluded);
+ choice = pick_vanguard_middle_node(options, flags, cur_len, excluded);
+ smartlist_free(excluded);
+ return choice;
}
choice = router_choose_random_node(excluded, options->ExcludeNodes, flags);