tor

commit dddecee291cadf391d93b569023f1f1e008880e8
parent 370d9922a4e3cb24a5ff093cadc3098771cab957
Author: Nick Mathewson <nickm@torproject.org>
Date:   Tue, 18 Sep 2018 15:13:10 -0400

Initialize some locals in socks5 parsing code.

These confused GCC LTO, which thought they might be used
uninitialized.  I'm pretty sure that as long as 'res' indicates
success, they will always be set to something, but let's unconfuse
the compiler in any case.

Diffstat:
M
src/core/proto/proto_socks.c
 | 
2
+-

1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/core/proto/proto_socks.c b/src/core/proto/proto_socks.c
@@ -744,7 +744,7 @@ handle_socks_message(const uint8_t *raw_data, size_t datalen,
       res = SOCKS_RESULT_MORE_EXPECTED;
       goto end;
     } else if (req->socks_version != SOCKS_VER_5) {
-      int have_user_pass, have_no_auth;
+      int have_user_pass=0, have_no_auth=0;
       res = parse_socks5_methods_request(raw_data, req, datalen,
                                          &have_user_pass,
                                          &have_no_auth,