commit db2f18b1f92509de04be6cd973f9120e9c7be489
parent 26d9fffae428a186e92ffa53053da76bea519fec
Author: Nick Mathewson <nickm@torproject.org>
Date: Mon, 5 Jun 2017 12:02:47 -0400
Merge branch 'maint-0.3.0'
Diffstat:
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/changes/bug22490 b/changes/bug22490
@@ -0,0 +1,3 @@
+ o Minor bugfixes (correctness):
+ - Avoid undefined behavior when parsing IPv6 entries from the geoip6
+ file. Fixes bug 22490; bugfix on 0.2.4.6-alpha.
diff --git a/src/or/geoip.c b/src/or/geoip.c
@@ -162,6 +162,7 @@ geoip_parse_entry(const char *line, sa_family_t family)
if (*line == '#')
return 0;
+ char buf[512];
if (family == AF_INET) {
unsigned int low, high;
if (tor_sscanf(line,"%u,%u,%2s", &low, &high, c) == 3 ||
@@ -172,7 +173,6 @@ geoip_parse_entry(const char *line, sa_family_t family)
goto fail;
country = c;
} else { /* AF_INET6 */
- char buf[512];
char *low_str, *high_str;
struct in6_addr low, high;
char *strtok_state;