commit db1c1dba34545c9b96f9ec4c01338caeaeeb0433
parent 4aa02d3c7abe84e99874f6bf7bfffb7b551935a5
Author: Nick Mathewson <nickm@torproject.org>
Date: Thu, 4 Apr 2019 11:26:33 -0400
Merge branch 'bug30021_029' into bug30021_035
Diffstat:
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/changes/bug30021 b/changes/bug30021
@@ -0,0 +1,8 @@
+ o Minor bugfixes (TLS protocol, integration tests):
+ - When classifying a client's selection of TLS ciphers, if the client
+ ciphers are not yet available, do not cache the result. Previously,
+ we had cached the unavailability of the cipher list and never looked
+ again, which in turn led us to assume that the client only supported
+ the ancient V1 link protocol. This, in turn, was causing Stem
+ integration tests to stall in some cases.
+ Fixes bug 30021; bugfix on 0.2.4.8-alpha.
diff --git a/src/lib/tls/tortls_openssl.c b/src/lib/tls/tortls_openssl.c
@@ -905,7 +905,7 @@ tor_tls_classify_client_ciphers(const SSL *ssl,
smartlist_free(elts);
}
done:
- if (tor_tls)
+ if (tor_tls && peer_ciphers)
return tor_tls->client_cipher_list_type = res;
return res;