tor

commit d1ffac3f8abbdd5b7d8e5955615821bff3ee3729
parent 25d55fa01ebc8d9bc8cd52672605636a9261ddf5
Author: Nick Mathewson <nickm@torproject.org>
Date:   Wed, 18 Sep 2019 08:52:01 -0400

practracker: An exception is "used" even when it is violated.

The purpose of tracking whether an exception is used is so that we
can tell whether it is overbroad.  This means that an _underbroad_
exception is still a used one.  Fixes bug 31338.

Diffstat:
M
scripts/maint/practracker/problem.py
 | 
6
++++--

1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/scripts/maint/practracker/problem.py b/scripts/maint/practracker/problem.py
@@ -77,8 +77,10 @@ class ProblemVault(object):
         # (e.g. we went from 4k LoC to 3k LoC), but we do warn if the
         # situation worsened (e.g. we went from 60 includes to 80).
         status = problem.is_worse_than(self.exceptions[problem.key()])
-        if status == STATUS_OK:
-            self.used_exception_for[problem.key()] = problem
+
+        # Remember that we used this exception, so that we can later
+        # determine whether the exception was overbroad.
+        self.used_exception_for[problem.key()] = problem
 
         return status