tor

commit c107aae3c29bb0f62586ffef4c636ae2f47e746b
parent 4b4b3afb569a40db99c1614bc83d835b0a23fe27
Author: Nick Mathewson <nickm@torproject.org>
Date:   Mon, 28 Aug 2017 11:43:55 -0400

Merge branch 'ticket22348_031'

Diffstat:
A
changes/ticket22348
 | 
5
+++++
M
src/or/dirserv.c
 | 
7
++++++-

2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/changes/ticket22348 b/changes/ticket22348
@@ -0,0 +1,5 @@
+  o Minor features (directory authority):
+    - Improve the message that authorities report to relays when
+      the RSA/Ed25519 key pair they present conflicts with a previously
+      pinned key. Closes ticket 22348.
+
diff --git a/src/or/dirserv.c b/src/or/dirserv.c
@@ -732,7 +732,12 @@ dirserv_add_descriptor(routerinfo_t *ri, const char **msg, const char *source)
     log_info(LD_DIRSERV, "Dropping descriptor from %s (source: %s) because "
              "its key did not match an older RSA/Ed25519 keypair",
              router_describe(ri), source);
-    *msg = "Looks like your keypair does not match its older value.";
+    *msg = "Looks like your keypair has changed? This authority previously "
+      "recorded a different RSA identity for this Ed25519 identity (or vice "
+      "versa.) Did you replace or copy some of your key files, but not "
+      "the others? You should either restore the expected keypair, or "
+      "delete your keys and restart Tor to start your relay with a new "
+      "identity.";
     r = ROUTER_AUTHDIR_REJECTS;
     goto fail;
   }