tor

commit be29dfedd99f49b8bf22422eff04986f12580733
parent 15dc33849eda4fba651bf4096a9e405d737a977b
Author: teor <teor@torproject.org>
Date:   Thu, 28 Feb 2019 10:45:59 +1000

Merge branch 'maint-0.3.4' into maint-0.3.5

Diffstat:
A
changes/bug29599
 | 
3
+++
M
src/test/test_shared_random.c
 | 
5
+++--

2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/changes/bug29599 b/changes/bug29599
@@ -0,0 +1,3 @@
+  o Minor bugfixes (memory management, testing):
+    - Stop leaking parts of the shared random state in the shared-random unit
+      tests. Fixes bug 29599; bugfix on 0.2.9.1-alpha.
diff --git a/src/test/test_shared_random.c b/src/test/test_shared_random.c
@@ -733,8 +733,8 @@ test_vote(void *arg)
   }
 
  done:
-  sr_commit_free(our_commit);
   UNMOCK(trusteddirserver_get_by_v3_auth_digest);
+  sr_state_free();
 }
 
 static const char *sr_state_str = "Version 1\n"
@@ -968,6 +968,7 @@ test_sr_compute_srv(void *arg)
 
  done:
   UNMOCK(trusteddirserver_get_by_v3_auth_digest);
+  sr_state_free();
 }
 
 /** Return a minimal vote document with a current SRV value set to
@@ -1233,7 +1234,7 @@ test_state_transition(void *arg)
   }
 
  done:
-  return;
+  sr_state_free();
 }
 
 static void