tor

commit bdd17da9fdfbe9de0547f27c7a78255a56570aa4
parent 286b129b09964bbff2bd8f5de7f4edac5f2b4827
Author: George Kadianakis <desnacked@riseup.net>
Date:   Mon, 16 Sep 2019 15:19:38 +0300

Merge branch 'tor-github/pr/1318'

Diffstat:
A
changes/bug31696
 | 
5
+++++
M
src/lib/malloc/map_anon.c
 | 
21
++++++++++++++++++---

2 files changed, 23 insertions(+), 3 deletions(-)
diff --git a/changes/bug31696 b/changes/bug31696
@@ -0,0 +1,5 @@
+  o Major bugfixes (crash, Linux):
+    - Tolerate systems (including some Linux installations) where madvise
+      and/or MADV_DONTFORK are available at build-time, but not at run time.
+      Previously, these systems would notice a failed syscall and abort.
+      Fixes bug 31696; bugfix on 0.4.1.1-alpha.
diff --git a/src/lib/malloc/map_anon.c b/src/lib/malloc/map_anon.c
@@ -149,18 +149,33 @@ noinherit_mem(void *mem, size_t sz, inherit_res_t *inherit_result_out)
     return 0;
   }
 #endif /* defined(FLAG_ZERO) */
+
 #ifdef FLAG_NOINHERIT
   int r2 = MINHERIT(mem, sz, FLAG_NOINHERIT);
   if (r2 == 0) {
     *inherit_result_out = INHERIT_RES_DROP;
+    return 0;
+  }
+#endif /* defined(FLAG_NOINHERIT) */
+
+#if defined(FLAG_ZERO) || defined(FLAG_NOINHERIT)
+  /* At least one operation was tried, and neither succeeded. */
+
+  if (errno == ENOSYS || errno == EINVAL) {
+    /* Syscall not supported, or flag not supported. */
+    return 0;
+  } else {
+    tor_log_err_sigsafe("Unexpected error from minherit: ",
+                        strerror(errno),
+                        NULL);
+    return -1;
   }
-  return r2;
-#else /* !(defined(FLAG_NOINHERIT)) */
+#else
   (void)inherit_result_out;
   (void)mem;
   (void)sz;
   return 0;
-#endif /* defined(FLAG_NOINHERIT) */
+#endif
 }
 
 /**