tor

commit a0db5ade3e1e2b81ed1196eb98aeca53583fba64
parent e1955a2c54e2c9ab25252c46f13f0a222828a6ff
Author: teor <teor@torproject.org>
Date:   Sat,  6 Apr 2019 09:28:58 +1000

Merge remote-tracking branch 'tor-github/pr/902' into maint-0.2.9

Diffstat:
A
changes/bug30021
 | 
8
++++++++
M
src/common/tortls.c
 | 
2
+-

2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/changes/bug30021 b/changes/bug30021
@@ -0,0 +1,8 @@
+  o Minor bugfixes (TLS protocol, integration tests):
+    - When classifying a client's selection of TLS ciphers, if the client
+      ciphers are not yet available, do not cache the result. Previously,
+      we had cached the unavailability of the cipher list and never looked
+      again, which in turn led us to assume that the client only supported
+      the ancient V1 link protocol.  This, in turn, was causing Stem
+      integration tests to stall in some cases.
+      Fixes bug 30021; bugfix on 0.2.4.8-alpha.
diff --git a/src/common/tortls.c b/src/common/tortls.c
@@ -1500,7 +1500,7 @@ tor_tls_classify_client_ciphers(const SSL *ssl,
     smartlist_free(elts);
   }
  done:
-  if (tor_tls)
+  if (tor_tls && peer_ciphers)
     return tor_tls->client_cipher_list_type = res;
 
   return res;