commit 732855c2e533fbab7c9087bf251e38b07bd27af2
parent 57d33b5786019b3320a7b2d5c747ce31ea3e1a77
Author: Nick Mathewson <nickm@torproject.org>
Date: Tue, 26 Feb 2019 07:27:50 -0500
Merge branch 'maint-0.4.0'
Diffstat:
2 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/changes/bug13221 b/changes/bug13221
@@ -0,0 +1,5 @@
+ o Minor bugfixes (logging):
+ - Correct a misleading error message when IPv4Only or IPv6Only
+ is used but the resolved address can not be interpreted as an
+ address of the specified IP version. Fixes bug 13221; bugfix
+ on 0.2.3.9-alpha. Patch from Kris Katterjohn.
diff --git a/src/app/config/config.c b/src/app/config/config.c
@@ -7042,13 +7042,13 @@ parse_port_config(smartlist_t *out,
portname, escaped(ports->value));
goto err;
}
- if (bind_ipv4_only && tor_addr_family(&addr) == AF_INET6) {
- log_warn(LD_CONFIG, "Could not interpret %sPort address as IPv6",
+ if (bind_ipv4_only && tor_addr_family(&addr) != AF_INET) {
+ log_warn(LD_CONFIG, "Could not interpret %sPort address as IPv4",
portname);
goto err;
}
- if (bind_ipv6_only && tor_addr_family(&addr) == AF_INET) {
- log_warn(LD_CONFIG, "Could not interpret %sPort address as IPv4",
+ if (bind_ipv6_only && tor_addr_family(&addr) != AF_INET6) {
+ log_warn(LD_CONFIG, "Could not interpret %sPort address as IPv6",
portname);
goto err;
}