tor

The Tor anonymity network
git clone https://git.dasho.dev/tor.git
Log | Files | Refs | README | LICENSE

commit 6d48e756855b79becf275c062b4e2fd48ccee23b
parent ea5af8f44202c3272c616d319cdf0fa048eec9da
Author: George Kadianakis <desnacked@riseup.net>
Date:   Fri, 25 Aug 2017 17:16:53 +0300

prop224: Better missing hsdir index logs.

Seems like hsdir index bugs are around to haunt us. Let's improve the
log messages to make debugging easier.

Diffstat:
Msrc/or/hs_common.c | 4++++
1 file changed, 4 insertions(+), 0 deletions(-)

diff --git a/src/or/hs_common.c b/src/or/hs_common.c @@ -1206,12 +1206,16 @@ node_has_hsdir_index(const node_t *node, int is_for_next_period) if (BUG(node->hsdir_index == NULL) || BUG(tor_mem_is_zero((const char*)node->hsdir_index->current, DIGEST256_LEN))) { + log_warn(LD_BUG, "Zero current index (ri: %p, rs: %p, md: %p)", + node->ri, node->rs, node->md); return 0; } if (is_for_next_period && BUG(tor_mem_is_zero((const char*)node->hsdir_index->next, DIGEST256_LEN))) { + log_warn(LD_BUG, "Zero next index (ri: %p, rs: %p, md: %p)", + node->ri, node->rs, node->md); return 0; }