tor

The Tor anonymity network
git clone https://git.dasho.dev/tor.git
Log | Files | Refs | README | LICENSE

commit 650fabc6ad7e471d18f1e10563149893131cc69d
parent f79afc54dd5cd2c6388dc535e91b002a9495b572
Author: Sebastian Hahn <sebastian@torproject.org>
Date:   Thu,  1 Feb 2024 19:45:04 +0100

Make two 1-bit fields unsigned

This should be a completely harmless warning as we only check whether
the fields are true or false.

Closes #40911.

(Backported by nickm so that I can compile 0.4.8 without warnings.)

Diffstat:
Achanges/bug40911 | 5+++++
Msrc/core/or/half_edge_st.h | 4++--
2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/changes/bug40911 b/changes/bug40911 @@ -0,0 +1,5 @@ + o Minor bugfixes (compiler warnings): + - Make sure the two bitfields in the half-closed edge struct are + unsigned, as we're using them for boolean values and assign 1 to + them. Fixes bug 40911; bugfix on 0.4.7.2-alpha. + diff --git a/src/core/or/half_edge_st.h b/src/core/or/half_edge_st.h @@ -41,10 +41,10 @@ typedef struct half_edge_t { /** * Did this edge use congestion control? If so, use * timer instead of pending data approach */ - int used_ccontrol : 1; + unsigned int used_ccontrol : 1; /** Is there a connected cell pending? */ - int connected_pending : 1; + unsigned int connected_pending : 1; } half_edge_t; #endif /* !defined(HALF_EDGE_ST_H) */