tor

commit 59008c6f515cb63b12061a24a9c4ddf0dc018e7f
parent a317326aae5dfdd63fced907ffcf822563dff729
Author: David Goulet <dgoulet@torproject.org>
Date:   Wed, 19 Oct 2022 14:41:48 -0400

hs: Change the error for a collapsing client circuit

Change it to an "unreachable" error so the intro point can be retried
and not flagged as a failure and never retried again.

Closes #40692

Signed-off-by: David Goulet <dgoulet@torproject.org>

Diffstat:
A
changes/ticket40692
 | 
3
+++
M
src/feature/hs/hs_client.c
 | 
2
+-

2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/changes/ticket40692 b/changes/ticket40692
@@ -0,0 +1,3 @@
+  o Minor bugfixes (onion service client):
+    - A collapsing onion service circuit should be seen as an "unreachable"
+      error so it can be retried. Fixes bug 40692; bugfix on 0.3.5.1-alpha.
diff --git a/src/feature/hs/hs_client.c b/src/feature/hs/hs_client.c
@@ -1964,7 +1964,7 @@ void
 hs_client_circuit_cleanup_on_free(const circuit_t *circ)
 {
   bool has_timed_out;
-  rend_intro_point_failure_t failure = INTRO_POINT_FAILURE_GENERIC;
+  rend_intro_point_failure_t failure = INTRO_POINT_FAILURE_UNREACHABLE;
   const origin_circuit_t *orig_circ = NULL;
 
   tor_assert(circ);