tor

commit 4894d44ab8beee587c99a1765236813d445b392e
parent 94a79981580d6260597f799bc1a163c8e6f07acd
Author: Nick Mathewson <nickm@torproject.org>
Date:   Mon, 17 Dec 2018 09:38:42 -0500

Always initialize addr in parse_port_config()

It was always analyzed before use, but scan-build wasn't able to
persuade itself of that.

Closes ticket 28881.

Diffstat:
A
changes/ticket28881
 | 
4
++++
M
src/app/config/config.c
 | 
2
++

2 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/changes/ticket28881 b/changes/ticket28881
@@ -0,0 +1,4 @@
+  o Code simplification and refactoring:
+    -  When parsing a port configuration, make it more
+       obvious to static analyzer tools that we will always initialize the
+       address. Closes ticket 28881.
diff --git a/src/app/config/config.c b/src/app/config/config.c
@@ -6913,6 +6913,8 @@ parse_port_config(smartlist_t *out,
 
   for (; ports; ports = ports->next) {
     tor_addr_t addr;
+    tor_addr_make_unspec(&addr);
+
     int port;
     int sessiongroup = SESSION_GROUP_UNSET;
     unsigned isolation = ISO_DEFAULT;