tor

commit 472473ec5d1a49b852b2f20fd7b0ed3350877cd2
parent a7e777ab8ef6063f3811be58e152269ad38b9143
Author: Nick Mathewson <nickm@torproject.org>
Date:   Sun, 26 Nov 2017 17:05:30 -0500

transport_new() cannot fail; do not check for it to fail.

(It can't fail because the tor_malloc*() family of functions can
never return NULL)

Found with STACK.

Diffstat:
M
src/or/transports.c
 | 
4
----

1 file changed, 0 insertions(+), 4 deletions(-)
diff --git a/src/or/transports.c b/src/or/transports.c
@@ -1094,8 +1094,6 @@ parse_smethod_line(const char *line, managed_proxy_t *mp)
 
   transport = transport_new(&tor_addr, port, method_name,
                             PROXY_NONE, args_string);
-  if (!transport)
-    goto err;
 
   smartlist_add(mp->transports, transport);
 
@@ -1186,8 +1184,6 @@ parse_cmethod_line(const char *line, managed_proxy_t *mp)
   }
 
   transport = transport_new(&tor_addr, port, method_name, socks_ver, NULL);
-  if (!transport)
-    goto err;
 
   smartlist_add(mp->transports, transport);