tor

commit 400cee261ecccd024f6cb13dd1a940d4b9d0057b
parent 54c01119ed59668bfa8ed6ef978201731bef0554
Author: teor <teor@torproject.org>
Date:   Mon, 25 Nov 2019 12:34:29 +1000

Merge remote-tracking branch 'tor-github/pr/1422' into maint-0.3.5

Diffstat:
A
changes/ticket32058
 | 
5
+++++
M
src/core/mainloop/periodic.c
 | 
5
+++++

2 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/changes/ticket32058 b/changes/ticket32058
@@ -0,0 +1,5 @@
+  o Minor bugfixes (mainloop, periodic events):
+    - Periodic events enabled flag was not unset properly when shutting down tor
+      cleanly. This had the side effect to not re-enable periodic events when
+      tor_api.h is used to relaunch tor after a shutdown. Fixes bug 32058;
+      bugfix on 0.3.3.1-alpha.
diff --git a/src/core/mainloop/periodic.c b/src/core/mainloop/periodic.c
@@ -137,6 +137,11 @@ periodic_event_destroy(periodic_event_item_t *event)
 {
   if (!event)
     return;
+
+  /* First disable the event so we first cancel the event and set its enabled
+   * flag properly. */
+  periodic_event_disable(event);
+
   mainloop_event_free(event->ev);
   event->last_action_time = 0;
 }