commit 3a364309ace5bc0b75b724484d6b27d84ec6a8b1
parent 0571015819317f6b52416d8023a99ee5a8f31dee
Author: Nick Mathewson <nickm@torproject.org>
Date: Fri, 17 Nov 2017 08:35:52 -0500
Merge branch 'bug24167_025' into maint-0.3.2
Diffstat:
2 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/changes/bug24167 b/changes/bug24167
@@ -0,0 +1,7 @@
+ o Minor bugfixes (network layer):
+ - When closing a connection via close_connection_immediately(), we
+ mark it as "not blocked on bandwidth", to prevent later calls
+ from trying to unblock it, and give it permission to read. This
+ fixes a backtrace warning that can happen on relays under various
+ circumstances. Fixes bug 24167; bugfix on 0.1.0.1-rc.
+
diff --git a/src/or/connection.c b/src/or/connection.c
@@ -770,6 +770,10 @@ connection_close_immediate(connection_t *conn)
connection_unregister_events(conn);
+ /* Prevent the event from getting unblocked. */
+ conn->read_blocked_on_bw =
+ conn->write_blocked_on_bw = 0;
+
if (SOCKET_OK(conn->s))
tor_close_socket(conn->s);
conn->s = TOR_INVALID_SOCKET;