tor

commit 33a80921a2e7bbf128c27a1a0c4903a9a322708a
parent 3370b3cfef62cba8377285d95b232f810edde504
Author: Nick Mathewson <nickm@torproject.org>
Date:   Mon, 26 Mar 2018 09:17:50 -0400

When extending a circuit's path length, clear onehop_tunnel.

There was a nonfatal assertion in pathbias_should_count that would
trigger if onehop_tunnel was set, but the desired_path_length was
greater than 1.  This patch fixes that.  Fixes bug 24903; bugfix on
0.2.5.2-alpha.

Diffstat:
A
changes/bug24903
 | 
5
+++++
M
src/or/control.c
 | 
3
+++

2 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/changes/bug24903 b/changes/bug24903
@@ -0,0 +1,5 @@
+  o Minor bugfixes (controller, reliability):
+    - Avoid a (nonfatal) assertion failure when extending a one-hop circuit
+      from the controller to become a multihop circuit. Fixes bug 24903;
+      bugfix on 0.2.5.2-alpha.
+
diff --git a/src/or/control.c b/src/or/control.c
@@ -3364,6 +3364,9 @@ handle_control_extendcircuit(control_connection_t *conn, uint32_t len,
       tor_assert(info);
     }
     circuit_append_new_exit(circ, info);
+    if (circ->build_state->desired_path_len > 1) {
+      circ->build_state->onehop_tunnel = 0;
+    }
     extend_info_free(info);
     first_node = 0;
   });