tor

commit 3395de51a01aa5519c52404ed2bb9c8cda3571c9
parent dcbfee246f35970f65d08a4555e25b956b9aba9c
Author: Alexander Færøy <ahf@torproject.org>
Date:   Sat, 23 Jun 2018 11:28:00 +0200

Fix memory leak in disk_state_parse_commits().

This patch fixes a memory leak in disk_state_parse_commits() where if
commit is NULL, we continue the internal loop, but without ever freeing
the args variable.

See: Coverity CID 1437441.

Diffstat:
M
src/or/shared_random_state.c
 | 
1
+

1 file changed, 1 insertion(+), 0 deletions(-)
diff --git a/src/or/shared_random_state.c b/src/or/shared_random_state.c
@@ -409,6 +409,7 @@ disk_state_parse_commits(sr_state_t *state,
     if (commit == NULL) {
       /* Ignore badly formed commit. It could also be a authority
        * fingerprint that we don't know about so it shouldn't be used. */
+      smartlist_free(args);
       continue;
     }
     /* We consider parseable commit from our disk state to be valid because