commit 16351d655d5f2cf8a69323b69f55f89c96d91beb
parent 07006785fd47e6ce3303659a03004e133d204cc2
Author: David Goulet <dgoulet@torproject.org>
Date: Tue, 17 Nov 2020 13:23:29 -0500
sendme: Turn log warning into debug
When sending the stream level SENDME, it is possible the cirucit was marked
for close or any other failures that can occur. These events can occur
naturally.
Fixes #40142
Signed-off-by: David Goulet <dgoulet@torproject.org>
Diffstat:
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/changes/ticket40142 b/changes/ticket40142
@@ -0,0 +1,3 @@
+ o Minor bugfixes (logging, flow control):
+ - Turn a SENDME failure log warning into a debug. It can actually happen
+ naturally. Fixes bug 40142; bugfix on 0.4.1.1-alpha.
diff --git a/src/core/or/sendme.c b/src/core/or/sendme.c
@@ -398,8 +398,8 @@ sendme_connection_edge_consider_sending(edge_connection_t *conn)
conn->deliver_window += STREAMWINDOW_INCREMENT;
if (connection_edge_send_command(conn, RELAY_COMMAND_SENDME,
NULL, 0) < 0) {
- log_warn(LD_BUG, "connection_edge_send_command failed while sending "
- "a SENDME. Circuit probably closed, skipping.");
+ log_debug(LD_CIRC, "connection_edge_send_command failed while sending "
+ "a SENDME. Circuit probably closed, skipping.");
goto end; /* The circuit's closed, don't continue */
}
}