commit 0acc3ae87904ca5d9bd430a5a89f89dd97f9ec85 parent 3517d203227284d41ead62d65e90b38b9f11186e Author: Nick Mathewson <nickm@torproject.org> Date: Mon, 13 Jul 2020 09:24:26 -0400 Remove check-cocci from check-local target. check-cocci is still a good idea -- perhaps as a cron job? But doing it as part of our regular tests has just been confusing, especially to volunteers who shouldn't have to become coccinelle experts in order to get their patches through our CI. Closes #40030. Diffstat:
| M | Makefile.am | | | 3 | +-- |
| A | changes/ticket40030 | | | 7 | +++++++ |
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/Makefile.am b/Makefile.am @@ -271,8 +271,7 @@ check-local: \ check-spaces \ check-changes \ check-includes \ - shellcheck \ - check-cocci + shellcheck need-chutney-path: @if test ! -d "$$CHUTNEY_PATH"; then \ diff --git a/changes/ticket40030 b/changes/ticket40030 @@ -0,0 +1,7 @@ + o Removed features: + - Our "check-local" test target no longer tries to use the Coccinelle + semantic patching tool parse all the C files. While it is a good idea + to try to make sure Coccinelle works on our C before we run a + Coccinelle patch, doing so on every test run has proven to be disruptive. + You can still run this tool manually with "make check-cocci". Closes + ticket 40030.