tor-browser

commit fe787812bcbb4cecf0605d518b4904d45fa8d272
parent becf485d502911b19f3058e30c772b4b850d2743
Author: Stephen Thompson <sthompson@mozilla.com>
Date:   Tue,  6 Jan 2026 17:14:29 +0000

Bug 2008659 - fix saved tab group icon in List All Tabs menu r=dwalker,tabbrowser-reviewers

Ensures that all tab group buttons in the GroupsList have `.tab-group-icon` and the saved groups also have `.tab-group-icon-closed`. Saved group icons were falling back to a wireframe globe icon because they were missing `.tab-group-icon`.

Differential Revision: https://phabricator.services.mozilla.com/D277958

Diffstat:
M
browser/components/tabbrowser/GroupsList.sys.mjs
 | 
12
+++---------

1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/browser/components/tabbrowser/GroupsList.sys.mjs b/browser/components/tabbrowser/GroupsList.sys.mjs
@@ -128,9 +128,6 @@ export class GroupsPanel {
       }
       itemCount++;
       let row = this.#createRow(groupData);
-      let button = row.querySelector("toolbarbutton");
-      button.dataset.command = "allTabsGroupView_selectGroup";
-      button.setAttribute("context", "open-tab-group-context-menu");
       fragment.appendChild(row);
     }
 
@@ -140,10 +137,6 @@ export class GroupsPanel {
       }
       itemCount++;
       let row = this.#createRow(groupData, { isOpen: false });
-      let button = row.querySelector("toolbarbutton");
-      button.dataset.command = "allTabsGroupView_restoreGroup";
-      button.classList.add("all-tabs-group-saved-group");
-      button.setAttribute("context", "saved-tab-group-context-menu");
       fragment.appendChild(row);
     }
 
@@ -188,7 +181,7 @@ export class GroupsPanel {
     let button = doc.createXULElement("toolbarbutton");
     button.setAttribute(
       "class",
-      "all-tabs-button subviewbutton subviewbutton-iconic all-tabs-group-action-button"
+      "all-tabs-button subviewbutton subviewbutton-iconic all-tabs-group-action-button tab-group-icon"
     );
     button.dataset.tabGroupId = group.id;
     if (!isOpen) {
@@ -197,9 +190,10 @@ export class GroupsPanel {
         "tab-group-icon-closed"
       );
       button.dataset.command = "allTabsGroupView_restoreGroup";
+      button.setAttribute("context", "saved-tab-group-context-menu");
     } else {
-      button.classList.add("tab-group-icon");
       button.dataset.command = "allTabsGroupView_selectGroup";
+      button.setAttribute("context", "open-tab-group-context-menu");
     }
     button.setAttribute("flex", "1");
     button.setAttribute("crop", "end");