commit fe2575c2837d2d9e0cb81e5642db22f87b6167fb
parent cb78ea67440ae74837aad54cdc655f3c038e9e4d
Author: Michael Froman <mfroman@mozilla.com>
Date: Thu, 9 Oct 2025 10:13:35 -0500
Bug 1993083 - Vendor libwebrtc from 9689953749
Upstream commit: https://webrtc.googlesource.com/src/+/968995374993687549539d19acbb027fa67f48fa
Fix inadvertent global variables in RTCVideoEncoderFactoryFake
A minor test issue caught by a linter, based on the underscore-prefixed
naming these were intended to be instance variables, not global.
Change-Id: I0f64ed2d0254236df1da943009058fe08b7c0a3f
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/399720
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Commit-Queue: Joachim Reiersen <joachimr@meta.com>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#45128}
Diffstat:
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/third_party/libwebrtc/README.mozilla.last-vendor b/third_party/libwebrtc/README.mozilla.last-vendor
@@ -1,4 +1,4 @@
# ./mach python dom/media/webrtc/third_party_build/vendor-libwebrtc.py --from-local /home/mfroman/mozilla/elm/.moz-fast-forward/moz-libwebrtc --commit mozpatches libwebrtc
-libwebrtc updated from /home/mfroman/mozilla/elm/.moz-fast-forward/moz-libwebrtc commit mozpatches on 2025-10-09T15:09:04.663181+00:00.
+libwebrtc updated from /home/mfroman/mozilla/elm/.moz-fast-forward/moz-libwebrtc commit mozpatches on 2025-10-09T15:13:26.110326+00:00.
# base of lastest vendoring
-a084fd66f2
+9689953749
diff --git a/third_party/libwebrtc/sdk/objc/unittests/objc_video_encoder_factory_tests.mm b/third_party/libwebrtc/sdk/objc/unittests/objc_video_encoder_factory_tests.mm
@@ -67,10 +67,11 @@ id<RTC_OBJC_TYPE(RTCVideoEncoderFactory)> CreateErrorEncoderFactory() {
isPowerEfficient:(bool)isPowerEfficient
NS_DESIGNATED_INITIALIZER;
@end
-@implementation RTCVideoEncoderFactoryFake
-NSString *_scalabilityMode;
-bool _isPowerEfficient;
+@implementation RTCVideoEncoderFactoryFake {
+ NSString *_scalabilityMode;
+ bool _isPowerEfficient;
+}
- (instancetype)initWithScalabilityMode:(NSString *)scalabilityMode {
return [self initWithScalabilityMode:scalabilityMode isPowerEfficient:false];
