tor-browser

commit f99eb9f28f0035d80bcbe22e6cf661ba52cd0f44
parent 05e21b22de04f1df8a83c463350fb52e2c32ed4b
Author: Mark Banner <standard8@mozilla.com>
Date:   Mon,  5 Jan 2026 16:22:36 +0000

Bug 2008514 - Fix jsdoc issues in SmartInput* code due to multiple type definitions across setters and getters. r=flozia DONTBUILD

Differential Revision: https://phabricator.services.mozilla.com/D277882

Diffstat:
M
browser/components/urlbar/content/SmartbarInput.mjs
 | 
12
------------
M
browser/components/urlbar/content/SmartbarInputController.mjs
 | 
20
--------------------

2 files changed, 0 insertions(+), 32 deletions(-)
diff --git a/browser/components/urlbar/content/SmartbarInput.mjs b/browser/components/urlbar/content/SmartbarInput.mjs
@@ -620,9 +620,6 @@ export class SmartbarInput extends HTMLElement {
     );
   }
 
-  /**
-   * @type {typeof HTMLInputElement.prototype.placeholder}
-   */
   set placeholder(val) {
     if (this.#smartbarInputController) {
       this.#smartbarInputController.placeholder = val;
@@ -640,9 +637,6 @@ export class SmartbarInput extends HTMLElement {
     return this.#smartbarInputController?.readOnly ?? this.inputField?.readOnly;
   }
 
-  /**
-   * @type {typeof HTMLInputElement.prototype.readOnly}
-   */
   set readOnly(val) {
     if (this.#smartbarInputController) {
       this.#smartbarInputController.readOnly = val;
@@ -664,9 +658,6 @@ export class SmartbarInput extends HTMLElement {
     );
   }
 
-  /**
-   * @type {typeof HTMLInputElement.prototype.selectionStart}
-   */
   set selectionStart(val) {
     if (this.#smartbarInputController) {
       this.#smartbarInputController.selectionStart = val;
@@ -688,9 +679,6 @@ export class SmartbarInput extends HTMLElement {
     );
   }
 
-  /**
-   * @type {typeof HTMLInputElement.prototype.selectionEnd}
-   */
   set selectionEnd(val) {
     if (this.#smartbarInputController) {
       this.#smartbarInputController.selectionEnd = val;
diff --git a/browser/components/urlbar/content/SmartbarInputController.mjs b/browser/components/urlbar/content/SmartbarInputController.mjs
@@ -51,11 +51,6 @@ export class SmartbarInputController {
     return this.input.readOnly;
   }
 
-  /**
-   * Sets the read-only state of the input.
-   *
-   * @param {boolean} val
-   */
   set readOnly(val) {
     this.input.readOnly = val;
   }
@@ -69,11 +64,6 @@ export class SmartbarInputController {
     return this.input.placeholder ?? "";
   }
 
-  /**
-   * Sets the placeholder text for the input.
-   *
-   * @param {string} val
-   */
   set placeholder(val) {
     this.input.placeholder = val ?? "";
   }
@@ -105,11 +95,6 @@ export class SmartbarInputController {
     return this.input.selectionStart ?? 0;
   }
 
-  /**
-   * Sets the start offset of the selection.
-   *
-   * @param {number} val
-   */
   set selectionStart(val) {
     this.setSelectionRange(val, this.selectionEnd ?? val);
   }
@@ -123,11 +108,6 @@ export class SmartbarInputController {
     return this.input.selectionEnd ?? 0;
   }
 
-  /**
-   * Sets the end offset of the selection.
-   *
-   * @param {number} val
-   */
   set selectionEnd(val) {
     this.setSelectionRange(this.selectionStart ?? 0, val);
   }