tor-browser

commit f740b05da24b2994f0e915889ec7e43ec0dfcccf
parent 3c8218f11dde21dbc4af7144a842df6f837f5cae
Author: Andrew Osmond <aosmond@gmail.com>
Date:   Thu, 27 Nov 2025 17:58:36 +0000

Bug 2002697 - Only attempt to destroy GMP process once if crashes during shutdown. r=media-playback-reviewers,padenot

We need to let GMPParent::ActorDestroy complete the teardown when we
crash during the shutdown handshake attempting to get the profiler, if
present, from the GMP process.

Differential Revision: https://phabricator.services.mozilla.com/D274242

Diffstat:
M
dom/media/gmp/GMPParent.cpp
 | 
4
+---

1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/dom/media/gmp/GMPParent.cpp b/dom/media/gmp/GMPParent.cpp
@@ -685,13 +685,11 @@ void GMPParent::DeleteProcess() {
             self->DeleteProcess();
           },
           [self](const ipc::ResponseRejectReason&) {
+            // We crashed during shutdown, ActorDestroy will perform cleanup.
             GMP_LOG_DEBUG(
                 "GMPParent[%p|childPid=%d] DeleteProcess: Shutdown handshake "
                 "error.",
                 self.get(), self->mChildPid);
-            self->mState = GMPState::Closed;
-            self->Close();
-            self->DeleteProcess();
           });
       return;
     }