commit f4ded43b977e2ce1f6e0dada746ad650249c127b parent 820e6e5cba9880b7ba2c829a8e09602951c5f9e8 Author: serge-sans-paille <sguelton@mozilla.com> Date: Fri, 24 Oct 2025 13:05:03 +0000 Bug 1993127 - Remove unused inclusion of Attributes.h from gfx/* r=emilio Differential Revision: https://phabricator.services.mozilla.com/D269716 Diffstat:
36 files changed, 21 insertions(+), 57 deletions(-)
diff --git a/gfx/2d/BaseCoord.h b/gfx/2d/BaseCoord.h @@ -9,7 +9,6 @@ #include <ostream> -#include "mozilla/Attributes.h" #include "mozilla/MathAlgorithms.h" namespace mozilla::gfx { diff --git a/gfx/2d/ConicGradientEffectD2D1.h b/gfx/2d/ConicGradientEffectD2D1.h @@ -12,7 +12,6 @@ #include <d2d1effecthelpers.h> #include "2D.h" -#include "mozilla/Attributes.h" // {fa4e3246-be57-4052-8c8b-881cc3633287} DEFINE_GUID(CLSID_ConicGradientEffect, 0xfa4e3246, 0xbe57, 0x4052, 0x8c, 0x8b, diff --git a/gfx/2d/ExtendInputEffectD2D1.h b/gfx/2d/ExtendInputEffectD2D1.h @@ -12,7 +12,6 @@ #include <d2d1effecthelpers.h> #include "2D.h" -#include "mozilla/Attributes.h" // {97143DC6-CBC4-4DD4-A8BA-13342B0BA46D} DEFINE_GUID(CLSID_ExtendInputEffect, 0x5fb55c7c, 0xd795, 0x4ba3, 0xa9, 0x5c, diff --git a/gfx/2d/Quaternion.h b/gfx/2d/Quaternion.h @@ -10,7 +10,6 @@ #include "Types.h" #include <math.h> #include <ostream> -#include "mozilla/Attributes.h" #include "mozilla/DebugOnly.h" #include "mozilla/gfx/MatrixFwd.h" #include "mozilla/gfx/Point.h" diff --git a/gfx/2d/RadialGradientEffectD2D1.h b/gfx/2d/RadialGradientEffectD2D1.h @@ -12,7 +12,6 @@ #include <d2d1effecthelpers.h> #include "2D.h" -#include "mozilla/Attributes.h" // {97143DC6-CBC4-4DD4-A8BA-13342B0BA46D} DEFINE_GUID(CLSID_RadialGradientEffect, 0x97143dc6, 0xcbc4, 0x4dd4, 0xa8, 0xba, diff --git a/gfx/2d/ScaleFactor.h b/gfx/2d/ScaleFactor.h @@ -9,8 +9,6 @@ #include <ostream> -#include "mozilla/Attributes.h" - #include "gfxPoint.h" namespace mozilla { diff --git a/gfx/2d/ScaleFactors2D.h b/gfx/2d/ScaleFactors2D.h @@ -9,7 +9,6 @@ #include <ostream> -#include "mozilla/Attributes.h" #include "mozilla/FloatingPoint.h" #include "mozilla/gfx/ScaleFactor.h" #include "mozilla/gfx/Point.h" diff --git a/gfx/gl/GLBlitHelper.h b/gfx/gl/GLBlitHelper.h @@ -21,7 +21,6 @@ #include "nsString.h" #include "nsTString.h" #include "mozilla/ipc/IPCTypes.h" -#include "mozilla/Attributes.h" #include "mozilla/Maybe.h" #include "mozilla/gfx/MatrixFwd.h" #include "mozilla/gfx/Point.h" diff --git a/gfx/gl/GLReadTexImageHelper.h b/gfx/gl/GLReadTexImageHelper.h @@ -8,7 +8,6 @@ #define GLREADTEXIMAGEHELPER_H_ #include "GLContextTypes.h" -#include "mozilla/Attributes.h" #include "nsSize.h" #include "mozilla/RefPtr.h" #include "mozilla/gfx/MatrixFwd.h" diff --git a/gfx/gl/SharedSurfaceAndroidHardwareBuffer.h b/gfx/gl/SharedSurfaceAndroidHardwareBuffer.h @@ -6,7 +6,6 @@ #ifndef SHARED_SURFACE_ANDROID_HARDWARE_BUFFER_H_ #define SHARED_SURFACE_ANDROID_HARDWARE_BUFFER_H_ -#include "mozilla/Attributes.h" #include "mozilla/Mutex.h" #include "CompositorTypes.h" #include "SharedSurface.h" diff --git a/gfx/layers/apz/src/AndroidVelocityTracker.h b/gfx/layers/apz/src/AndroidVelocityTracker.h @@ -11,7 +11,6 @@ #include <cstdint> #include "Axis.h" -#include "mozilla/Attributes.h" #include "mozilla/Maybe.h" #include "nsTArray.h" diff --git a/gfx/layers/apz/src/Axis.cpp b/gfx/layers/apz/src/Axis.cpp @@ -13,7 +13,6 @@ #include "AsyncPanZoomController.h" // for AsyncPanZoomController #include "FrameMetrics.h" // for FrameMetrics #include "SimpleVelocityTracker.h" // for FrameMetrics -#include "mozilla/Attributes.h" // for final #include "mozilla/Preferences.h" // for Preferences #include "mozilla/gfx/Rect.h" // for RoundedIn #include "mozilla/layers/APZThreadUtils.h" // for AssertOnControllerThread diff --git a/gfx/layers/apz/test/gtest/APZTestCommon.h b/gfx/layers/apz/test/gtest/APZTestCommon.h @@ -15,7 +15,6 @@ #include "gtest/gtest.h" #include "gmock/gmock.h" -#include "mozilla/Attributes.h" #include "mozilla/layers/GeckoContentController.h" #include "mozilla/layers/CompositorBridgeParent.h" #include "mozilla/layers/DoubleTapToZoom.h" diff --git a/gfx/layers/client/CanvasClient.h b/gfx/layers/client/CanvasClient.h @@ -8,7 +8,6 @@ #define MOZILLA_GFX_CANVASCLIENT_H #include "mozilla/Assertions.h" // for MOZ_ASSERT, etc -#include "mozilla/Attributes.h" // for override #include "mozilla/RefPtr.h" // for RefPtr, already_AddRefed #include "mozilla/layers/CompositableClient.h" // for CompositableClient #include "mozilla/layers/CompositorTypes.h" // for TextureInfo, etc diff --git a/gfx/layers/client/ImageClient.h b/gfx/layers/client/ImageClient.h @@ -9,7 +9,6 @@ #include <stdint.h> // for uint32_t, uint64_t #include <sys/types.h> // for int32_t -#include "mozilla/Attributes.h" // for override #include "mozilla/RefPtr.h" // for RefPtr, already_AddRefed #include "mozilla/gfx/Types.h" // for SurfaceFormat #include "mozilla/layers/CompositableClient.h" // for CompositableClient diff --git a/gfx/layers/composite/CompositableHost.h b/gfx/layers/composite/CompositableHost.h @@ -11,7 +11,6 @@ #include <stdio.h> // for FILE #include "gfxRect.h" // for gfxRect #include "mozilla/Assertions.h" // for MOZ_ASSERT, etc -#include "mozilla/Attributes.h" // for override #include "mozilla/RefPtr.h" // for RefPtr, RefCounted, etc // #include "mozilla/gfx/MatrixFwd.h" // for Matrix4x4 #include "mozilla/gfx/Polygon.h" // for Polygon diff --git a/gfx/layers/ipc/CompositableTransactionParent.h b/gfx/layers/ipc/CompositableTransactionParent.h @@ -7,8 +7,7 @@ #ifndef MOZILLA_LAYERS_COMPOSITABLETRANSACTIONPARENT_H #define MOZILLA_LAYERS_COMPOSITABLETRANSACTIONPARENT_H -#include <vector> // for vector -#include "mozilla/Attributes.h" // for override +#include <vector> // for vector #include "mozilla/NotNull.h" #include "mozilla/layers/ISurfaceAllocator.h" // for ISurfaceAllocator #include "mozilla/layers/LayersMessages.h" // for EditReply, etc diff --git a/gfx/layers/ipc/CompositorBridgeChild.h b/gfx/layers/ipc/CompositorBridgeChild.h @@ -9,7 +9,6 @@ #include "base/basictypes.h" // for DISALLOW_EVIL_CONSTRUCTORS #include "mozilla/Assertions.h" // for MOZ_ASSERT_HELPER2 -#include "mozilla/Attributes.h" // for override #include "mozilla/Monitor.h" #include "mozilla/ipc/ProtocolUtils.h" #include "mozilla/layers/PCompositorBridgeChild.h" diff --git a/gfx/layers/ipc/CompositorManagerChild.h b/gfx/layers/ipc/CompositorManagerChild.h @@ -10,7 +10,6 @@ #include <stddef.h> // for size_t #include <stdint.h> // for uint32_t, uint64_t #include "mozilla/Atomics.h" -#include "mozilla/Attributes.h" // for override #include "mozilla/RefPtr.h" // for already_AddRefed #include "mozilla/StaticPtr.h" // for StaticRefPtr #include "mozilla/layers/CompositableForwarder.h" // for FwdTransactionCounter diff --git a/gfx/layers/ipc/CompositorManagerParent.h b/gfx/layers/ipc/CompositorManagerParent.h @@ -9,7 +9,6 @@ #include <map> #include <stdint.h> // for uint32_t -#include "mozilla/Attributes.h" // for override #include "mozilla/StaticPtr.h" // for StaticRefPtr #include "mozilla/StaticMonitor.h" // for StaticMonitor #include "mozilla/RefPtr.h" // for already_AddRefed diff --git a/gfx/layers/ipc/CompositorVsyncScheduler.h b/gfx/layers/ipc/CompositorVsyncScheduler.h @@ -9,11 +9,10 @@ #include <stdint.h> // for uint64_t -#include "mozilla/Attributes.h" // for override -#include "mozilla/Monitor.h" // for Monitor -#include "mozilla/RefPtr.h" // for RefPtr -#include "mozilla/TimeStamp.h" // for TimeStamp -#include "mozilla/gfx/Point.h" // for IntSize +#include "mozilla/Monitor.h" // for Monitor +#include "mozilla/RefPtr.h" // for RefPtr +#include "mozilla/TimeStamp.h" // for TimeStamp +#include "mozilla/gfx/Point.h" // for IntSize #include "mozilla/layers/SampleTime.h" #include "mozilla/webrender/webrender_ffi.h" #include "mozilla/VsyncDispatcher.h" diff --git a/gfx/layers/ipc/ImageBridgeParent.h b/gfx/layers/ipc/ImageBridgeParent.h @@ -11,7 +11,6 @@ #include <stdint.h> // for uint32_t, uint64_t #include "CompositableTransactionParent.h" #include "mozilla/Assertions.h" // for MOZ_ASSERT_HELPER2 -#include "mozilla/Attributes.h" // for override #include "mozilla/dom/ipc/IdType.h" #include "mozilla/ipc/ProtocolUtils.h" #include "mozilla/layers/CompositorThread.h" diff --git a/gfx/layers/ipc/SharedPlanarYCbCrImage.h b/gfx/layers/ipc/SharedPlanarYCbCrImage.h @@ -4,14 +4,13 @@ * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ -#include <stdint.h> // for uint8_t, uint32_t -#include "ImageContainer.h" // for PlanarYCbCrImage, etc -#include "mozilla/Attributes.h" // for override -#include "mozilla/RefPtr.h" // for RefPtr -#include "mozilla/ipc/Shmem.h" // for Shmem -#include "nsCOMPtr.h" // for already_AddRefed -#include "nsDebug.h" // for NS_WARNING -#include "nsISupportsImpl.h" // for MOZ_COUNT_CTOR +#include <stdint.h> // for uint8_t, uint32_t +#include "ImageContainer.h" // for PlanarYCbCrImage, etc +#include "mozilla/RefPtr.h" // for RefPtr +#include "mozilla/ipc/Shmem.h" // for Shmem +#include "nsCOMPtr.h" // for already_AddRefed +#include "nsDebug.h" // for NS_WARNING +#include "nsISupportsImpl.h" // for MOZ_COUNT_CTOR #ifndef MOZILLA_LAYERS_SHAREDPLANARYCBCRIMAGE_H # define MOZILLA_LAYERS_SHAREDPLANARYCBCRIMAGE_H diff --git a/gfx/layers/ipc/SharedRGBImage.h b/gfx/layers/ipc/SharedRGBImage.h @@ -12,11 +12,10 @@ #include "ImageContainer.h" // for ISharedImage, Image, etc #include "gfxTypes.h" -#include "mozilla/Attributes.h" // for override -#include "mozilla/RefPtr.h" // for RefPtr -#include "mozilla/gfx/Point.h" // for IntSize -#include "mozilla/gfx/Types.h" // for SurfaceFormat -#include "nsCOMPtr.h" // for already_AddRefed +#include "mozilla/RefPtr.h" // for RefPtr +#include "mozilla/gfx/Point.h" // for IntSize +#include "mozilla/gfx/Types.h" // for SurfaceFormat +#include "nsCOMPtr.h" // for already_AddRefed namespace mozilla { namespace layers { diff --git a/gfx/layers/ipc/SharedSurfacesChild.h b/gfx/layers/ipc/SharedSurfacesChild.h @@ -8,7 +8,6 @@ #define MOZILLA_GFX_SHAREDSURFACESCHILD_H #include <stdint.h> // for uint32_t, uint64_t -#include "mozilla/Attributes.h" // for override #include "mozilla/Maybe.h" // for Maybe #include "mozilla/RefPtr.h" // for already_AddRefed #include "mozilla/StaticPtr.h" // for StaticRefPtr diff --git a/gfx/layers/opengl/CompositingRenderTargetOGL.h b/gfx/layers/opengl/CompositingRenderTargetOGL.h @@ -10,7 +10,6 @@ #include "GLContextTypes.h" // for GLContext #include "GLDefs.h" // for GLenum, LOCAL_GL_FRAMEBUFFER, etc #include "mozilla/Assertions.h" // for MOZ_ASSERT, etc -#include "mozilla/Attributes.h" // for override #include "mozilla/RefPtr.h" // for RefPtr, already_AddRefed #include "mozilla/gfx/Point.h" // for IntSize, IntSizeTyped #include "mozilla/gfx/Types.h" // for SurfaceFormat, etc diff --git a/gfx/layers/opengl/CompositorOGL.h b/gfx/layers/opengl/CompositorOGL.h @@ -17,7 +17,6 @@ #include "OGLShaderConfig.h" // for ShaderConfigOGL #include "Units.h" // for ScreenPoint #include "mozilla/Assertions.h" // for MOZ_ASSERT, etc -#include "mozilla/Attributes.h" // for override, final #include "mozilla/RefPtr.h" // for already_AddRefed, RefPtr #include "mozilla/gfx/2D.h" // for DrawTarget #include "mozilla/gfx/BaseSize.h" // for BaseSize diff --git a/gfx/layers/opengl/TextureClientOGL.h b/gfx/layers/opengl/TextureClientOGL.h @@ -10,9 +10,8 @@ #include "GLContextTypes.h" // for SharedTextureHandle, etc #include "GLImages.h" #include "gfxTypes.h" -#include "mozilla/Attributes.h" // for override -#include "mozilla/gfx/Point.h" // for IntSize -#include "mozilla/gfx/Types.h" // for SurfaceFormat +#include "mozilla/gfx/Point.h" // for IntSize +#include "mozilla/gfx/Types.h" // for SurfaceFormat #include "mozilla/layers/CompositorTypes.h" #include "mozilla/layers/LayersSurfaces.h" // for SurfaceDescriptor #include "mozilla/layers/TextureClient.h" // for TextureClient, etc diff --git a/gfx/layers/opengl/TextureHostOGL.h b/gfx/layers/opengl/TextureHostOGL.h @@ -16,7 +16,6 @@ #include "gfxTypes.h" #include "mozilla/GfxMessageUtils.h" // for gfxContentType #include "mozilla/Assertions.h" // for MOZ_ASSERT, etc -#include "mozilla/Attributes.h" // for override #include "mozilla/RefPtr.h" // for RefPtr #include "mozilla/gfx/Matrix.h" // for Matrix4x4 #include "mozilla/gfx/Point.h" // for IntSize, IntPoint diff --git a/gfx/src/nsThebesFontEnumerator.h b/gfx/src/nsThebesFontEnumerator.h @@ -7,9 +7,8 @@ #ifndef _NSTHEBESFONTENUMERATOR_H_ #define _NSTHEBESFONTENUMERATOR_H_ -#include "mozilla/Attributes.h" // for final -#include "nsIFontEnumerator.h" // for NS_DECL_NSIFONTENUMERATOR, etc -#include "nsISupports.h" // for NS_DECL_ISUPPORTS +#include "nsIFontEnumerator.h" // for NS_DECL_NSIFONTENUMERATOR, etc +#include "nsISupports.h" // for NS_DECL_ISUPPORTS class nsThebesFontEnumerator final : public nsIFontEnumerator { ~nsThebesFontEnumerator() = default; diff --git a/gfx/thebes/gfxASurface.cpp b/gfx/thebes/gfxASurface.cpp @@ -5,7 +5,6 @@ #include "nsIMemoryReporter.h" #include "mozilla/Base64.h" -#include "mozilla/Attributes.h" #include "mozilla/MemoryReporting.h" #include "nsISupportsImpl.h" #include "mozilla/gfx/2D.h" diff --git a/gfx/thebes/gfxFontMissingGlyphs.h b/gfx/thebes/gfxFontMissingGlyphs.h @@ -6,7 +6,6 @@ #ifndef GFX_FONTMISSINGGLYPHS_H #define GFX_FONTMISSINGGLYPHS_H -#include "mozilla/Attributes.h" #include "mozilla/gfx/MatrixFwd.h" #include "mozilla/gfx/Rect.h" diff --git a/gfx/thebes/gfxPlatformFontList.cpp b/gfx/thebes/gfxPlatformFontList.cpp @@ -24,7 +24,6 @@ #include "nsXULAppAPI.h" #include "mozilla/AppShutdown.h" -#include "mozilla/Attributes.h" #include "mozilla/BinarySearch.h" #include "mozilla/Likely.h" #include "mozilla/MemoryReporting.h" diff --git a/gfx/thebes/gfxPlatformFontList.h b/gfx/thebes/gfxPlatformFontList.h @@ -21,7 +21,6 @@ #include "base/process.h" #include "nsIMemoryReporter.h" -#include "mozilla/Attributes.h" #include "mozilla/EnumeratedArray.h" #include "mozilla/FontPropertyTypes.h" #include "mozilla/MemoryReporting.h" diff --git a/gfx/thebes/gfxQuartzNativeDrawing.h b/gfx/thebes/gfxQuartzNativeDrawing.h @@ -6,8 +6,6 @@ #ifndef _GFXQUARTZNATIVEDRAWING_H_ #define _GFXQUARTZNATIVEDRAWING_H_ -#include "mozilla/Attributes.h" - #include "mozilla/gfx/2D.h" #include "mozilla/gfx/BorrowedContext.h" #include "mozilla/RefPtr.h" diff --git a/gfx/thebes/gfxTypes.h b/gfx/thebes/gfxTypes.h @@ -7,6 +7,7 @@ #define GFX_TYPES_H #include <stdint.h> +#include "mozilla/Attributes.h" #include "mozilla/TypedEnumBits.h" namespace mozilla {