tor-browser

commit f35a834af9f79dbcea01713ec41a2cb31e9ed6c8
parent 8f159297b4120b7494d1fec3c9375777940f4277
Author: clairehurst <clairehurst@torproject.org>
Date:   Wed, 11 Feb 2026 16:57:33 -0700

TB 31951: [Android] Disable Scroll to hide toolbar

Diffstat:
M
mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/CustomizationFragment.kt
 | 
7
-------
M
mobile/android/fenix/app/src/main/java/org/mozilla/fenix/utils/Settings.kt
 | 
5
+----
M
mobile/android/fenix/app/src/main/res/values/preference_keys.xml
 | 
1
-
M
mobile/android/fenix/app/src/main/res/xml/customization_preferences.xml
 | 
3
---

4 files changed, 1 insertion(+), 15 deletions(-)
diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/CustomizationFragment.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/CustomizationFragment.kt
@@ -256,10 +256,6 @@ class CustomizationFragment : PreferenceFragmentCompat() {
             isChecked = context.settings().isPullToRefreshEnabledInBrowser
             onPreferenceChangeListener = SharedPreferenceUpdater()
         }
-        requirePreference<SwitchPreference>(R.string.pref_key_dynamic_toolbar).apply {
-            isChecked = context.settings().isDynamicToolbarEnabled
-            onPreferenceChangeListener = SharedPreferenceUpdater()
-        }
         requirePreference<SwitchPreference>(R.string.pref_key_swipe_toolbar_switch_tabs).apply {
             isChecked = context.settings().isSwipeToolbarToSwitchTabsEnabled
             isVisible = isSwipeToolbarToSwitchTabsVisible
@@ -278,9 +274,6 @@ class CustomizationFragment : PreferenceFragmentCompat() {
             resources.getString(R.string.pref_key_website_pull_to_refresh) -> {
                 PullToRefreshInBrowser.enabled.set(requireContext().settings().isPullToRefreshEnabledInBrowser)
             }
-            resources.getString(R.string.pref_key_dynamic_toolbar) -> {
-                CustomizationSettings.dynamicToolbar.set(requireContext().settings().isDynamicToolbarEnabled)
-            }
         }
         return super.onPreferenceTreeClick(preference)
     }
diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/utils/Settings.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/utils/Settings.kt
@@ -2033,10 +2033,7 @@ class Settings(
                 (isTabStripEligible(appContext) || FxNimbus.features.tabStrip.value().allowOnAllDevices),
     )
 
-    var isDynamicToolbarEnabled by booleanPreference(
-        appContext.getPreferenceKey(R.string.pref_key_dynamic_toolbar),
-        default = true,
-    )
+    var isDynamicToolbarEnabled = false
 
     var useNewDynamicToolbarBehaviour by booleanPreference(
         appContext.getPreferenceKey(R.string.pref_key_use_scroll_data_for_dynamic_toolbar),
diff --git a/mobile/android/fenix/app/src/main/res/values/preference_keys.xml b/mobile/android/fenix/app/src/main/res/values/preference_keys.xml
@@ -203,7 +203,6 @@
     <string name="pref_key_website_pull_to_refresh" translatable="false">pref_key_website_pull_to_refresh</string>
     <string name="pref_key_tab_strip_show" translatable="false">pref_key_tab_strip_show</string>
     <string name="pref_key_tab_strip_message" translatable="false">pref_key_tab_strip_message</string>
-    <string name="pref_key_dynamic_toolbar" translatable="false">pref_key_dynamic_toolbar</string>
     <string name="pref_key_use_scroll_data_for_dynamic_toolbar" translatable="false">pref_key_use_scroll_data_for_dynamic_toolbar</string>
     <string name="pref_key_swipe_toolbar_switch_tabs" translatable="false">pref_key_swipe_toolbar_switch_tabs</string>
     <string name="pref_key_swipe_toolbar_show_tabs" translatable="false">pref_key_swipe_toolbar_show_tabs</string>
diff --git a/mobile/android/fenix/app/src/main/res/xml/customization_preferences.xml b/mobile/android/fenix/app/src/main/res/xml/customization_preferences.xml
@@ -99,9 +99,6 @@
             android:title="@string/preference_gestures_website_pull_to_refresh"
             app:isPreferenceVisible="false" />
         <androidx.preference.SwitchPreference
-            android:key="@string/pref_key_dynamic_toolbar"
-            android:title="@string/preference_gestures_dynamic_toolbar" />
-        <androidx.preference.SwitchPreference
             android:key="@string/pref_key_swipe_toolbar_switch_tabs"
             android:title="@string/preference_gestures_swipe_toolbar_switch_tabs_2" />
         <androidx.preference.SwitchPreference