tor-browser

commit f26b1e2303204ff90c2304e96b108c7f1e1ee74f
parent 725f45a58eaf4ee23ff8c5d3773b2a675441220c
Author: Julian Descottes <jdescottes@mozilla.com>
Date:   Thu, 13 Nov 2025 14:52:00 +0000

Bug 1855045 - [remote] Add basic support for file unhandledPromptBehavior in BiDi and geckodriver r=geckodriver-reviewers,Sasha

Differential Revision: https://phabricator.services.mozilla.com/D272311

Diffstat:
M
remote/shared/webdriver/UserPromptHandler.sys.mjs
 | 
2
++
D
testing/web-platform/meta/webdriver/tests/bidi/session/capabilities/unhandled_prompt_behavior/file/accept.py.ini
 | 
4
----
D
testing/web-platform/meta/webdriver/tests/bidi/session/capabilities/unhandled_prompt_behavior/file/dismiss.py.ini
 | 
4
----
M
testing/web-platform/meta/webdriver/tests/bidi/session/capabilities/unhandled_prompt_behavior/file/ignore.py.ini
 | 
2
+-
M
testing/webdriver/src/capabilities.rs
 | 
3
++-

5 files changed, 5 insertions(+), 10 deletions(-)
diff --git a/remote/shared/webdriver/UserPromptHandler.sys.mjs b/remote/shared/webdriver/UserPromptHandler.sys.mjs
@@ -65,6 +65,8 @@ export const PromptTypes = {
   // specifying the unhandlePromptBehavior capability with a map containing a
   // "default" entry. See FALLBACK_DEFAULT_PROMPT_TYPE.
   Default: "default",
+  // A file picker dialog
+  File: "file",
   // A simple prompt dialog
   Prompt: "prompt",
 };
diff --git a/testing/web-platform/meta/webdriver/tests/bidi/session/capabilities/unhandled_prompt_behavior/file/accept.py.ini b/testing/web-platform/meta/webdriver/tests/bidi/session/capabilities/unhandled_prompt_behavior/file/accept.py.ini
@@ -1,4 +0,0 @@
-[accept.py]
-  [test_file_accept]
-    bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1999693
-    expected: ERROR
diff --git a/testing/web-platform/meta/webdriver/tests/bidi/session/capabilities/unhandled_prompt_behavior/file/dismiss.py.ini b/testing/web-platform/meta/webdriver/tests/bidi/session/capabilities/unhandled_prompt_behavior/file/dismiss.py.ini
@@ -1,4 +0,0 @@
-[dismiss.py]
-  [test_file_dismiss]
-    bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1999693
-    expected: ERROR
diff --git a/testing/web-platform/meta/webdriver/tests/bidi/session/capabilities/unhandled_prompt_behavior/file/ignore.py.ini b/testing/web-platform/meta/webdriver/tests/bidi/session/capabilities/unhandled_prompt_behavior/file/ignore.py.ini
@@ -13,4 +13,4 @@
 
   [test_file_ignore]
     bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1999693
-    expected: ERROR
+    expected: FAIL
diff --git a/testing/webdriver/src/capabilities.rs b/testing/webdriver/src/capabilities.rs
@@ -424,6 +424,7 @@ impl SpecNewSessionParameters {
                         | x @ "beforeUnload"
                         | x @ "confirm"
                         | x @ "default"
+                        | x @ "file"
                         | x @ "prompt" => {
                             let behavior = try_opt!(
                                 value.as_str(),
@@ -756,7 +757,7 @@ mod tests {
         assert!(validate_prompt_behavior(json!("foo")).is_err());
 
         // capability as object
-        let types = ["alert", "beforeUnload", "confirm", "default", "prompt"];
+        let types = ["alert", "beforeUnload", "confirm", "default", "file", "prompt"];
         let handlers = [
             "accept",
             "accept and notify",