tor-browser

commit e9790fa9ac1ce7e43b60fb9d4586080d0866bc1c
parent d5b61ae19884f6ae1fa4714c747876a8905fca5d
Author: Jonathan Kew <jkew@mozilla.com>
Date:   Thu, 11 Dec 2025 21:59:35 +0000

Bug 1959738 - part 3 - Add a few SanitizeFileName tests with unpaired surrogates. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D274485

Diffstat:
M
uriloader/exthandler/tests/unit/test_filename_sanitize.js
 | 
36
++++++++++++++++++++++++++++++++++++

1 file changed, 36 insertions(+), 0 deletions(-)
diff --git a/uriloader/exthandler/tests/unit/test_filename_sanitize.js b/uriloader/exthandler/tests/unit/test_filename_sanitize.js
@@ -68,6 +68,10 @@ add_task(async function validate_filename_method() {
     "whit\u180ee.png"
   );
   Assert.equal(checkFilename("簡単簡単簡単", 0), "簡単簡単簡単.png");
+  Assert.equal(
+    checkFilename("\u3000簡単\u3000\u3000簡単簡単\u3000\u3000.png\u3000", 0),
+    "簡単\u3000簡単簡単\u3000.png"
+  );
   Assert.equal(checkFilename(" happy\u061c\u2069.png", 0), "happy__.png");
   Assert.equal(
     checkFilename("12345678".repeat(30) + "abcdefghijk.png", 0),
@@ -216,6 +220,26 @@ add_task(async function validate_filename_method() {
   Assert.equal(checkFilename("test😀", 0, ""), "test😀");
   Assert.equal(checkFilename("test😀😀", 0, ""), "test😀😀");
 
+  // Some examples with unpaired surrogate code units.
+  Assert.equal(
+    checkFilename(
+      "file\uD800name with <unpaired surrogate> and invalid chars.png",
+      0
+    ),
+    "file\uFFFDname with _unpaired surrogate_ and invalid chars.png"
+  );
+  Assert.equal(
+    checkFilename(
+      "name with <unpaired surrogate> in.exten\uDFFFsion",
+      mimeService.VALIDATE_SANITIZE_ONLY
+    ),
+    "name with _unpaired surrogate_ in.exten\uFFFDsion"
+  );
+  Assert.equal(
+    checkFilename("." + "\uDC00\uDC01".repeat(4) + repeatStr, 0),
+    "\uFFFD".repeat(8) + repeatStr.substring(0, 224) + ".png"
+  );
+
   // Now check some media types
   Assert.equal(
     mimeService.validateFileNameForSaving("video.ogg", "video/ogg", 0),
@@ -296,6 +320,18 @@ add_task(async function validate_filename_method() {
     "very long filename with extension"
   );
 
+  // Trailing ideographic spaces left at the truncation position should be trimmed.
+  Assert.equal(
+    mimeService.validateFileNameForSaving(
+      "라이브9.9만 시청컬처렐 다이제스티브 3박스 - 3박스 더 (뚱랑이 굿즈 증정) - 선물용 쇼핑백 2장컬처렐 다이제스티브 3박스 - 3박스 더 (뚱랑이 굿즈 증정) - 선물용\u3000\u3000\u3000\u3000\u3000.등-유산균-컬처렐-특가!",
+      "text/unknown",
+      mimeService.VALIDATE_SANITIZE_ONLY |
+        mimeService.VALIDATE_DONT_COLLAPSE_WHITESPACE
+    ),
+    "라이브9.9만 시청컬처렐 다이제스티브 3박스 - 3박스 더 (뚱랑이 굿즈 증정) - 선물용 쇼핑백 2장컬처렐 다이제스티브 3박스 - 3박스 더 (뚱랑이 굿즈 증정) - 선물용.등-유산균-컬처렐-특가!",
+    "very long filename with extension truncated among spaces"
+  );
+
   // This filename has a very long extension, almost the entire filename.
   Assert.equal(
     mimeService.validateFileNameForSaving(