tor-browser

commit e6e6512ca523a7bfd99af4745d222de4d7f16986
parent ba6019b1c2cb781f9717bb185729dc0579ccc0c5
Author: Marcin Koziński <mkozinski@mozilla.com>
Date:   Wed, 12 Nov 2025 10:31:45 +0000

Bug 1998628 - Part 3: Enable custom prompt by default, keep the flag to control only criteria r=android-reviewers,twhite

Differential Revision: https://phabricator.services.mozilla.com/D271575

Diffstat:
M
mobile/android/fenix/app/nimbus.fml.yaml
 | 
4
++--
M
mobile/android/fenix/app/src/main/java/org/mozilla/fenix/reviewprompt/ReviewPromptMiddleware.kt
 | 
10
+++-------
M
mobile/android/fenix/app/src/test/java/org/mozilla/fenix/reviewprompt/ReviewPromptMiddlewareTest.kt
 | 
2
+-

3 files changed, 6 insertions(+), 10 deletions(-)
diff --git a/mobile/android/fenix/app/nimbus.fml.yaml b/mobile/android/fenix/app/nimbus.fml.yaml
@@ -990,10 +990,10 @@ features:
         default: false
 
   custom-review-prompt:
-    description: Feature that controls the Play store in-app custom review prompt.
+    description: Feature that controls the Play store review prompt.
     variables:
       enabled:
-        description: Whether or not to enable the custom review prompt.
+        description: Whether or not to enable the new trigger criteria.
         type: Boolean
         default: false
 
diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/reviewprompt/ReviewPromptMiddleware.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/reviewprompt/ReviewPromptMiddleware.kt
@@ -119,14 +119,10 @@ class ReviewPromptMiddleware(
         }
 
         if (shouldShowPrompt) {
-            if (!isReviewPromptFeatureEnabled()) {
-                context.dispatch(ShowPlayStorePrompt)
+            if (isTelemetryEnabled()) {
+                context.dispatch(ShowCustomReviewPrompt)
             } else {
-                if (isTelemetryEnabled()) {
-                    context.dispatch(ShowCustomReviewPrompt)
-                } else {
-                    context.dispatch(ShowPlayStorePrompt)
-                }
+                context.dispatch(ShowPlayStorePrompt)
             }
         } else {
             context.dispatch(DoNotShowReviewPrompt)
diff --git a/mobile/android/fenix/app/src/test/java/org/mozilla/fenix/reviewprompt/ReviewPromptMiddlewareTest.kt b/mobile/android/fenix/app/src/test/java/org/mozilla/fenix/reviewprompt/ReviewPromptMiddlewareTest.kt
@@ -274,7 +274,7 @@ class ReviewPromptMiddlewareTest {
         store.dispatch(ReviewPromptAction.CheckIfEligibleForReviewPrompt).joinBlocking()
 
         assertEquals(
-            AppState(reviewPrompt = ReviewPromptState.Eligible(Type.PlayStore)),
+            AppState(reviewPrompt = ReviewPromptState.Eligible(Type.Custom)),
             store.state,
         )
     }