tor-browser

commit e68671efd8c8e76073e6a9e5c61afad383b62ce1
parent 4ed02af89a7c800a28433902a1ed953dd761714f
Author: Vincent Hilla <vhilla@mozilla.com>
Date:   Wed, 26 Nov 2025 13:30:30 +0000

Bug 2001934 - Fix Puppeteer Page.goto timeout for 204 page. r=whimboo

Differential Revision: https://phabricator.services.mozilla.com/D273795

Diffstat:
M
remote/shared/Navigate.sys.mjs
 | 
15
---------------
M
remote/test/puppeteer/test/TestExpectations.json
 | 
7
-------

2 files changed, 0 insertions(+), 22 deletions(-)
diff --git a/remote/shared/Navigate.sys.mjs b/remote/shared/Navigate.sys.mjs
@@ -269,11 +269,6 @@ export class ProgressListener {
     return this.#webProgress.browsingContext.currentWindowGlobal.documentURI;
   }
 
-  get isInitialDocument() {
-    return this.#webProgress.browsingContext.currentWindowGlobal
-      .isInitialDocument;
-  }
-
   get isLoadingDocument() {
     return this.#webProgress.isLoadingDocument;
   }
@@ -342,16 +337,6 @@ export class ProgressListener {
             return;
           }
 
-          // Handle an aborted navigation. While for an initial document another
-          // navigation to the real document will happen it's not the case for
-          // normal documents. Here we need to stop the listener immediately.
-          if (status == Cr.NS_BINDING_ABORTED && this.isInitialDocument) {
-            this.#trace(
-              "Ignore aborted navigation error to the initial document."
-            );
-            return;
-          }
-
           this.stop({ error: new lazy.NavigationError(errorName, status) });
           return;
         }
diff --git a/remote/test/puppeteer/test/TestExpectations.json b/remote/test/puppeteer/test/TestExpectations.json
@@ -1687,12 +1687,5 @@
     "parameters": ["cdp", "chrome", "chrome-headless-shell"],
     "expectations": ["FAIL", "PASS"],
     "comment": "TODO: add a comment explaining why this expectation is required (include links to issues)"
-  },
-  {
-    "testIdPattern": "[navigation.spec] navigation Page.goto should fail when server returns 204",
-    "platforms": [ "darwin", "linux", "win32" ],
-    "parameters": [ "firefox", "webDriverBiDi" ],
-    "expectations": [ "TIMEOUT" ],
-    "comment": "See bug 2001934"
   }
 ]