tor-browser

commit e35e354afce1c4dddacc3616b234ba69f85f0224
parent da267a32cf1c6ce33e4221b82c1bace0facd16e1
Author: Erik Nordin <enordin@mozilla.com>
Date:   Fri, 14 Nov 2025 14:50:43 +0000

Bug 1987770 - Revise SelectTranslations Lexical Shortlist Test r=translations-reviewers,gregtatum

This patch updates the SelectTranslationsPanel test that
flips the lexical shortlist pref to use the auto-download
from Remote Settings testing option.

Differential Revision: https://phabricator.services.mozilla.com/D271485

Diffstat:
M
browser/components/translations/tests/browser/browser_translations_select_panel_flip_lexical_shortlist.js
 | 
10
++++------

1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/browser/components/translations/tests/browser/browser_translations_select_panel_flip_lexical_shortlist.js b/browser/components/translations/tests/browser/browser_translations_select_panel_flip_lexical_shortlist.js
@@ -11,13 +11,14 @@
  */
 add_task(
   async function test_select_translations_panel_lexical_shortlist_starting_false() {
-    const { cleanup, runInPage, resolveDownloads } = await loadTestPage({
+    const { cleanup, runInPage } = await loadTestPage({
       page: SELECT_TEST_PAGE_URL,
       languagePairs: LANGUAGE_PAIRS,
       prefs: [
         ["browser.translations.select.enable", true],
         ["browser.translations.useLexicalShortlist", false],
       ],
+      autoDownloadFromRemoteSettings: true,
     });
 
     await SelectTranslationsTestUtils.openPanel(runInPage, {
@@ -25,7 +26,6 @@ add_task(
       openAtFrenchSentence: true,
       expectedFromLanguage: "fr",
       expectedToLanguage: "en",
-      downloadHandler: resolveDownloads,
       onOpenPanel: SelectTranslationsTestUtils.assertPanelViewTranslated,
     });
 
@@ -43,7 +43,6 @@ add_task(
       openAtFrenchSentence: true,
       expectedFromLanguage: "fr",
       expectedToLanguage: "en",
-      downloadHandler: resolveDownloads,
       onOpenPanel: SelectTranslationsTestUtils.assertPanelViewTranslated,
     });
 
@@ -61,13 +60,14 @@ add_task(
  */
 add_task(
   async function test_select_translations_panel_lexical_shortlist_starting_true() {
-    const { cleanup, runInPage, resolveDownloads } = await loadTestPage({
+    const { cleanup, runInPage } = await loadTestPage({
       page: SELECT_TEST_PAGE_URL,
       languagePairs: LANGUAGE_PAIRS,
       prefs: [
         ["browser.translations.select.enable", true],
         ["browser.translations.useLexicalShortlist", true],
       ],
+      autoDownloadFromRemoteSettings: true,
     });
 
     await SelectTranslationsTestUtils.openPanel(runInPage, {
@@ -75,7 +75,6 @@ add_task(
       openAtFrenchSentence: true,
       expectedFromLanguage: "fr",
       expectedToLanguage: "en",
-      downloadHandler: resolveDownloads,
       onOpenPanel: SelectTranslationsTestUtils.assertPanelViewTranslated,
     });
 
@@ -93,7 +92,6 @@ add_task(
       openAtFrenchSentence: true,
       expectedFromLanguage: "fr",
       expectedToLanguage: "en",
-      downloadHandler: resolveDownloads,
       onOpenPanel: SelectTranslationsTestUtils.assertPanelViewTranslated,
     });