tor-browser

The Tor Browser
git clone https://git.dasho.dev/tor-browser.git
Log | Files | Refs | README | LICENSE

commit df2fae2a76c1635475ac8b69bd1144d3205a0d13
parent b45546efa9944758bef621dd675e1c12319b4cd6
Author: gela <gela.malekpour@gmail.com>
Date:   Fri,  3 Oct 2025 21:08:43 +0000

Bug 1991998 - Add telemetry to snackbar and undo button for removing a bookmark [part 2] r=android-reviewers,skhan

Differential Revision: https://phabricator.services.mozilla.com/D267098

Diffstat:
Mmobile/android/fenix/app/metrics.yaml | 32++++++++++++++++++++++++++++++++
Mmobile/android/fenix/app/src/main/java/org/mozilla/fenix/bookmarks/BookmarksScreen.kt | 8+++++++-
2 files changed, 39 insertions(+), 1 deletion(-)

diff --git a/mobile/android/fenix/app/metrics.yaml b/mobile/android/fenix/app/metrics.yaml @@ -4853,6 +4853,38 @@ bookmarks_management: metadata: tags: - Bookmarks + delete_snackbar_shown: + type: event + description: | + A delete snackbar was shown after a single bookmark deletion. + bugs: + - https://bugzilla.mozilla.org/show_bug.cgi?id=1991998 + data_reviews: + - https://phabricator.services.mozilla.com/D267098 + data_sensitivity: + - interaction + notification_emails: + - android-probes@mozilla.com + expires: never + metadata: + tags: + - Bookmarks + delete_snackbar_undo_clicked: + type: event + description: | + The user clicked the undo button in a bookmarks delete snackbar. + bugs: + - https://bugzilla.mozilla.org/show_bug.cgi?id=1991998 + data_reviews: + - https://phabricator.services.mozilla.com/D267098 + data_sensitivity: + - interaction + notification_emails: + - android-probes@mozilla.com + expires: never + metadata: + tags: + - Bookmarks activation: identifier: diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/bookmarks/BookmarksScreen.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/bookmarks/BookmarksScreen.kt @@ -114,6 +114,8 @@ import mozilla.components.concept.base.profiler.Profiler import mozilla.components.lib.state.ext.observeAsComposableState import mozilla.components.lib.state.ext.observeAsState import mozilla.components.support.ktx.android.view.hideKeyboard +import mozilla.telemetry.glean.private.NoExtras +import org.mozilla.fenix.GleanMetrics.BookmarksManagement import org.mozilla.fenix.R import org.mozilla.fenix.bookmarks.BookmarksTestTag.BOOKMARK_TOOLBAR import org.mozilla.fenix.bookmarks.BookmarksTestTag.EDIT_BOOKMARK_ITEM_TITLE_TEXT_FIELD @@ -277,10 +279,14 @@ private fun BookmarksList( when (state.bookmarksSnackbarState) { BookmarksSnackbarState.None -> return@LaunchedEffect is BookmarksSnackbarState.UndoDeletion -> scope.launch { + BookmarksManagement.deleteSnackbarShown.record(NoExtras()) snackbarHostState.displaySnackbar( message = snackbarMessage, actionLabel = snackbarActionLabel, - onActionPerformed = { store.dispatch(SnackbarAction.Undo) }, + onActionPerformed = { + store.dispatch(SnackbarAction.Undo) + BookmarksManagement.deleteSnackbarUndoClicked.record(NoExtras()) + }, onDismissPerformed = { store.dispatch(SnackbarAction.Dismissed) }, ) }