commit d60d3bab462877768bc419845971a275f1df03bb
parent 811cc5be15e93c2b65bbb64e68bf34915f8b5d19
Author: Mike Conley <mconley@mozilla.com>
Date: Wed, 22 Oct 2025 14:09:28 +0000
Bug 1994495 - Remove TelemetryFeed shims for 143 now that 144 has hit release. r=home-newtab-reviewers,nbarrett
Differential Revision: https://phabricator.services.mozilla.com/D269470
Diffstat:
1 file changed, 34 insertions(+), 67 deletions(-)
diff --git a/browser/extensions/newtab/lib/TelemetryFeed.sys.mjs b/browser/extensions/newtab/lib/TelemetryFeed.sys.mjs
@@ -383,25 +383,6 @@ export class TelemetryFeed {
}
/**
- * Removes fields for users with a 143 major version of firefox
- * This should be removed once 143 lands in release
- * @param {*} pingDict
- * @returns {*} possibly redacted pingDict
- */
- redactPingFor143(pingDict) {
- const isMajor143 =
- Services.vc.compare(AppConstants.MOZ_APP_VERSION, "143.0a1") >= 0 &&
- Services.vc.compare(AppConstants.MOZ_APP_VERSION, "144.0a1") < 0;
- if (isMajor143) {
- // eslint-disable-next-line no-unused-vars
- const { is_pinned, layout_name, visible_topsites, ...rest } = pingDict;
- return rest;
- }
-
- return pingDict;
- }
-
- /**
* Removes fields that link to any user content preference.
* Redactions only occur if the appropriate pref is enabled.
* @param {*} pingDict Input dictionary
@@ -646,16 +627,14 @@ export class TelemetryFeed {
`${source}_${legacyTelemetryPosition}`
].add(1);
if (session) {
- Glean.topsites.impression.record(
- this.redactPingFor143({
- advertiser_name,
- tile_id,
- newtab_visit_id: session.session_id,
- is_sponsored: true,
- position,
- visible_topsites,
- })
- );
+ Glean.topsites.impression.record({
+ advertiser_name,
+ tile_id,
+ newtab_visit_id: session.session_id,
+ is_sponsored: true,
+ position,
+ visible_topsites,
+ });
}
} else if (type === "click") {
pingType = "topsites-click";
@@ -663,16 +642,14 @@ export class TelemetryFeed {
`${source}_${legacyTelemetryPosition}`
].add(1);
if (session) {
- Glean.topsites.click.record(
- this.redactPingFor143({
- advertiser_name,
- tile_id,
- newtab_visit_id: session.session_id,
- is_sponsored: true,
- position,
- visible_topsites,
- })
- );
+ Glean.topsites.click.record({
+ advertiser_name,
+ tile_id,
+ newtab_visit_id: session.session_id,
+ is_sponsored: true,
+ position,
+ visible_topsites,
+ });
}
} else {
console.error("Unknown ping type for sponsored TopSites impression");
@@ -708,27 +685,23 @@ export class TelemetryFeed {
switch (action.data?.type) {
case "impression":
- Glean.topsites.impression.record(
- this.redactPingFor143({
- newtab_visit_id: session.session_id,
- is_sponsored: false,
- position: action.data.position,
- is_pinned: !!action.data.isPinned,
- visible_topsites,
- })
- );
+ Glean.topsites.impression.record({
+ newtab_visit_id: session.session_id,
+ is_sponsored: false,
+ position: action.data.position,
+ is_pinned: !!action.data.isPinned,
+ visible_topsites,
+ });
break;
case "click":
- Glean.topsites.click.record(
- this.redactPingFor143({
- newtab_visit_id: session.session_id,
- is_sponsored: false,
- position: action.data.position,
- is_pinned: !!action.data.isPinned,
- visible_topsites,
- })
- );
+ Glean.topsites.click.record({
+ newtab_visit_id: session.session_id,
+ is_sponsored: false,
+ position: action.data.position,
+ is_pinned: !!action.data.isPinned,
+ visible_topsites,
+ });
break;
default:
@@ -964,10 +937,7 @@ export class TelemetryFeed {
}),
};
Glean.pocket.click.record({
- ...this.redactNewTabPing(
- this.redactPingFor143(gleanData),
- is_sponsored
- ),
+ ...this.redactNewTabPing(gleanData, is_sponsored),
newtab_visit_id: session.session_id,
});
if (this.privatePingEnabled) {
@@ -1644,7 +1614,7 @@ export class TelemetryFeed {
break;
case "CARD_SECTION_IMPRESSION":
{
- const gleanData = this.redactPingFor143({
+ const gleanData = {
newtab_visit_id: session.session_id,
section,
section_position,
@@ -1652,7 +1622,7 @@ export class TelemetryFeed {
? { is_section_followed: !!is_section_followed }
: {}),
layout_name,
- });
+ };
Glean.newtab.sectionsImpression.record(
this.redactNewTabPing(gleanData)
);
@@ -2026,10 +1996,7 @@ export class TelemetryFeed {
}),
};
Glean.pocket.impression.record({
- ...this.redactNewTabPing(
- this.redactPingFor143(gleanData),
- is_sponsored
- ),
+ ...this.redactNewTabPing(gleanData, is_sponsored),
newtab_visit_id: session.session_id,
});
if (this.privatePingEnabled) {
