tor-browser

The Tor Browser
git clone https://git.dasho.dev/tor-browser.git
Log | Files | Refs | README | LICENSE

commit d322e7b2cab8f126487317dee907cd03437f3201
parent a22f1d8e473c257fd787a82e79d6f8fee2b232a1
Author: Ryan VanderMeulen <rvandermeulen@mozilla.com>
Date:   Thu, 20 Nov 2025 17:43:37 +0000

Bug 2001376 - Refresh lint baselines. r=android-reviewers,007

Differential Revision: https://phabricator.services.mozilla.com/D273446

Diffstat:
Mmobile/android/fenix/app/lint-baseline.xml | 605++-----------------------------------------------------------------------------
Mmobile/android/focus-android/app/lint-baseline.xml | 17++++++++++++++---
2 files changed, 23 insertions(+), 599 deletions(-)

diff --git a/mobile/android/fenix/app/lint-baseline.xml b/mobile/android/fenix/app/lint-baseline.xml @@ -2,369 +2,6 @@ <issues format="6" by="lint 8.13.0" type="baseline" client="gradle" dependencies="false" name="AGP (8.13.0)" variant="all" version="8.13.0"> <issue - id="NoStaticMocking" - message="Usage of MockK&apos;s &apos;mockkStatic&apos; for static mocking is discouraged. Refactor to use dependency injection." - errorLine1=" mockkStatic(&quot;org.mozilla.fenix.ext.FragmentKt&quot;)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt" - line="77" - column="9"/> - </issue> - - <issue - id="NoStaticMocking" - message="Usage of MockK&apos;s &apos;unmockkStatic&apos; for static mocking is discouraged. Refactor to use dependency injection." - errorLine1=" unmockkStatic(&quot;org.mozilla.fenix.ext.FragmentKt&quot;)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt" - line="114" - column="9"/> - </issue> - - <issue - id="NoStaticMocking" - message="Usage of MockK&apos;s &apos;mockkStatic&apos; for static mocking is discouraged. Refactor to use dependency injection." - errorLine1=" mockkStatic(AppCompatResources::class)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt" - line="348" - column="9"/> - </issue> - - <issue - id="NoStaticMocking" - message="Usage of MockK&apos;s &apos;unmockkStatic&apos; for static mocking is discouraged. Refactor to use dependency injection." - errorLine1=" unmockkStatic(AppCompatResources::class)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt" - line="357" - column="9"/> - </issue> - - <issue - id="NoStaticMocking" - message="Usage of MockK&apos;s &apos;mockkStatic&apos; for static mocking is discouraged. Refactor to use dependency injection." - errorLine1=" mockkStatic(AppCompatResources::class)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt" - line="370" - column="9"/> - </issue> - - <issue - id="NoStaticMocking" - message="Usage of MockK&apos;s &apos;unmockkStatic&apos; for static mocking is discouraged. Refactor to use dependency injection." - errorLine1=" unmockkStatic(AppCompatResources::class)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt" - line="378" - column="9"/> - </issue> - - <issue - id="NoStaticMocking" - message="Usage of MockK&apos;s &apos;mockkStatic&apos; for static mocking is discouraged. Refactor to use dependency injection." - errorLine1=" mockkStatic(AppCompatResources::class)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt" - line="395" - column="9"/> - </issue> - - <issue - id="NoStaticMocking" - message="Usage of MockK&apos;s &apos;unmockkStatic&apos; for static mocking is discouraged. Refactor to use dependency injection." - errorLine1=" unmockkStatic(AppCompatResources::class)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt" - line="407" - column="9"/> - </issue> - - <issue - id="NoStaticMocking" - message="Usage of MockK&apos;s &apos;mockkStatic&apos; for static mocking is discouraged. Refactor to use dependency injection." - errorLine1=" mockkStatic(AppCompatResources::class)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt" - line="424" - column="9"/> - </issue> - - <issue - id="NoStaticMocking" - message="Usage of MockK&apos;s &apos;unmockkStatic&apos; for static mocking is discouraged. Refactor to use dependency injection." - errorLine1=" unmockkStatic(AppCompatResources::class)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt" - line="435" - column="9"/> - </issue> - - <issue - id="NoStaticMocking" - message="Usage of MockK&apos;s &apos;mockkStatic&apos; for static mocking is discouraged. Refactor to use dependency injection." - errorLine1=" mockkStatic(AppCompatResources::class)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt" - line="452" - column="9"/> - </issue> - - <issue - id="NoStaticMocking" - message="Usage of MockK&apos;s &apos;unmockkStatic&apos; for static mocking is discouraged. Refactor to use dependency injection." - errorLine1=" unmockkStatic(AppCompatResources::class)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt" - line="465" - column="9"/> - </issue> - - <issue - id="NoStaticMocking" - message="Usage of MockK&apos;s &apos;mockkStatic&apos; for static mocking is discouraged. Refactor to use dependency injection." - errorLine1=" mockkStatic(AppCompatResources::class)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt" - line="529" - column="9"/> - </issue> - - <issue - id="NoStaticMocking" - message="Usage of MockK&apos;s &apos;unmockkStatic&apos; for static mocking is discouraged. Refactor to use dependency injection." - errorLine1=" unmockkStatic(AppCompatResources::class)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt" - line="535" - column="9"/> - </issue> - - <issue - id="NoStaticMocking" - message="Usage of MockK&apos;s &apos;mockkStatic&apos; for static mocking is discouraged. Refactor to use dependency injection." - errorLine1=" mockkStatic(&quot;mozilla.components.service.pocket.ext.PocketStoryKt&quot;) {" - errorLine2=" ^"> - <location - file="src/test/java/org/mozilla/fenix/home/pocket/DefaultPocketStoriesControllerTest.kt" - line="221" - column="9"/> - </issue> - - <issue - id="NoStaticMocking" - message="Usage of MockK&apos;s &apos;mockkStatic&apos; for static mocking is discouraged. Refactor to use dependency injection." - errorLine1=" mockkStatic(&quot;mozilla.components.service.pocket.ext.PocketStoryKt&quot;) {" - errorLine2=" ^"> - <location - file="src/test/java/org/mozilla/fenix/home/pocket/DefaultPocketStoriesControllerTest.kt" - line="273" - column="9"/> - </issue> - - <issue - id="NoStaticMocking" - message="Usage of MockK&apos;s &apos;mockkStatic&apos; for static mocking is discouraged. Refactor to use dependency injection." - errorLine1=" mockkStatic(&quot;mozilla.components.service.pocket.ext.PocketStoryKt&quot;) {" - errorLine2=" ^"> - <location - file="src/test/java/org/mozilla/fenix/home/pocket/DefaultPocketStoriesControllerTest.kt" - line="414" - column="9"/> - </issue> - - <issue - id="NoStaticMocking" - message="Usage of MockK&apos;s &apos;mockkStatic&apos; for static mocking is discouraged. Refactor to use dependency injection." - errorLine1=" mockkStatic(&quot;mozilla.components.service.pocket.ext.PocketStoryKt&quot;) {" - errorLine2=" ^"> - <location - file="src/test/java/org/mozilla/fenix/home/pocket/DefaultPocketStoriesControllerTest.kt" - line="466" - column="9"/> - </issue> - - <issue - id="NoStaticMocking" - message="Usage of MockK&apos;s &apos;mockkStatic&apos; for static mocking is discouraged. Refactor to use dependency injection." - errorLine1=" mockkStatic(&quot;mozilla.components.service.pocket.ext.PocketStoryKt&quot;) {" - errorLine2=" ^"> - <location - file="src/test/java/org/mozilla/fenix/home/pocket/DefaultPocketStoriesControllerTest.kt" - line="519" - column="9"/> - </issue> - - <issue - id="NoStaticMocking" - message="Usage of MockK&apos;s &apos;mockkStatic&apos; for static mocking is discouraged. Refactor to use dependency injection." - errorLine1=" mockkStatic(&quot;org.mozilla.fenix.ext.ContextKt&quot;)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/test/java/org/mozilla/fenix/components/toolbar/DefaultToolbarIntegrationTest.kt" - line="28" - column="9"/> - </issue> - - <issue - id="NoStaticMocking" - message="Usage of MockK&apos;s &apos;unmockkStatic&apos; for static mocking is discouraged. Refactor to use dependency injection." - errorLine1=" unmockkStatic(&quot;org.mozilla.fenix.ext.ContextKt&quot;)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/test/java/org/mozilla/fenix/components/toolbar/DefaultToolbarIntegrationTest.kt" - line="51" - column="9"/> - </issue> - - <issue - id="NoStaticMocking" - message="Usage of MockK&apos;s &apos;mockkStatic&apos; for static mocking is discouraged. Refactor to use dependency injection." - errorLine1=" mockkStatic(&quot;org.mozilla.fenix.ext.FragmentKt&quot;)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/test/java/org/mozilla/fenix/settings/HomeSettingsFragmentTest.kt" - line="47" - column="9"/> - </issue> - - <issue - id="NoStaticMocking" - message="Usage of MockK&apos;s &apos;mockkStatic&apos; for static mocking is discouraged. Refactor to use dependency injection." - errorLine1=" mockkStatic(&quot;org.mozilla.fenix.ext.ContextKt&quot;)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/test/java/org/mozilla/fenix/settings/HomeSettingsFragmentTest.kt" - line="48" - column="9"/> - </issue> - - <issue - id="NoStaticMocking" - message="Usage of MockK&apos;s &apos;unmockkStatic&apos; for static mocking is discouraged. Refactor to use dependency injection." - errorLine1=" unmockkStatic(&quot;org.mozilla.fenix.ext.ContextKt&quot;)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/test/java/org/mozilla/fenix/settings/HomeSettingsFragmentTest.kt" - line="69" - column="9"/> - </issue> - - <issue - id="NoStaticMocking" - message="Usage of MockK&apos;s &apos;unmockkStatic&apos; for static mocking is discouraged. Refactor to use dependency injection." - errorLine1=" unmockkStatic(&quot;org.mozilla.fenix.ext.FragmentKt&quot;)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/test/java/org/mozilla/fenix/settings/HomeSettingsFragmentTest.kt" - line="70" - column="9"/> - </issue> - - <issue - id="NoStaticMocking" - message="Usage of MockK&apos;s &apos;mockkStatic&apos; for static mocking is discouraged. Refactor to use dependency injection." - errorLine1=" mockkStatic(&quot;mozilla.components.support.utils.ext.ContextKt&quot;)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/test/java/org/mozilla/fenix/home/toolbar/HomeToolbarViewTest.kt" - line="39" - column="9"/> - </issue> - - <issue - id="NoStaticMocking" - message="Usage of MockK&apos;s &apos;mockkStatic&apos; for static mocking is discouraged. Refactor to use dependency injection." - errorLine1=" mockkStatic(&quot;org.mozilla.fenix.ext.ContextKt&quot;)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/test/java/org/mozilla/fenix/home/toolbar/HomeToolbarViewTest.kt" - line="40" - column="9"/> - </issue> - - <issue - id="NoStaticMocking" - message="Usage of MockK&apos;s &apos;unmockkStatic&apos; for static mocking is discouraged. Refactor to use dependency injection." - errorLine1=" unmockkStatic(&quot;mozilla.components.support.utils.ext.ContextKt&quot;)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/test/java/org/mozilla/fenix/home/toolbar/HomeToolbarViewTest.kt" - line="54" - column="9"/> - </issue> - - <issue - id="NoStaticMocking" - message="Usage of MockK&apos;s &apos;unmockkStatic&apos; for static mocking is discouraged. Refactor to use dependency injection." - errorLine1=" unmockkStatic(&quot;org.mozilla.fenix.ext.ContextKt&quot;)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/test/java/org/mozilla/fenix/home/toolbar/HomeToolbarViewTest.kt" - line="55" - column="9"/> - </issue> - - <issue - id="NoStaticMocking" - message="Usage of MockK&apos;s &apos;mockkStatic&apos; for static mocking is discouraged. Refactor to use dependency injection." - errorLine1=" mockkStatic(&quot;org.mozilla.fenix.settings.advanced.LocaleManagerExtensionKt&quot;)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/test/java/org/mozilla/fenix/settings/advanced/LocaleSettingsControllerTest.kt" - line="47" - column="9"/> - </issue> - - <issue - id="NoStaticMocking" - message="Usage of MockK&apos;s &apos;mockkStatic&apos; for static mocking is discouraged. Refactor to use dependency injection." - errorLine1=" mockkStatic(&quot;mozilla.components.support.ktx.android.util.DisplayMetricsKt&quot;)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/test/java/org/mozilla/fenix/ext/ViewTest.kt" - line="43" - column="9"/> - </issue> - - <issue - id="NoStaticMocking" - message="Usage of MockK&apos;s &apos;mockkStatic&apos; for static mocking is discouraged. Refactor to use dependency injection." - errorLine1=" mockkStatic(&quot;mozilla.components.support.utils.ext.WindowInsetsCompatKt&quot;)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/test/java/org/mozilla/fenix/ext/ViewTest.kt" - line="44" - column="9"/> - </issue> - - <issue - id="NoStaticMocking" - message="Usage of MockK&apos;s &apos;mockkStatic&apos; for static mocking is discouraged. Refactor to use dependency injection." - errorLine1=" mockkStatic(&quot;org.mozilla.fenix.ext.ViewKt&quot;)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/test/java/org/mozilla/fenix/ext/ViewTest.kt" - line="45" - column="9"/> - </issue> - - <issue id="ScrollViewSize" message="This LinearLayout should use `android:layout_height=&quot;wrap_content&quot;`" errorLine1=" android:layout_height=&quot;match_parent&quot;" @@ -382,7 +19,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> <location file="src/main/java/org/mozilla/fenix/ext/Context.kt" - line="85" + line="83" column="9"/> </issue> @@ -818,17 +455,6 @@ <issue id="DiscouragedApi" message="Use of this function is discouraged because resource reflection makes it harder to perform build optimizations and compile-time verification of code. It is much more efficient to retrieve resources by identifier (e.g. `R.foo.bar`) than by name (e.g. `getIdentifier(&quot;bar&quot;, &quot;foo&quot;, null)`)." - errorLine1=" val resourceId = context.resources.getIdentifier(" - errorLine2=" ~~~~~~~~~~~~~"> - <location - file="src/main/java/org/mozilla/fenix/settings/settingssearch/DefaultFenixSettingsIndexer.kt" - line="282" - column="48"/> - </issue> - - <issue - id="DiscouragedApi" - message="Use of this function is discouraged because resource reflection makes it harder to perform build optimizations and compile-time verification of code. It is much more efficient to retrieve resources by identifier (e.g. `R.foo.bar`) than by name (e.g. `getIdentifier(&quot;bar&quot;, &quot;foo&quot;, null)`)." errorLine1=" val resId = context.resources.getIdentifier(projectIdKey, &quot;string&quot;, context.packageName)" errorLine2=" ~~~~~~~~~~~~~"> <location @@ -1449,7 +1075,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> <location file="src/main/res/values-vi/strings.xml" - line="3752" + line="3751" column="62"/> </issue> @@ -1472,6 +1098,13 @@ <issue id="IconLocation" + message="Found bitmap drawable `res/drawable/ic_japan_onboarding_favicon.webp` in densityless folder"> + <location + file="src/main/res/drawable/ic_japan_onboarding_favicon.webp"/> + </issue> + + <issue + id="IconLocation" message="Found bitmap drawable `res/drawable/ic_wordmark_logo.webp` in densityless folder"> <location file="src/main/res/drawable/ic_wordmark_logo.webp"/> @@ -1611,224 +1244,4 @@ column="5"/> </issue> - <issue - id="NoObjectMocking" - message="Usage of MockK&apos;s &apos;mockkObject&apos; for object/singleton mocking is discouraged. Consider providing dependencies explicitly." - errorLine1=" mockkObject(FeatureFlags)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt" - line="108" - column="9"/> - </issue> - - <issue - id="NoObjectMocking" - message="Usage of MockK&apos;s &apos;unmockkObject&apos; for object/singleton mocking is discouraged. Consider providing dependencies explicitly." - errorLine1=" unmockkObject(FeatureFlags)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt" - line="113" - column="9"/> - </issue> - - <issue - id="NoObjectMocking" - message="Usage of MockK&apos;s &apos;mockkObject&apos; for object/singleton mocking is discouraged. Consider providing dependencies explicitly." - errorLine1=" mockkObject(ThemeManager.Companion)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt" - line="345" - column="9"/> - </issue> - - <issue - id="NoObjectMocking" - message="Usage of MockK&apos;s &apos;unmockkObject&apos; for object/singleton mocking is discouraged. Consider providing dependencies explicitly." - errorLine1=" unmockkObject(ThemeManager.Companion)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt" - line="356" - column="9"/> - </issue> - - <issue - id="NoObjectMocking" - message="Usage of MockK&apos;s &apos;mockkObject&apos; for object/singleton mocking is discouraged. Consider providing dependencies explicitly." - errorLine1=" mockkObject(ThemeManager.Companion)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt" - line="367" - column="9"/> - </issue> - - <issue - id="NoObjectMocking" - message="Usage of MockK&apos;s &apos;unmockkObject&apos; for object/singleton mocking is discouraged. Consider providing dependencies explicitly." - errorLine1=" unmockkObject(ThemeManager.Companion)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt" - line="377" - column="9"/> - </issue> - - <issue - id="NoObjectMocking" - message="Usage of MockK&apos;s &apos;mockkObject&apos; for object/singleton mocking is discouraged. Consider providing dependencies explicitly." - errorLine1=" mockkObject(ThemeManager.Companion)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt" - line="392" - column="9"/> - </issue> - - <issue - id="NoObjectMocking" - message="Usage of MockK&apos;s &apos;unmockkObject&apos; for object/singleton mocking is discouraged. Consider providing dependencies explicitly." - errorLine1=" unmockkObject(ThemeManager.Companion)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt" - line="406" - column="9"/> - </issue> - - <issue - id="NoObjectMocking" - message="Usage of MockK&apos;s &apos;mockkObject&apos; for object/singleton mocking is discouraged. Consider providing dependencies explicitly." - errorLine1=" mockkObject(ThemeManager.Companion)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt" - line="421" - column="9"/> - </issue> - - <issue - id="NoObjectMocking" - message="Usage of MockK&apos;s &apos;unmockkObject&apos; for object/singleton mocking is discouraged. Consider providing dependencies explicitly." - errorLine1=" unmockkObject(ThemeManager.Companion)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt" - line="434" - column="9"/> - </issue> - - <issue - id="NoObjectMocking" - message="Usage of MockK&apos;s &apos;mockkObject&apos; for object/singleton mocking is discouraged. Consider providing dependencies explicitly." - errorLine1=" mockkObject(ThemeManager.Companion)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt" - line="449" - column="9"/> - </issue> - - <issue - id="NoObjectMocking" - message="Usage of MockK&apos;s &apos;unmockkObject&apos; for object/singleton mocking is discouraged. Consider providing dependencies explicitly." - errorLine1=" unmockkObject(ThemeManager.Companion)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt" - line="464" - column="9"/> - </issue> - - <issue - id="NoObjectMocking" - message="Usage of MockK&apos;s &apos;mockkObject&apos; for object/singleton mocking is discouraged. Consider providing dependencies explicitly." - errorLine1=" mockkObject(ThemeManager.Companion)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt" - line="526" - column="9"/> - </issue> - - <issue - id="NoObjectMocking" - message="Usage of MockK&apos;s &apos;unmockkObject&apos; for object/singleton mocking is discouraged. Consider providing dependencies explicitly." - errorLine1=" unmockkObject(ThemeManager.Companion)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt" - line="534" - column="9"/> - </issue> - - <issue - id="NoObjectMocking" - message="Usage of MockK&apos;s &apos;mockkObject&apos; for object/singleton mocking is discouraged. Consider providing dependencies explicitly." - errorLine1=" mockkObject(DownloadCancelDialogFragment.Companion) {" - errorLine2=" ^"> - <location - file="src/test/java/org/mozilla/fenix/browser/store/BrowserScreenMiddlewareTest.kt" - line="56" - column="9"/> - </issue> - - <issue - id="NoObjectMocking" - message="Usage of MockK&apos;s &apos;mockkObject&apos; for object/singleton mocking is discouraged. Consider providing dependencies explicitly." - errorLine1=" mockkObject(DownloadCancelDialogFragment.Companion) {" - errorLine2=" ^"> - <location - file="src/test/java/org/mozilla/fenix/browser/store/BrowserScreenMiddlewareTest.kt" - line="100" - column="9"/> - </issue> - - <issue - id="NoObjectMocking" - message="Usage of MockK&apos;s &apos;mockkObject&apos; for object/singleton mocking is discouraged. Consider providing dependencies explicitly." - errorLine1=" mockkObject(ContentRecommendationsFeatureHelper) {" - errorLine2=" ^"> - <location - file="src/test/java/org/mozilla/fenix/settings/HomeSettingsFragmentTest.kt" - line="75" - column="9"/> - </issue> - - <issue - id="NoObjectMocking" - message="Usage of MockK&apos;s &apos;mockkObject&apos; for object/singleton mocking is discouraged. Consider providing dependencies explicitly." - errorLine1=" mockkObject(ContentRecommendationsFeatureHelper) {" - errorLine2=" ^"> - <location - file="src/test/java/org/mozilla/fenix/settings/HomeSettingsFragmentTest.kt" - line="86" - column="9"/> - </issue> - - <issue - id="NoObjectMocking" - message="Usage of MockK&apos;s &apos;mockkObject&apos; for object/singleton mocking is discouraged. Consider providing dependencies explicitly." - errorLine1=" mockkObject(LocaleManager)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/test/java/org/mozilla/fenix/settings/advanced/LocaleManagerExtensionTest.kt" - line="31" - column="9"/> - </issue> - - <issue - id="NoObjectMocking" - message="Usage of MockK&apos;s &apos;mockkObject&apos; for object/singleton mocking is discouraged. Consider providing dependencies explicitly." - errorLine1=" mockkObject(LocaleManager)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/test/java/org/mozilla/fenix/settings/advanced/LocaleSettingsControllerTest.kt" - line="46" - column="9"/> - </issue> - </issues> diff --git a/mobile/android/focus-android/app/lint-baseline.xml b/mobile/android/focus-android/app/lint-baseline.xml @@ -608,12 +608,23 @@ <issue id="UnusedResources" + message="The resource `R.color.mozac_ui_icons_fill` appears to be unused" + errorLine1=" &lt;color name=&quot;mozac_ui_icons_fill&quot;>@color/primaryText&lt;/color>" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~"> + <location + file="src/main/res/values/colors.xml" + line="124" + column="12"/> + </issue> + + <issue + id="UnusedResources" message="The resource `R.color.mozac_additional_note_background` appears to be unused" errorLine1=" &lt;color name=&quot;mozac_additional_note_background&quot;>@color/colorPrimary&lt;/color>" errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> <location file="src/main/res/values/colors.xml" - line="124" + line="125" column="12"/> </issue> @@ -624,7 +635,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> <location file="src/main/res/values/colors.xml" - line="125" + line="126" column="12"/> </issue> @@ -635,7 +646,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~"> <location file="src/main/res/values/colors.xml" - line="131" + line="132" column="12"/> </issue>