commit d2dd07ad9650556f3583144abc68a4bab02f779d
parent dc57cf026b2163c41e279717de55e9a2638029fb
Author: Kent Tamura <tkent@chromium.org>
Date: Thu, 27 Nov 2025 15:16:09 +0000
Bug 2002512 [wpt PR 56295] - Fix a DCHECK failure by changing writing-mode of an element with text-combine-upright, a=testonly
Automatic update from web-platform-tests
Fix a DCHECK failure by changing writing-mode of an element with text-combine-upright
* We used IsHorizontalWritingMode() and IsHorizontalTypographicMode()
inconsistently to check text-combine-upright capability. It caused a
DCHECK failure in PropagateStyleToAnonymousChildren(). This CL unify
them to the latter.
* Fix a null pointer deference in a DCHECK due to list-item.
Bug: 461332428
Change-Id: Ifcdb61bd59fccafb1e58173a1c073f99e34ba502
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7206387
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Auto-Submit: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1550343}
--
wpt-commits: 3636115ed28152fd1baa7add5ff606a5e316da7a
wpt-pr: 56295
Diffstat:
1 file changed, 14 insertions(+), 0 deletions(-)
diff --git a/testing/web-platform/tests/css/css-writing-modes/text-combine-upright-sideways-crash.html b/testing/web-platform/tests/css/css-writing-modes/text-combine-upright-sideways-crash.html
@@ -0,0 +1,14 @@
+<!DOCTYPE html>
+<meta charset=utf-8>
+<title>Changing writing-mode of an element with text-combine-upright should not crash</title>
+<link rel="author" title="Kent Tamura" href="mailto:tkent@chromium.orgm"/>
+<link rel="help" href="https://drafts.csswg.org/css-writing-modes-3/#text-combine-upright"/>
+<link rel="help" href="https://crbug.com/461332428"/>
+<body>
+<div id="target" style="display: list-item; text-combine-upright: all; writing-mode: vertical-rl;"></div>
+<script>
+target.offsetTop;
+target.style.writingMode = "sideways-rl";
+target.offsetTop;
+</script>
+</body>
